Re: [Nouveau] [PATCH 17/25] PCI/P2PDMA: use the dev_pagemap internal refcount

2019-06-27 Thread Logan Gunthorpe
On 2019-06-26 6:27 a.m., Christoph Hellwig wrote: > The functionality is identical to the one currently open coded in > p2pdma.c. > > Signed-off-by: Christoph Hellwig Reviewed-by: Logan Gunthorpe Also, for the P2PDMA changes in this series: Tested-by: Logan Gunthorpe I've ran this series

[Nouveau] [Bug 111006] Adding a uniform-dependent if-statement in shader renders a different image

2019-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111006 Karol Herbst changed: What|Removed |Added URL||https://trello.com/c/ESKBoR

[Nouveau] [Bug 111006] Adding a uniform-dependent if-statement in shader renders a different image

2019-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111006 Karol Herbst changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|nouveau@list

Re: [Nouveau] [PATCH 03/25] mm: remove hmm_devmem_add_resource

2019-06-27 Thread Christoph Hellwig
On Thu, Jun 27, 2019 at 04:18:22PM +, Jason Gunthorpe wrote: > On Wed, Jun 26, 2019 at 02:27:02PM +0200, Christoph Hellwig wrote: > > This function has never been used since it was first added to the kernel > > more than a year and a half ago, and if we ever grow a consumer of the > > MEMORY_DE

Re: [Nouveau] [PATCH 12/25] memremap: add a migrate_to_ram method to struct dev_pagemap_ops

2019-06-27 Thread Christoph Hellwig
On Thu, Jun 27, 2019 at 04:29:45PM +, Jason Gunthorpe wrote: > I'ver heard there are some other use models for fault() here beyond > migrate to ram, but we can rename it if we ever see them. Well, it absolutely needs to migrate to some piece of addressable and coherent memory, so ram might be

Re: [PATCH 24/25] mm: remove the HMM config option

2019-06-27 Thread Jason Gunthorpe
On Wed, Jun 26, 2019 at 02:27:23PM +0200, Christoph Hellwig wrote: > All the mm/hmm.c code is better keyed off HMM_MIRROR. Also let nouveau > depend on it instead of the mix of a dummy dependency symbol plus the > actually selected one. Drop various odd dependencies, as the code is > pretty porta

Re: [Nouveau] [PATCH 12/25] memremap: add a migrate_to_ram method to struct dev_pagemap_ops

2019-06-27 Thread Jason Gunthorpe
On Wed, Jun 26, 2019 at 02:27:11PM +0200, Christoph Hellwig wrote: > This replaces the hacky ->fault callback, which is currently directly > called from common code through a hmm specific data structure as an > exercise in layering violations. > > Signed-off-by: Christoph Hellwig > Reviewed-by: R

Re: [Nouveau] [PATCH 20/25] mm: remove hmm_vma_alloc_locked_page

2019-06-27 Thread Jason Gunthorpe
On Wed, Jun 26, 2019 at 02:27:19PM +0200, Christoph Hellwig wrote: > The only user of it has just been removed, and there wasn't really any need > to wrap a basic memory allocator to start with. > > Signed-off-by: Christoph Hellwig > --- > include/linux/hmm.h | 3 --- > mm/hmm.c| 14

Re: [Nouveau] [PATCH 03/25] mm: remove hmm_devmem_add_resource

2019-06-27 Thread Jason Gunthorpe
On Wed, Jun 26, 2019 at 02:27:02PM +0200, Christoph Hellwig wrote: > This function has never been used since it was first added to the kernel > more than a year and a half ago, and if we ever grow a consumer of the > MEMORY_DEVICE_PUBLIC infrastructure it can easily use devm_memremap_pages > direct

[Nouveau] [Bug 111006] Adding a uniform-dependent if-statement in shader renders a different image

2019-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111006 --- Comment #4 from Abel Briggs --- If you're referring to the Meson(In reply to Paul from comment #2) > Hi Abel. > > Could you provide your configure command, please? If you mean the Meson configure command, the only things I changed from the

[Nouveau] [Bug 111006] Adding a uniform-dependent if-statement in shader renders a different image

2019-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111006 --- Comment #3 from Karol Herbst --- this is caused by a "call/return stack" overflow. We know of another shader causing this issue in a game, so it's something we probably want to fix. -- You are receiving this mail because: You are the assig

[Nouveau] [Bug 111006] Adding a uniform-dependent if-statement in shader renders a different image

2019-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111006 --- Comment #2 from Paul --- Hi Abel. Could you provide your configure command, please? -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug._

Re: [Nouveau] [PATCH 15/25] memremap: provide an optional internal refcount in struct dev_pagemap

2019-06-27 Thread Christoph Hellwig
On Wed, Jun 26, 2019 at 02:47:50PM -0700, Ira Weiny wrote: > > + > > + init_completion(&pgmap->done); > > + error = percpu_ref_init(&pgmap->internal_ref, > > + dev_pagemap_percpu_release, 0, GFP_KERNEL); > > + if (error) > > +

Re: [Nouveau] [PATCH 11/25] memremap: lift the devmap_enable manipulation into devm_memremap_pages

2019-06-27 Thread Christoph Hellwig
On Wed, Jun 26, 2019 at 12:04:46PM -0700, Ira Weiny wrote: > > +static int devmap_managed_enable_get(struct device *dev, struct > > dev_pagemap *pgmap) > > +{ > > + if (!pgmap->ops->page_free) { > > NIT: later on you add the check for pgmap->ops... it should probably be here. > > But not sure

[Nouveau] [Bug 111006] Adding a uniform-dependent if-statement in shader renders a different image

2019-06-27 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=111006 Michel Dänzer changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |nouveau@lists.freedesktop.o