[Nouveau] [PATCH drm-misc-next 2/2] drm/nouveau: enable dynamic job-flow control

2023-11-13 Thread Danilo Krummrich
Make use of the scheduler's credit limit and scheduler job's credit count to account for the actual size of a job, such that we fill up the ring efficiently. Signed-off-by: Danilo Krummrich --- drivers/gpu/drm/nouveau/nouveau_abi16.c | 3 ++- drivers/gpu/drm/nouveau/nouveau_drm.c | 2 +- drive

[Nouveau] [PATCH drm-misc-next 1/2] drm/nouveau: implement 1:1 scheduler - entity relationship

2023-11-13 Thread Danilo Krummrich
Recent patches to the DRM scheduler [1][2] allow for a variable number of run-queues and add support for (shared) workqueues rather than dedicated kthreads per scheduler. This allows us to create a 1:1 relationship between a GPU scheduler and a scheduler entity, in order to properly support firmwar

[Nouveau] [PATCH drm-misc-next] drm/nouveau: use GPUVM common infrastructure

2023-11-13 Thread Danilo Krummrich
GPUVM provides common infrastructure to track external and evicted GEM objects as well as locking and validation helpers. Especially external and evicted object tracking is a huge improvement compared to the current brute force approach of iterating all mappings in order to lock and validate the G

Re: [Nouveau] [PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Danilo Krummrich
On 11/13/23 19:55, Abhinav Singh wrote: On 11/14/23 00:19, Danilo Krummrich wrote: Hi, thanks for sending a v2. On 11/13/23 19:42, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencin

Re: [Nouveau] [PATCH v2] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Danilo Krummrich
Hi, thanks for sending a v2. On 11/13/23 19:42, Abhinav Singh wrote: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. Better use imperative here, e.g. "Fix a sparse w

Re: [Nouveau] [PATCH] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Danilo Krummrich
On 11/13/23 09:24, Maarten Lankhorst wrote: Hey, Den 2023-11-13 kl. 09:10, skrev Abhinav Singh: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be direc

Re: [Nouveau] [PATCH drm-misc-next v8 09/12] drm/gpuvm: reference count drm_gpuvm structures

2023-11-13 Thread Danilo Krummrich
On 11/13/23 08:22, Christian König wrote: Am 10.11.23 um 17:57 schrieb Danilo Krummrich: On 11/10/23 09:50, Christian König wrote: [SNIP] Another issue Christian brought up is that something intended to be embeddable (a base class) shouldn't really have its own refcount. I think that's a v

Re: [Nouveau] [PATCH] driver: gpu: Fixing warning directly dereferencing a rcu pointer

2023-11-13 Thread Maarten Lankhorst
Hey, Den 2023-11-13 kl. 09:10, skrev Abhinav Singh: This patch fixes a sparse warning with this message "warning:dereference of noderef expression". In this context it means we are dereferencing a __rcu tagged pointer directly. We should not be directly dereferencing a rcu pointer, rather we sh