Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-18 Thread Denis Kenzior
Hi Martin, Instead of this dance of opening / closing the chat in order to force-cancel the 'AT' command queued in gemalto_enable(), maybe there should be something in GAtChat itself to handle this case. There's also the retry logic used on quectel modems with auto-detection of baud ra

Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-18 Thread Martin Hundebøll
Hi Denis and Sergey, On 17/08/2020 21.54, Denis Kenzior wrote: diff --git a/plugins/gemalto.c b/plugins/gemalto.c index 238c7cc4..321c8c1b 100644 --- a/plugins/gemalto.c +++ b/plugins/gemalto.c @@ -222,6 +222,8 @@ static void sim_state_cb(gboolean present, gpointer user_data)   struct ofon

Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-17 Thread Sergey Matyukevich
Hello Denis, > > Function gemalto_modem_ready attempts to restart AT chat data->app > > after incomplete shutdown. As a result, new AT chat does not work > > as expected loosing AT commands. > > > > Signed-off-by: Sergey Matyukevich > > --- > > plugins/gemalto.c | 8 > > 1 file chan

Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-17 Thread Denis Kenzior
Hi Sergey, On 8/15/20 4:43 PM, Sergey Matyukevich wrote: Function gemalto_modem_ready attempts to restart AT chat data->app after incomplete shutdown. As a result, new AT chat does not work as expected loosing AT commands. Signed-off-by: Sergey Matyukevich --- plugins/gemalto.c | 8

Re: [RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-17 Thread Sergey Matyukevich
> Function gemalto_modem_ready attempts to restart AT chat data->app > after incomplete shutdown. As a result, new AT chat does not work > as expected loosing AT commands. > > Signed-off-by: Sergey Matyukevich > --- > plugins/gemalto.c | 8 > 1 file changed, 8 insertions(+) > > diff -

[RFC PATCH 4/4] plugins: gemalto: fix incomplete at-chat shutdown

2020-08-15 Thread Sergey Matyukevich
Function gemalto_modem_ready attempts to restart AT chat data->app after incomplete shutdown. As a result, new AT chat does not work as expected loosing AT commands. Signed-off-by: Sergey Matyukevich --- plugins/gemalto.c | 8 1 file changed, 8 insertions(+) diff --git a/plugins/gemal