Committed revision 2399.
Fabio M. Di Nitto wrote:
> Look ok to me..
>
> On Thu, 2009-08-27 at 17:12 +0200, Jan Friesse wrote:
>> Attached is proposed patch for Makefile.am and configure.ac so I will be
>> able to push cpg_iteration implementation and we will able to increase
>> cpg lib version in
Look ok to me..
On Thu, 2009-08-27 at 17:12 +0200, Jan Friesse wrote:
> Attached is proposed patch for Makefile.am and configure.ac so I will be
> able to push cpg_iteration implementation and we will able to increase
> cpg lib version independently on other libs.
>
> Regards,
> Honza
>
> Stev
Attached is proposed patch for Makefile.am and configure.ac so I will be
able to push cpg_iteration implementation and we will able to increase
cpg lib version independently on other libs.
Regards,
Honza
Steven Dake wrote:
> On Thu, 2009-08-20 at 15:53 +0200, Fabio M. Di Nitto wrote:
>> On Thu,
On Thu, 2009-08-20 at 15:53 +0200, Fabio M. Di Nitto wrote:
> On Thu, 2009-08-20 at 15:18 +0200, Jan Friesse wrote:
> > Fabio,
> > when will libtool happened? I would like to have this feature + tool in
> > Corosync 1.1.0.
>
> I don't know. I think Jim started on this conversion. If necessary I c
On Thu, 2009-08-20 at 15:18 +0200, Jan Friesse wrote:
> Fabio,
> when will libtool happened? I would like to have this feature + tool in
> Corosync 1.1.0.
I don't know. I think Jim started on this conversion. If necessary I can
take it over but it won't happen overnight.
> Is attached patch good
Fabio,
when will libtool happened? I would like to have this feature + tool in
Corosync 1.1.0.
Is attached patch good solution of problem?
Regards,
Honza
Fabio M. Di Nitto napsal(a):
On Wed, 2009-08-19 at 21:57 -0700, Steven Dake wrote:
On Thu, 2009-08-20 at 06:39 +0200, Fabio M. Di Nitto
Steve,
take2 patch included.
+ cpg_iteration_instance_finalize (cpg_iteration_instance);
+ }
+ hdb_handle_destroy (&cpg_handle_t_db, handle);
+}
+
this handle destroy doesn't make any sense since cpg_finalize should be
doing the hdb_handle_destroy. This will result
On Wed, 2009-08-19 at 21:57 -0700, Steven Dake wrote:
> On Thu, 2009-08-20 at 06:39 +0200, Fabio M. Di Nitto wrote:
> > This change the API and ABI for cpg.
> >
> > Before this change can go anywhere, it needs proper Makefile.am love or
> > even easier queue it after libtool changes that makes sli
On Thu, 2009-08-20 at 06:39 +0200, Fabio M. Di Nitto wrote:
> This change the API and ABI for cpg.
>
> Before this change can go anywhere, it needs proper Makefile.am love or
> even easier queue it after libtool changes that makes slightly easier to
> have per library API and ABI versioning.
>
>
This change the API and ABI for cpg.
Before this change can go anywhere, it needs proper Makefile.am love or
even easier queue it after libtool changes that makes slightly easier to
have per library API and ABI versioning.
Let's try, as a general rule, to avoid the same nightmare we had between
w
comments inline. Looks pretty good though.
Regards
-steve
On Wed, 2009-08-19 at 16:31 +0200, Jan Friesse wrote:
> Implementation of DRAFT API. Look like there are no leaks, valgrind
> problems, ...
>
> Regards,
> Honza
> plain text document attachment
> (0001-Implementation-of-cpg_iteration-f
Implementation of DRAFT API. Look like there are no leaks, valgrind
problems, ...
Regards,
Honza
>From 02a9fbad2db3ee019c735422dc064fed0179e103 Mon Sep 17 00:00:00 2001
From: Jan Friesse
Date: Wed, 19 Aug 2009 15:17:27 +0200
Subject: [PATCH] Implementation of cpg_iteration functions
---
trunk
12 matches
Mail list logo