Re: Code style guide lines

2013-07-25 Thread Richard Bair
>>> I think you should also write down the policy when a Simple*Property >>> used? - we discussed that same months ago already >> >> I'd be happy to put it in the wiki if you give me some words. I'm overloaded >> and drowning :) >> > > Ok. Let me see if I can come up with some words on this. Wo

Re: Code style guide lines

2013-07-25 Thread Tom Schindl
On 25.07.13 20:59, Richard Bair wrote: >> * Should a switch always have a default-case? - According to the Java >> guidelines this should be! > > I would say definitely yes. The default clause should throw an AssertionError > if it really is unexpected. This will catch cases where we add an enum

Re: Code style guide lines

2013-07-25 Thread Richard Bair
> * Should a switch always have a default-case? - According to the Java > guidelines this should be! I would say definitely yes. The default clause should throw an AssertionError if it really is unexpected. This will catch cases where we add an enum type and don't add the right clause to a switc

Re: Code style guide lines

2013-07-25 Thread Tom Schindl
Hi, Well what I'm interested more is things like: * Should a switch always have a default-case? - According to the Java guidelines this should be! * Why are so many things not generified but use the raw types? - It looks like you are all running with raw-type warnings off, which has the effect t

Re: Code style guide lines

2013-07-25 Thread Richard Bair
I started a guide on our wiki a while ago: https://wiki.openjdk.java.net/display/OpenJFX/Policies+and+Processes But I only started it I never actually finished it or even asked anybody else what they thought of it :-). In general we follow the standard sun guidelines. We use spaces, not tabs.

Code style guide lines

2013-07-25 Thread Tom Schindl
Hi, I'm once more doing a clean up pass to get out of the way warnings in the control codebase - RT-31907. Do you guys follow any coding guide lines? Wouldn't it be good if the JavaFX codebase would follow http://openjdk.java.net/guide/codeConventions.html Tom