On Wed, 8 Feb 2023 00:12:14 GMT, Nir Lisker wrote:
>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
Marked as reviewed by kcr (Lead).
-
On Wed, 8 Feb 2023 00:12:14 GMT, Nir Lisker wrote:
>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
Marked as reviewed by jhendrikx (Committer).
On Wed, 8 Feb 2023 00:12:14 GMT, Nir Lisker wrote:
>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Addressed review comments
definitely an improvement, thank you.
-
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Addressed review comments
-
Changes:
- all: https://git.openjdk.org/jfx/pull/1025/files
- new: https://git.openjdk.o
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
-
Changes:
- all: https://git.openjdk.org
On Tue, 7 Feb 2023 19:52:14 GMT, Kevin Rushforth wrote:
>> A specialized layout... +1
>
> +1 from me as well.
Suggestion:
* A specialized layout for rich text.
-
PR: https://git.openjdk.org/jfx/pull/1025
On Tue, 7 Feb 2023 20:54:20 GMT, John Hendrikx wrote:
>> We aren't very consistent on this. Most of the places where we produce
>> warnings, or where we provide verbose output, are done by printing. At a
>> minimum, those should go to `System.err` rather than `System.out`. Unless
>> there is a
On Tue, 7 Feb 2023 19:51:55 GMT, Kevin Rushforth wrote:
>> I wish we were using logging...
>
> We aren't very consistent on this. Most of the places where we produce
> warnings, or where we provide verbose output, are done by printing. At a
> minimum, those should go to `System.err` rather than
On Tue, 7 Feb 2023 17:17:00 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
>> 143:
>>
>>> 141: * application may set them to other values as needed:
>>> 142: *
>>> 143: * textflow.setMaxWidth(500);
>>
>> Maybe remove the `` tag whil
On Tue, 7 Feb 2023 19:33:45 GMT, Andy Goryachev wrote:
>> Maybe it's special in the sense that it's specialized towards displaying
>> text, unlike other `Pane`s that are multi-purpose for all nodes. "designed
>> to" already points to that. Maybe "A specialized layout for rich text."?
>
> A spec
On Tue, 7 Feb 2023 19:31:58 GMT, Andy Goryachev wrote:
>> I never understood when something should be logged vs. printed. And do we
>> ever print to `out`?
>
> I wish we were using logging...
We aren't very consistent on this. Most of the places where we produce
warnings, or where we provide v
On Tue, 7 Feb 2023 17:11:50 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java line
>> 62:
>>
>>> 60:
>>> 61: /**
>>> 62: * A special layout designed to lay out rich text.
>>
>> What's "special" about it? :-)
>> Suggestion:
>>
>> * A layout desi
On Tue, 7 Feb 2023 17:14:27 GMT, Nir Lisker wrote:
>> modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 3277:
>>
>>> 3275: private void processDropEnd(DragEvent de) {
>>> 3276: if (source == null) {
>>> 3277: System.out.println("Scene.DnDGestu
On Tue, 7 Feb 2023 17:12:48 GMT, Nir Lisker wrote:
>> Fixes and cleanup in the areas in the linked issue.
>
> Nir Lisker has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Update
> modules/javafx.graphics/src/main/java/javafx/scene/text/T
On Tue, 7 Feb 2023 13:05:21 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Update
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>>
>>Co-authored-by: John
On Tue, 7 Feb 2023 12:25:14 GMT, John Hendrikx wrote:
>> Nir Lisker has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Update
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>>
>>Co-authored-by: John He
On Tue, 7 Feb 2023 12:17:43 GMT, Kevin Rushforth wrote:
>> Nir Lisker has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Update
>> modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
>>
>>Co-authored-by: John
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with three additional
commits since the last revision:
- Update modules/javafx.graphics/src/main/java/javafx/scene/text/TextFlow.java
Co-authored-by: John Hendrikx
- Update modul
> Fixes and cleanup in the areas in the linked issue.
Nir Lisker has updated the pull request incrementally with one additional
commit since the last revision:
Update
modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java
Co-authored-by: John Hendrikx
-
C
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote:
> Fixes and cleanup in the areas in the linked issue.
Other than John's comments, this looks good to me. I noted one more possible
formatting change and an unrelated follow-up cleanup issue I plan to file.
modules/javafx.graphics/src/main/java
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote:
> Fixes and cleanup in the areas in the linked issue.
Looks good to me, I added some more minor suggestions as well.
modules/javafx.controls/src/main/java/javafx/scene/control/ListView.java line
467:
> 465: /**
> 466: * The {@code No
On Mon, 6 Feb 2023 23:00:17 GMT, Nir Lisker wrote:
> Fixes and cleanup in the areas in the linked issue.
Integrating can wait until a bit before the release to allow for more mistakes
to be included.
-
PR: https://git.openjdk.org/jfx/pull/1025
Fixes and cleanup in the areas in the linked issue.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jfx/pull/1025/files
Webrev: https://webrevs.openjdk.org/?repo=jfx&pr=1025&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8293587
Stats: 50 lines in 6 fi
23 matches
Mail list logo
