Re: [Openlp-core] [Merge] lp:~wesleystout/openlp/documentation into lp:openlp

2010-12-21 Thread Raoul Snyman
Do you want those two revisions in the merge as well? -- https://code.launchpad.net/~wesleystout/openlp/documentation/+merge/44333 Your team OpenLP Core is requested to review the proposed merge of lp:~wesleystout/openlp/documentation into lp:openlp. _

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/i18n into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol-hush/openlp/i18n/+merge/44429 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Bug 691952] Re: To create a songs fails

2010-12-21 Thread Raoul Snyman
** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/691952 Title: To create a songs fails Status in OpenLP - Worship Presentation Softwa

[Openlp-core] [Bug 693150] Re: Custom Slide Display footer option

2010-12-21 Thread Raoul Snyman
** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/693150 Title: Custom Slide Display footer option Status in OpenLP - Worship Presenta

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread noreply
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated. Status: Approved => Merged -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44386 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https

Re: [Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/44413 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Raoul Snyman
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44386 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list:

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread noreply
The proposal to merge lp:~googol-hush/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44381 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Ma

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Raoul Snyman
The proposal to merge lp:~googol-hush/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44381 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Approve Thanks! -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44381 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Un

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44386 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : htt

[Openlp-core] [Merge] lp:~meths/openlp/trivialfixes into lp:openlp

2010-12-21 Thread Jon Tibble
Jon Tibble has proposed merging lp:~meths/openlp/trivialfixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Cleanups -- https://code.launchpad.net/~meths/openlp/trivialfixes/+merge/44413 Your team OpenLP Core is requested to review the proposed merge of lp:~meths/openlp/trivia

[Openlp-core] [Bug 693150] Re: Custom Slide Display footer option

2010-12-21 Thread John Cegalis
As my feeble brain finally understands your point above, thank you for explaining. Just in case, there are 3 places for Customs, Media Manager, Plugins list and Config Customs. Thanks Tim. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to Ope

[Openlp-core] [Bug 693202] [NEW] delete theme

2010-12-21 Thread John Cegalis
Public bug reported: I'm not sure if this is by design or what should be done about it. If a theme is associated with songs, it cannot be deleted. If the theme is stale and no longer used, and you have a huge database of songs, how would you ever find each song it is associated with. If I rena

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Jon Tibble
Review: Approve Thanks. -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44386 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Bug 691952] Re: To create a songs fails

2010-12-21 Thread Tim Bentley
** Changed in: openlp Status: Confirmed => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/691952 Title: To create a songs fails Status in OpenLP - Worship Presentation Software:

[Openlp-core] [Bug 693150] Re: Custom Slide Display footer option

2010-12-21 Thread Launchpad Bug Tracker
** Branch linked: lp:~trb143/openlp/bugs -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/693150 Title: Custom Slide Display footer option Status in OpenLP - Worship Presentation Software: Fix Commi

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Tim Bentley
Review: Approve Totally Approve -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44381 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpa

[Openlp-core] [Bug 693150] Re: Custom Slide Display footer option

2010-12-21 Thread Tim Bentley
This is not a bug. If you add credits then that needs to be displayed. The Title is the Optional bit! ** Changed in: openlp Status: New => Fix Committed ** Changed in: openlp Importance: Undecided => Low ** Changed in: openlp Milestone: None => 1.9.4 ** Changed in: openlp Ass

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp. Requested reviews: Jon Tibble (meths) Raoul Snyman (raoul-snyman) Related bugs: #693150 Custom Slide Display footer option https://bugs.launchpad.net/bugs/693150 Fix song Saving bug 691952 Fix Custom edit bug 693150

[Openlp-core] [Bug 693150] [NEW] Custom Slide Display footer option

2010-12-21 Thread John Cegalis
Public bug reported: bzr 1153. Create Custom slide with name and Credits. The footer is displayed whether Display Footer is selected or not in Config Custom. I also think the name of the tab should say "Custom" without the s and should in Plugin list as well. Customs doesn't really make sense

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Added the "final credit" from version 1. I hope the formatting is alright: http://img6.imageshack.us/img6/4291/finalcredit.png Cheers -- https://code.launchpa

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Needs Fixing Jon is correct. Simply change the "whitespace" to "self.whitespace" and your problem is solved. -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44365 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing lis

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Tim Bentley
This is a temporary fix until it gets sorted correctly. ATM song saving fails ! -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44365 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core

[Openlp-core] [Bug 672164] Re: when clicking on impress bug appears, and does not let presentation load

2010-12-21 Thread John Cegalis
I have a new bug and Impress still will not start. bzr1153 Traceback (most recent call last): File "/usr/lib/pymodules/python2.6/openlp/plugins/presentations/lib/messagelistener.py", line 263, in startup file = os.path.join(item.get_frame_path(), File "/usr/lib/pymodules/python2.6/openlp

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Jon Tibble
Review: Needs Fixing >From the docs it looks like this is the correct fix. Could you remove rather >than comment and remove self.whitespace from the top too please? (Not sure >why this doesn't get called as self.whitespace here - would it make any >difference?) -- https://code.launchpad.net/~

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Revert some of 1036 as causes Songs to fail to save. Bug 691952 -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44365 Your team OpenLP Core is requested to review th

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread noreply
The proposal to merge lp:~googol-hush/openlp/trivial into lp:openlp has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44347 Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread noreply
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44343 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: h

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Tim Bentley
Review: Approve Approved -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44347 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net U

[Openlp-core] [Bug 691952] Re: To create a songs fails

2010-12-21 Thread Andreas Preikschat
Hello! This is actually not fixed! As said before, you need (!) to enter lyrics to reproduce this! For example: http://img87.imageshack.us/img87/7605/39669186.png ** Changed in: openlp Status: Fix Released => Confirmed -- You received this bug notification because you are a member of Ope

Re: [Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Jon Tibble
Review: Approve Could be worth refactoring at some point, not sure about adding basically the same thing in three places but that can be looked at separately. -- https://code.launchpad.net/~googol-hush/openlp/trivial/+merge/44347 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Jon Tibble
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44343 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : htt

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Andreas Preikschat
The proposal to merge lp:~googol-hush/openlp/trivial into lp:openlp has been updated. Description changed to: Added/modified file extension filter. PS: The other proposal has been deleted. I think I should ship this in one merge and not two... -- https://code.launchpad.net/~googol-hush/openlp

[Openlp-core] [Merge] lp:~googol-hush/openlp/trivial into lp:openlp

2010-12-21 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol-hush/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Added/modified file extension filter. PS: The other proposal has been deleted. I think I should ship this in one merge and not two... -- https://code.launchpa

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Bible plugin had DnD addition to existing Service Item removed a few months ago. The context menu item was missed. -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/4434

[Openlp-core] [Merge] lp:~googol-hush/openlp/bibles into lp:openlp

2010-12-21 Thread Andreas Preikschat
The proposal to merge lp:~googol-hush/openlp/bibles into lp:openlp has been updated. Status: Needs review => Work in progress -- https://code.launchpad.net/~googol-hush/openlp/bibles/+merge/44265 Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Merge] lp:~wesleystout/openlp/documentation into lp:openlp

2010-12-21 Thread Wesley Stout
Wesley Stout has proposed merging lp:~wesleystout/openlp/documentation into lp:openlp. Requested reviews: OpenLP Core (openlp-core) various little fixes -- https://code.launchpad.net/~wesleystout/openlp/documentation/+merge/44333 Your team OpenLP Core is requested to review the proposed merg

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread noreply
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44327 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: h

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44327 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : htt

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/bugs into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Add debugging for theme editing Fix incorrect Settings tags -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44327 Your team OpenLP Core is requested to review the pro

[Openlp-core] [Bug 661867] Re: Invalid author added in song dialog

2010-12-21 Thread Tim Bentley
I have tried to trigger this and have managed to twice but cannot remember the exact sequence to do this. I spent over 1 hour doing random things with no luck. I have added in a previous commit more debugging so we may see what is happening as it seems to be a strange code path being traveled. -

[Openlp-core] [Bug 661867] Re: Invalid author added in song dialog

2010-12-21 Thread m2j
Hmm, should be a obvious idea. Still I missed to record debug logs by default. Thanks for the hint. ** Changed in: openlp Assignee: (unassigned) => m2j (m2j) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.

[Openlp-core] [Bug 691952] Re: To create a songs fails

2010-12-21 Thread Tim Bentley
** Changed in: openlp Status: Confirmed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/691952 Title: To create a songs fails Status in OpenLP - Worship Presentation Software:

[Openlp-core] [Bug 692684] Re: Theme Wizard not updating

2010-12-21 Thread Tim Bentley
** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/692684 Title: Theme Wizard not updating Status in OpenLP - Worship Presentation Soft

[Openlp-core] [Bug 692684] Re: Theme Wizard not updating

2010-12-21 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/692684 Title: Theme Wizard not updating Status in OpenLP - Worship Presentation Software: Fix Released Bug description:

[Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread noreply
The proposal to merge lp:~trb143/openlp/bugs into lp:openlp has been updated. Status: Needs review => Merged -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44279 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: h

Re: [Openlp-core] [Merge] lp:~crichter/openlp/bugfixing into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Needs Fixing As m2j said, please just handle the case where there are no verses. Thanks. -- https://code.launchpad.net/~crichter/openlp/bugfixing/+merge/44196 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://lau

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bugs into lp:openlp

2010-12-21 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/bugs/+merge/44279 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe : htt