I've made some fast tests on Linux. In general it works. In detail there are a
lot things to improove.
A general question (maybe I missed sone previous discussion): Why do we need
this subfolder structure? I can understand the data directory as this allows us
to place more directories into ~/.o
Stevan Pettit has proposed merging lp:~smpettit/openlp/data-path into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~smpettit/openlp/data-path/+merge/89612
Added code to allow users to specify a location to store OpenLP data files.
T
In regards to 320, I added a third option down in 370-371 to get it to jump to
the last slide of the previous set item if the up arrow was pressed, but still
leaving the left/right arrow functionality intact.
It also looks like I forgot to remove the commented out line 369!
--
https://code.laun
Yes, the slide list on the android app still showed the same slides, while
OpenLP had jumped to the next service item.
I'll test again with 0.3 when it is released.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Approve
This looks OK to me.
--
https://code.launchpad.net/~m2j/openlp/bug-687638/+merge/89098
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchp
Review: Needs Fixing
Please use the "Display Position" setting on the "General" settings page as an
example of how to do the enabling/disabling of options. That is the industry
standard way of doing it.
--
https://code.launchpad.net/~mahfiaz/openlp/bug-904438/+merge/89122
Your team OpenLP Core
The proposal to merge lp:~smpettit/openlp/pyinstaller into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~smpettit/openlp/pyinstaller/+merge/88778
--
https://code.launchpad.net/~smpettit/openlp/pyinstaller/+merge/88778
Your team Ope
Review: Needs Fixing
261 need a u before the string
320 test must be incorrect as stack has "provious" and "next only added.
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
Your team OpenLP Core is subscribed to branch lp:openlp.
_
0.3 version of Android will be release 23/1 - I have tested head and your code
against the 0l.3 version and get the same behaviours if set to "next".
What do you mean by slide list does not get updated? On the android app?
--
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
I just tested the changes with the android app and discovered a problem with
the "Next" slide advance setting. When you are in the 'slide' view of the
android app clicking the previous/next buttons work as expected, but when using
the "Next" slide advance setting, the slide list doesn't update w
Jonathan Stafford has proposed merging lp:~staffj01/openlp/slideadvance into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~staffj01/openlp/slideadvance/+merge/89578
Changing the "Wrap Slide" option into a th
11 matches
Mail list logo
