phill has proposed merging lp:~phill-ridout/openlp/bug952533 into lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Raoul Snyman (raoul-snyman)
Meinert Jordan (m2j)
Related bugs:
Bug #952533 in OpenLP: "Invalid file name characters in song name causes
OpenLyrics to crash "
https:
The proposal to merge lp:~raoul-snyman/openlp/bug-812628 into lp:openlp has
been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-812628/+merge/98931
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-812628/+merge/9893
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-812628/+merge/98931
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsu
The r'' just prevents python string processing from handling \'s. It doesn't
affect the regex. You still need to escape the special regex characters.
However I think your original string might have worked, since python appears to
leave in \'s that don't precede a special python shortcut, but's
On 22 March 2012 21:22, Raoul Snyman
wrote:
> Review: Needs Fixing
>
> Uh, you just needed to change the u to an r.
But if I'm using r'' i dont need to escape the other chars do I?
http://docs.python.org/library/re.html#raw-string-notation
Phill
--
phill.rid...@googlemail.com - Google Talk
ph
Review: Approve
--
https://code.launchpad.net/~raoul-snyman/openlp/bug-812628/+merge/98931
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsu
The proposal to merge lp:~raoul-snyman/openlp/bug-812628 into lp:openlp has
been updated.
Commit Message changed to:
Fixed bug #812628 by manually checking to see if the author name text was in
the list of authors.
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-8126
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-812628 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #812628 in OpenLP: "Mac OS X: unexpected behaviour in song editor: adding
existing author to song"
https://bugs.launchpad.net/openlp/+bug/8126
** Changed in: openlp
Milestone: None => 1.9.9
** Changed in: openlp
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/955992
Title:
Media Player overri
** Changed in: openlp
Status: Confirmed => Fix Committed
** Changed in: openlp
Assignee: (unassigned) => Raoul Snyman (raoul-snyman)
** Changed in: openlp
Milestone: None => 1.9.9
** Branch linked: lp:~raoul-snyman/openlp/bug-812628
--
You received this bug notification because
** Changed in: openlp
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/891775
Title:
Bottom aligned display text is cut short below base line
Status in Ope
Review: Needs Fixing
Uh, you just needed to change the u to an r.
--
https://code.launchpad.net/~phill-ridout/openlp/bug952533/+merge/98928
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Po
In other words, it should look like this:
INVALID_FILE_CHARS = re.compile(r'[\\\/:\*\?"<>\|\+\[\]%]', re.UNICODE)
--
https://code.launchpad.net/~phill-ridout/openlp/bug952533/+merge/98928
Your team OpenLP Core is subscribed to branch lp:openlp.
___
The proposal to merge lp:~raoul-snyman/openlp/bug-812628 into lp:openlp has
been updated.
Commit Message changed to:
Fixed bug #812628 by manually checking to see if the author name text was in
the list of authors.
For more details, see:
https://code.launchpad.net/~raoul-snyman/openlp/bug-8126
phill has proposed merging lp:~phill-ridout/openlp/bug952533 into lp:openlp.
Requested reviews:
Meinert Jordan (m2j)
Jonathan Corwin (j-corwin)
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #952533 in OpenLP: "Invalid file name characters in song name causes
OpenLyrics to crash "
https:
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-812628 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #812628 in OpenLP: "Mac OS X: unexpected behaviour in song editor: adding
existing author to song"
https://bugs.launchpad.net/openlp/+bug/8126
** Branch linked: lp:openlp
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/955992
Title:
Media Player override doesnt work
Status in OpenLP - Worship Presentation Software:
Fix Released
Bug descr
** Branch linked: lp:openlp
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/891775
Title:
Bottom aligned display text is cut short below base line
Status in OpenLP - Worship Presentation Software:
The proposal to merge lp:~j-corwin/openlp/bug-891775 into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~j-corwin/openlp/bug-891775/+merge/98752
--
https://code.launchpad.net/~j-corwin/openlp/bug-891775/+merge/98752
Your team Op
The proposal to merge lp:~crichter/openlp/bug-955992 into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98714
--
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98714
Your team Op
Review: Approve
--
https://code.launchpad.net/~j-corwin/openlp/bug-891775/+merge/98752
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Review: Needs Fixing
9 +INVALID_FILE_CHARS = re.compile(u'[\\\/:\*\?"<>\|\+\[\]%]', re.UNICODE)
You need to use r'...' not u'...' if you want to actually use proper regular
expressions. "r" means a raw string, so that backslashes are not interpreted as
escape characters.
--
https://code.
Review: Approve
--
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98714
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
phill has proposed merging lp:~phill-ridout/openlp/bug952533 into lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Meinert Jordan (m2j)
Related bugs:
Bug #952533 in OpenLP: "Invalid file name characters in song name causes
OpenLyrics to crash "
https://bugs.launchpad.net/openlp/+b
The plus is still missing.
--
https://code.launchpad.net/~phill-ridout/openlp/bug952533/+merge/98885
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/814838
Title:
cleanup Mac OS X build script
Status in OpenLP - Worship Presentation Software:
In P
** Changed in: openlp
Status: Confirmed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/902541
Title:
OpenLP on OS X shows revision number instead of version number
Status in O
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/908481
Title:
video playback not working on OSX
Status in OpenLP - Worship Presentation Software:
phill has proposed merging lp:~phill-ridout/openlp/bug952533 into lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Meinert Jordan (m2j)
Related bugs:
Bug #952533 in OpenLP: "Invalid file name characters in song name causes
OpenLyrics to crash "
https://bugs.launchpad.net/openlp/+b
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/860684
Title:
Document importing EasyWorship songs into OpenLP
Status in OpenLP - Wors
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/802166
Title:
Allow different scripture notations
Status in OpenLP - Worship Presentat
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/832345
Title:
Make it more obvious what the importer should be used to import
exporte
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/910350
Title:
documentation for moving and locking window panes needs done
Status in O
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/860682
Title:
Document dual monitor setup for ATI cards on linux using the ATI
Contro
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/860681
Title:
Document dual monitor setup for OS X
Status in OpenLP - Worship Presenta
** Changed in: openlp/documentation
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/885561
Title:
Tutorial section in manual?
Status in OpenLP - Worship Presentation Soft
This has been sorted out. However still not commited. The 1.9.9 build
will contain correct version and revision number.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/902541
Title:
OpenLP on OS X sho
It hasn't beep pushed yet and won't be for 1.9.9
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/814838
Title:
cleanup Mac OS X build script
Status in OpenLP - Worship Presentation Software:
In Pro
Solution is not found yet. It is unlikely to be fixed for 1.9.9. For the
1.9.9 mac build I'll not include the vlc backend.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/908481
Title:
video playback
Has the code been pushed yet?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/814838
Title:
cleanup Mac OS X build script
Status in OpenLP - Worship Presentation Software:
In Progress
Bug descript
Has this been sorted?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/902541
Title:
OpenLP on OS X shows revision number instead of version number
Status in OpenLP - Worship Presentation Software:
Was a solution found for this, is it likely to be fixed for 1.9.9?
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/908481
Title:
video playback not working on OSX
Status in OpenLP - Worship Presentat
** Changed in: openlp
Status: Fix Committed => Fix Released
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/957129
Title:
Service item slide limits
Status in OpenLP - Worship Presentation Soft
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/914637
Title:
Translucent display has broken phonon video
Status in OpenLP - Worship Presentation So
** Changed in: openlp
Milestone: None => 1.9.7
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/836611
Title:
First time wizard hangs if no connection available
Status in OpenLP - Worship Presenta
** Changed in: openlp
Milestone: None => 1.9.7
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/838831
Title:
Import/Export Settings not working correctly for "shortcuts"
Status in OpenLP - Worshi
** Changed in: openlp
Milestone: None => 1.9.8
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/900481
Title:
Trackback on startup on Mac OS
Status in OpenLP - Worship Presentation Software:
Fix
** Changed in: openlp/documentation
Milestone: None => 1.9.8
** Changed in: openlp
Milestone: None => 1.9.8
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/885057
Title:
Update OpenLP system
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/687638
Title:
wrong alphabetical order in song list in Slovak language
Status in OpenLP - Worship Pr
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/743273
Title:
User interface on OS X is not like a standard Mac application
Status in OpenLP - Worsh
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/876211
Title:
OpenLyrics export non-compliant for split verses
Status in OpenLP - Worship Presentati
** Changed in: openlp
Milestone: 1.9.9 => None
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/902964
Title:
Libreoffice deprecated commandline args
Status in OpenLP - Worship Presentation Softwa
** Changed in: openlp
Milestone: None => 1.9.9
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/883056
Title:
Monitor selection drop down list should be disabled when "Override
display postition"
** Changed in: openlp
Milestone: None => 1.9.9
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/807119
Title:
API Documentation cannot be created anymore
Status in OpenLP - Worship Presentation So
> Can I do something like from openlp.core.utils import CONTROL_CHARS?
Yes.
> I just thought the '| +$' was a bit more elegant than the other solution.
> And anyways, I wanted to use my new found regular expression "skills" ;-)
Either or, though I think using the Python method will be slightly f
On Mar 22, 2012 8:50 AM, "Meinert Jordan" wrote:
> Your list of reserved filename characters is incomplete.
> For example the squared brackets are forbidden on FAT32 (
http://en.wikipedia.org/wiki/Filename).
> The old list contains all reserved characters except of control
characters.
Thanks. I'v
You've created the constant CONTROL_CHARS but you've chosen not to use it on
line 36.
Perhaps you could use the constant and then just rstrip() to remove the rest
instead of the '| +$'?
If you don't want to use it on line 36, then why not merge the CONTROL_CHARS
and INVALID_FILE_CHARS into one
Review: Needs Fixing
Also there is an extra space before 'title' on line 36
--
https://code.launchpad.net/~phill-ridout/openlp/bug952533/+merge/98788
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~open
Review: Needs Fixing
Your list of reserved filename characters is incomplete.
For example the squared brackets are forbidden on FAT32
(http://en.wikipedia.org/wiki/Filename).
The old list contains all reserved characters except of control characters.
--
https://code.launchpad.net/~phill-ridout/o
1. these two issues seems to have the same problem
2. yes I assume these problems shouldnt occour anymore!
--
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98714
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list:
Would this fix:
http://support.openlp.org/issues/363
http://support.openlp.org/issues/406
If not, I'll report them as a bug in LaunchPad
--
https://code.launchpad.net/~crichter/openlp/bug-955992/+merge/98714
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Some possibly related bugs:
http://support.openlp.org/issues/387
http://support.openlp.org/issues/467
http://support.openlp.org/issues/485
http://support.openlp.org/issues/489
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bu
** Branch linked: lp:~phill-ridout/openlp/bug952533
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/952533
Title:
Invalid file name characters in song name causes OpenLyrics to crash
Status in OpenLP
phill has proposed merging lp:~phill-ridout/openlp/bug952533 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #952533 in OpenLP: "Invalid file name characters in song name causes
OpenLyrics to crash "
https://bugs.launchpad.net/openlp/+bug/952533
For more deta
** Changed in: openlp
Status: In Progress => Fix Committed
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/955992
Title:
Media Player override doesnt work
Status in OpenLP - Worship Presentati
65 matches
Mail list logo
