Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/ssl into lp:openlp

2012-05-18 Thread Tim Bentley
Review: Needs Fixing 264 commented out code. Tried to run ssl with not certificate and got this. Traceback (most recent call last): File "/home/timali/dev/projects/openlp/ssl/openlp/plugins/remotes/lib/httpserver.py", line 165, in incomingConnection open(os.path.join(cert_path, u'openlp.

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/data-path into lp:openlp

2012-05-18 Thread Raoul Snyman
225 + new_data_path = os.path.join(new_path, 'openlp_data') Please set the user's diretory to contain the OpenLP data itself, not another directory. Users making using of this feature will likely know what they're doing. I'm not sure that we should have all this logic inside the Advanced ta

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/ssl into lp:openlp

2012-05-18 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/ssl into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/ssl/+merge/106461 Implement an HTTPS server for the web remote and the Android remote. -- https://c

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/ssl into lp:openlp

2012-05-18 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/ssl into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/ssl/+merge/106433 Implement an HTTPS server for the web remote and the Android remote. -- https://c

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/ssl into lp:openlp

2012-05-18 Thread Raoul Snyman
The proposal to merge lp:~raoul-snyman/openlp/ssl into lp:openlp has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/ssl/+merge/106433 -- https://code.launchpad.net/~raoul-snyman/openlp/ssl/+merge/106433 Your team

[Openlp-core] [Bug 781839] Re: make openlp portable

2012-05-18 Thread Stevan Pettit
While some aspects of OpenLP may attempt to access the registry, the portable app writes nothing to it. The portable app launcher (which executes OpenLP.exe) has many options (http://portableapps.com/manuals/PortableApps.comLauncher/ref/launcher.ini/index.html #ref-launcher-ini) , one of which is

Re: [Openlp-core] [Merge] lp:~edwinlunando/openlp/bug-902492 into lp:openlp

2012-05-18 Thread Tim Bentley
Review: Needs Fixing Maths is wrong. Look at renderer._calculate_default. You do not need to worry about the -20 as this is done by the renderer. You would have -40 which is wrong. Also the footer default is 90% of the height. -- https://code.launchpad.net/~edwinlunando/openlp/bug-902492/+mer

[Openlp-core] [Bug 779201] Re: QString and QVariant auto-conversion

2012-05-18 Thread matysek
This is a type of change which has to be merged at once. Also the Windows and Mac build scripts has to be updated. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/779201 Title: QString and QVariant a

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-18 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is subsc

[Openlp-core] [Bug 781839] Re: make openlp portable

2012-05-18 Thread Jonathan Corwin
I don't think we have much choice. Assuming we're talking Windows: LibreOffice is controlled via COM and so'll it'll use whatever is in the registry. vlc.py (which we use as is, unmodified) detects where VLC is. It appears to use ctypes.find_library first, so unless we can somehow override where

[Openlp-core] [Merge] lp:~edwinlunando/openlp/bug-902492 into lp:openlp

2012-05-18 Thread Edwin Lunando
Edwin Lunando has proposed merging lp:~edwinlunando/openlp/bug-902492 into lp:openlp. Requested reviews: Tim Bentley (trb143) Jonathan Corwin (j-corwin) Related bugs: Bug #902492 in OpenLP: "Theme Wizard does not use the live screen's size as default when overwriting "Output Area Locations

[Openlp-core] [Bug 781839] Re: make openlp portable

2012-05-18 Thread matysek
In response to Libre/Open office and VLC configuration in OpenLP.ini: I think we cannot rely on openlp portable running always with the whole portableapp stack. I think the Libre/Open office and VLC detection should be: 1. if configured in OpenLP.ini - it means running with portableapp stack

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-18 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-18 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe