[Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-06-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/bug-1011286 into lp:openlp. Requested reviews: Tim Bentley (trb143) Related bugs: Bug #1011286 in OpenLP: "Song Editor -> Edit All Crashes with out valid verse splitter" https://bugs.launchpad.net/openlp/+bug/1011286 For more details, see:

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/portable into lp:openlp

2012-06-10 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/portable/+merge/109536 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscri

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-06-10 Thread Tim Bentley
Review: Needs Fixing Do we need the log.debug? -- https://code.launchpad.net/~phill-ridout/openlp/bug-1011286/+merge/109540 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : open

[Openlp-core] [Merge] lp:~dave-warnock/openlp/dbclean into lp:openlp

2012-06-10 Thread Dave Warnock
Dave Warnock has proposed merging lp:~dave-warnock/openlp/dbclean into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~dave-warnock/openlp/dbclean/+merge/109546 This update is a tidy up of the code that fixed bug #927473 Changes are

[Openlp-core] [Bug 1011286] Re: Song Editor -> Edit All Crashes with out valid verse splitter

2012-06-10 Thread phill
** Changed in: openlp Status: New => Fix Committed ** Changed in: openlp Assignee: (unassigned) => phill (phill-ridout) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1011286 Title: Song

[Openlp-core] [Bug 1011286] Re: Song Editor -> Edit All Crashes with out valid verse splitter

2012-06-10 Thread Launchpad Bug Tracker
** Branch linked: lp:~phill-ridout/openlp/bug-1011286 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1011286 Title: Song Editor -> Edit All Crashes with out valid verse splitter Status in OpenLP - W

[Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-06-10 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/bug-1011286 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1011286 in OpenLP: "Song Editor -> Edit All Crashes with out valid verse splitter" https://bugs.launchpad.net/openlp/+bug/1011286 For more details,

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/portable into lp:openlp

2012-06-10 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/portable/+merge/109536 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscri

[Openlp-core] [Bug 1011286] [NEW] Song Editor -> Edit All Crashes with out valid verse splitter

2012-06-10 Thread phill
Public bug reported: Create a new song click "Edit All" delete all text including "---[Verse:1]---" Click Save Error Occured, with description: Traceback (most recent call last): File "D:\OpenLP_Code\trunk\build\pyi.win32\OpenLP\outPYZ1.pyz\openlp.plugins.songs.forms.editverseform", line 1

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/portable into lp:openlp

2012-06-10 Thread Raoul Snyman
Review: Needs Fixing Just some minor changes... 54 + log.info(u'INI file: %s' % portable_settings_file) 60 + log.info(u'Data path: %s' % data_path) When using the log.() functions, you don't need to use the % for string interpolation. Just use commas: log.info(u'INI file: %s', p

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/portable into lp:openlp

2012-06-10 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/portable/+merge/109525 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscri

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/portable into lp:openlp

2012-06-10 Thread Stevan Pettit
> A couple of code cosmetics: > > 62, 63: Add space after comma > 256: Indent should be 4 spaces Changes made -- https://code.launchpad.net/~smpettit/openlp/portable/+merge/109497 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing li

[Openlp-core] [Bug 870879] Re: VLC causes process to continuing running on exit (Windows)

2012-06-10 Thread Jonathan Corwin
Hmm, OK I might have to change my mind. The problem is still there. Perhaps I was running an exe that wasn't loading VLC and I got excited when it closed down correctly. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.laun

[Openlp-core] [Bug 870879] Re: VLC causes process to continuing running on exit (Windows)

2012-06-10 Thread Samuel Findlay
I've upgrade VLC to 2.0.1, but I'm still seeing this issue. Jonathan, how did you discover/confirm that your issue lay with VLC? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/870879 Title: VLC cause

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/portable into lp:openlp

2012-06-10 Thread Jonathan Corwin
Review: Needs Fixing A couple of code cosmetics: 62, 63: Add space after comma 256: Indent should be 4 spaces -- https://code.launchpad.net/~smpettit/openlp/portable/+merge/109497 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

[Openlp-core] [Bug 1011107] [NEW] Document importing ZionWorx songs

2012-06-10 Thread Samuel Findlay
Public bug reported: The ZionWorx (CSV) importer in the song import wizard instructs the user: "First convert your ZionWorx database to a CSV text file, as explained in the User Manual.", where is a link to this URL [1]. General info about the ZionWorx importer (including which fields it import