[Openlp-core] [Bug 1027504] Re: Edit dialogue for custom slides does not have a title

2012-07-21 Thread Tim Bentley
** Branch linked: lp:~trb143/openlp/delete-text -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1027504 Title: Edit dialogue for custom slides does not have a title Status in OpenLP - Worship Present

[Openlp-core] [Merge] lp:~trb143/openlp/delete-text into lp:openlp

2012-07-21 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/delete-text into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1027504 in OpenLP: "Edit dialogue for custom slides does not have a title" https://bugs.launchpad.net/openlp/+bug/1027504 For more details, see: ht

[Openlp-core] [Bug 1027504] Re: Edit dialogue for custom slides does not have a title

2012-07-21 Thread Tim Bentley
** Changed in: openlp Status: New => Fix Committed ** Changed in: openlp Importance: Undecided => Low ** Changed in: openlp Assignee: (unassigned) => Tim Bentley (trb143) ** Changed in: openlp Milestone: None => 1.9.11 -- You received this bug notification because you are a

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug1020915 into lp:openlp

2012-07-21 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/bug1020915/+merge/116131 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Uns

[Openlp-core] [Bug 1027504] [NEW] Edit dialogue for custom slides does not have a title

2012-07-21 Thread phill
Public bug reported: Edit dialogue for custom slides does not have a title, instead pythonw is used Windows 7 ** Affects: openlp Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https:/

[Openlp-core] [Merge] lp:~phill-ridout/openlp/bug1020915 into lp:openlp

2012-07-21 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/bug1020915 into lp:openlp. Requested reviews: Tim Bentley (trb143) Samuel Findlay (sfindlay) Related bugs: Bug #1020915 in OpenLP: "OpenSong Bible import has uncaught exception on non-xml file" https://bugs.launchpad.net/openlp/+bug/10209

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug1020915 into lp:openlp

2012-07-21 Thread Samuel Findlay
Review: Needs Fixing I think "bible" in the string should be capitalised (see http://manual.openlp.org/bibles.html#bible-import-wizard). Otherwise, looks good. -- https://code.launchpad.net/~phill-ridout/openlp/bug1020915/+merge/116058 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-07-21 Thread phill
Hrm, It removes the last verse if there is only one char after the new line. It can be any char it appears! Although, technically this has nothing to do with my code, my code is doing what it should do. This is caused by the code that creates the list items. I had a look at it, but its too far ove

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-07-21 Thread Jonathan Corwin
Tim, I just tried your second example, and verse 2 doesn't disappear for me. I don't see how Phill's changes could affect this behaviour. -- https://code.launchpad.net/~phill-ridout/openlp/bug-1011286/+merge/114992 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-07-21 Thread Tim Bentley
Review: Needs Fixing Sorry but the saving has become a mess. Add a song ---[Verse:1]--- ---[Verse:2]--- does not allow the song to be saved. ---[Verse:1]--- ---[Verse:2]--- with a space in each verse allows the song to be saved but verse 2 disappears. The loss of verse 2 even with a space in