Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1041366 into lp:openlp

2012-08-24 Thread Jonathan Corwin
Sorry to say that bug 1016843 reoccurs with this branch :( -- https://code.launchpad.net/~raoul-snyman/openlp/bug-1041366/+merge/121285 Your team OpenLP Core is requested to review the proposed merge of lp:~raoul-snyman/openlp/bug-1041366 into lp:openlp. _

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1041366 into lp:openlp

2012-08-24 Thread Jonathan Corwin
Does the self.web = None prevent a reoccurrence of this bug? https://code.launchpad.net/~j-corwin/openlp/bug-1016843/+merge/112915 https://bugs.launchpad.net/openlp/+bug/1016843 -- https://code.launchpad.net/~raoul-snyman/openlp/bug-1041366/+merge/121285 Your team OpenLP Core is requested to revi

[Openlp-core] [Bug 1041366] Re: Specified size display area not working

2012-08-24 Thread Raoul Snyman
** Changed in: openlp Status: In Progress => Fix Committed -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1041366 Title: Specified size display area not working Status in OpenLP - Worship Pre

[Openlp-core] [Bug 1041366] Re: Specified size display area not working

2012-08-24 Thread Launchpad Bug Tracker
** Branch linked: lp:~raoul-snyman/openlp/bug-1041366 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1041366 Title: Specified size display area not working Status in OpenLP - Worship Presentation So

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/bug-1041366 into lp:openlp

2012-08-24 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/bug-1041366 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1041366 in OpenLP: "Specified size display area not working" https://bugs.launchpad.net/openlp/+bug/1041366 For more details, see: https://c

[Openlp-core] [Bug 1041366] Re: Specified size display area not working

2012-08-24 Thread Raoul Snyman
** Description changed: Output area definitions in themes don't seem to be working in 1.9.11. + + See the following pages for more information: + http://openlp.org/en/forums/general-support/troubleshooting/display-area-not-working + http://support.openlp.org/issues/ ** Changed in: openlp

[Openlp-core] [Bug 1041366] [NEW] Specified size display area not working

2012-08-24 Thread Raoul Snyman
Public bug reported: Output area definitions in themes don't seem to be working in 1.9.11. ** Affects: openlp Importance: Undecided Assignee: Raoul Snyman (raoul-snyman) Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscr

[Openlp-core] [Bug 1037076] Re: Short cut keys do not work for background audio

2012-08-24 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1037076 Title: Short cut keys do not work for background audio Status in OpenLP - Worship Presentation Software: Fix Comm

[Openlp-core] [Merge] lp:~trb143/openlp/vlc-fixes into lp:openlp

2012-08-24 Thread Raoul Snyman
The proposal to merge lp:~trb143/openlp/vlc-fixes into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~trb143/openlp/vlc-fixes/+merge/121277 -- https://code.launchpad.net/~trb143/openlp/vlc-fixes/+merge/121277 Your team OpenLP

Re: [Openlp-core] [Merge] lp:~trb143/openlp/vlc-fixes into lp:openlp

2012-08-24 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~trb143/openlp/vlc-fixes/+merge/121277 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1045 into lp:openlp

2012-08-24 Thread noreply
The proposal to merge lp:~phill-ridout/openlp/issue1045 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~phill-ridout/openlp/issue1045/+merge/120257 -- https://code.launchpad.net/~phill-ridout/openlp/issue1045/+merge/120257 Your

[Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1045 into lp:openlp

2012-08-24 Thread Raoul Snyman
The proposal to merge lp:~phill-ridout/openlp/issue1045 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~phill-ridout/openlp/issue1045/+merge/120257 -- https://code.launchpad.net/~phill-ridout/openlp/issue1045/+merge/120257

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1045 into lp:openlp

2012-08-24 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/issue1045/+merge/120257 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsu

[Openlp-core] [Merge] lp:~trb143/openlp/vlc-fixes into lp:openlp

2012-08-24 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/vlc-fixes into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/vlc-fixes/+merge/121277 A saved media item in a service is not case insensitive checked for a valid suffix

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1000 into lp:openlp

2012-08-24 Thread Tim Bentley
getOpenFileName is used 11 times so that is 11 more places to change. Is it really worth it now? -- https://code.launchpad.net/~phill-ridout/openlp/issue1000/+merge/121249 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https:

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1000 into lp:openlp

2012-08-24 Thread phill
> Why do we need normpath. No other path inputs use this. For some reason QFileDialog.getOpenFileName returns the path with forward slashes instead on back slashes on windows. Where as QFileDialog.getExistingDirectory returns it correctly. I have just noticed we have the same issue on the advanc

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/bug-1011286 into lp:openlp

2012-08-24 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/bug-1011286/+merge/119419 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Un

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1000 into lp:openlp

2012-08-24 Thread Tim Bentley
Review: Needs Fixing Why do we need normpath. No other path inputs use this. Validating the save on exit is not a good user experience. It should be done on moving to the next tab after selecting Image. You have to return 5 tabs and have generated a preview and requested save before this is

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1000 into lp:openlp

2012-08-24 Thread phill
Review: Approve -- https://code.launchpad.net/~phill-ridout/openlp/issue1000/+merge/121249 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/issue1000 into lp:openlp. ___ Mailing list: https://launchpad.net/~o

[Openlp-core] [Merge] lp:~phill-ridout/openlp/issue1000 into lp:openlp

2012-08-24 Thread phill
phill has proposed merging lp:~phill-ridout/openlp/issue1000 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) phill (phill-ridout) Related bugs: Bug #1039221 in OpenLP: "No validation on background image field in theme wizard" https://bugs.launchpad.net/openlp/+bug/1039221 Fo