Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-18 Thread Meinert Jordan
> Sorry but limited time this week big production at church over the weekend > id taking up my time. For the fact, that you are answering other merge requests, and just have to state, which string you've tested, it's hard for me to understand. I'm pretty sure, that there is no such problem. --

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-presentation into lp:openlp

2012-12-18 Thread Phill
But the proposed merge would fix the bug in 2.0.1 wouldn't it? (I can't test atm.) On 19 Dec 2012 05:56, "Tim Bentley" wrote: > Review: Needs Fixing > > Have a look i here as the code is being re-written > https://code.launchpad.net/~googol/openlp/bug-779201/+merge/138581 > > -- > > https://code.

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-18 Thread Meinert Jordan
> Tim: It would be great to get any response. > I still don't know, which HTML setting you can not realize. Oh, just realized: Which one you CAN realize. Still: I need a example. -- https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140195 Your team OpenLP Core is subscribed to branch l

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-18 Thread Tim Bentley
Sorry but limited time this week big production at church over the weekend id taking up my time. Tim Bentley (Mobile) On Dec 19, 2012 7:44 AM, "Meinert Jordan" wrote: > Tim: It would be great to get any response. > I still don't know, which HTML setting you can not realize. > -- > https://code.l

Re: [Openlp-core] [Merge] lp:~m2j/openlp/formattingtags into lp:openlp

2012-12-18 Thread Meinert Jordan
Tim: It would be great to get any response. I still don't know, which HTML setting you can not realize. -- https://code.launchpad.net/~m2j/openlp/formattingtags/+merge/140195 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: htt

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-presentation into lp:openlp

2012-12-18 Thread Tim Bentley
Review: Needs Fixing Have a look i here as the code is being re-written https://code.launchpad.net/~googol/openlp/bug-779201/+merge/138581 -- https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540 Your team OpenLP Core is subscribed to branch lp:openlp.

Re: [Openlp-core] [Merge] lp:~sam92/openlp/fix-import-presentation into lp:openlp

2012-12-18 Thread Meinert Jordan
Review: Needs Fixing The error happens in openlp/core/lib/mediamanageritem.py:341 At this point, a list of QString is catched and forwarded without conversion to unicode. Please make the fix at this position. -- https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540 Your

[Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-18 Thread Dmitriy Marmyshev
The proposal to merge lp:~marmyshev/openlp/autoplay into lp:openlp has been updated. Description changed to: Added new future: store autoplay option in service, start live the item with such options if setted. fixed events playSlideOnce and PlaySlideLoop, fixed selection of previewing item in

[Openlp-core] [Merge] lp:~sam92/openlp/fix-import-presentation into lp:openlp

2012-12-18 Thread Samuel Mehrbrodt
Samuel Mehrbrodt has proposed merging lp:~sam92/openlp/fix-import-presentation into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~sam92/openlp/fix-import-presentation/+merge/140540 The error was in http://bazaar.launchpad.net/~open

[Openlp-core] [Bug 836574] Re: PowerPoint Presentations with Office for Mac

2012-12-18 Thread Dmitriy Marmyshev
** Changed in: openlp Status: Confirmed => In Progress -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/836574 Title: PowerPoint Presentations with Office for Mac Status in OpenLP - Worship Pre

[Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-18 Thread Dmitriy Marmyshev
Dmitriy Marmyshev has proposed merging lp:~marmyshev/openlp/autoplay into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/140536 Andded new future: store autoplay option in service, start live the item with

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-18 Thread Dmitriy Marmyshev
Line 69 doesnt fit in 120. Line 80 is just 119 Lines 82-85 - commented because of line above - this is TODO. Everything else I have fixed. -- https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/140289 Your team OpenLP Core is subscribed to branch lp:openlp. __

[Openlp-core] [Bug 1091804] Re: Unable to update Service Item notes after exporting to another PC

2012-12-18 Thread DJ Belieny
I tried both and realized that only the root could be edited on the first computer, but on the second computer none of them, nor the root or the leaf could be edited. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launch

[Openlp-core] [Bug 1091804] Re: Unable to update Service Item notes after exporting to another PC

2012-12-18 Thread DJ Belieny
BTW would't it be more interesting for the user to have the ability to add/edit notes for each item/leaf individually on top of the ability to add/edit notes to the root ? -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.la

[Openlp-core] [Bug 1091804] Re: Unable to update Service Item notes after exporting to another PC

2012-12-18 Thread Tim Bentley
Did you try to edit the leaf or the root of the service item in the service manager. Edit Notes only works on the root (top item) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1091804 Title: Unable

[Openlp-core] [Bug 1091804] [NEW] Unable to update Service Item notes after exporting to another PC

2012-12-18 Thread DJ Belieny
Public bug reported: I have created a service containing several items including images and Custom slides where the custom slides have notes attached to them. After I copied the file to another computer I was unable to edit the notes on any items of the imported service. The "Edit Notes" context

Re: [Openlp-core] [Merge] lp:~patrick-zakweb/openlp/bug-936281-newformat into lp:openlp

2012-12-18 Thread Raoul Snyman
I would rather call the checkbox "alternateRows" as it matches the caption and the functionality behind the checkbox. Additionally, I would change the message in the dialog to say, "This change will only take effect once OpenLP has been restarted." -- https://code.launchpad.net/~patrick-zakweb/

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-18 Thread Tim Bentley
Review: Needs Fixing 29-31 should be 10 lines higher with the rest of the header statements 49-50 etc should be on the same line Line 69 one more indent. Line 80 far too long! 82-85 why is this commented out 134-135 indents look wrong 138-145 styling wrong (indents and spaces) 174, 179 inden