Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/custom into lp:openlp

2012-12-28 Thread Jonathan Corwin
Tim, I've removed line 240 now, it didn't do what I thought and if there was a good reason for it I can't figure out what it was now! -- https://code.launchpad.net/~j-corwin/openlp/custom/+merge/141442 Your team OpenLP Core is subscribed to branch lp:openlp.

[Openlp-core] [Merge] lp:~j-corwin/openlp/custom into lp:openlp

2012-12-28 Thread Jonathan Corwin
Jonathan Corwin has proposed merging lp:~j-corwin/openlp/custom into lp:openlp. Requested reviews: Andreas Preikschat (googol) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~j-corwin/openlp/custom/+merge/141442 Edit/save custom slide items in service files. - When r

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/custom into lp:openlp

2012-12-28 Thread Jonathan Corwin
... method was the way I saw that songs rebuilt the context menu. (Sorry managed to press add comment prematurely!) -- https://code.launchpad.net/~j-corwin/openlp/custom/+merge/141191 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/custom into lp:openlp

2012-12-28 Thread Jonathan Corwin
Andreas: To answer your question, although I based it on code in Songs, there were enough subtle differences in the end to make it not worth doing anything generic. Tim: The line 240 confusion (I was/am also confused when trying to decipher things!) The 'service_item_update' signal updated the

[Openlp-core] [Bug 1084203] Re: Youtube link on Website 2.0 is broken

2012-12-28 Thread Andreas Preikschat
Already fixed? Works fine here. ** Changed in: openlp/website Status: New => Incomplete ** Changed in: openlp/website Importance: Undecided => Medium -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.ne

[Openlp-core] [Bug 847663] Re: wiki page - how to write unit tests

2012-12-28 Thread Andreas Preikschat
As automated test are part of the plans for 2.x this is no longer wishlist. ** Changed in: openlp Importance: Wishlist => High ** Changed in: openlp Milestone: None => 2.1.1 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. http

[Openlp-core] [Bug 1086987] Re: Log system does not log all exceptions

2012-12-28 Thread Andreas Preikschat
** Description changed: Hello, - bzr checkout lp:~googol/openlp/bug-779201 -r 2006 + bzr checkout lp:~googol/openlp/bug-779201-2 -r 2006 - You cannot start OpenLP. BUT: there is not traceback in the console, + You cannot start OpenLP. BUT: there is no traceback in the console, there is n

[Openlp-core] [Bug 1094346] [NEW] SIP version 2 rewrite broke automated test

2012-12-28 Thread Andreas Preikschat
Public bug reported: >From r2131 the applocation test is broken: http://ci.openlp.org/job /OpenLP-2a-Run_Functional_Tests/lastFailedBuild/ ** Affects: openlp Importance: Undecided Status: New ** Tags: regression -- You received this bug notification because you are a member of O

[Openlp-core] [Bug 1094198] Re: Setting Import fails to find General section

2012-12-28 Thread Jonathan Corwin
** Changed in: openlp Status: New => Confirmed ** Changed in: openlp Importance: Undecided => Critical -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1094198 Title: Setting Import fails to

[Openlp-core] [Bug 1094342] [NEW] Natural sorting broken on windows

2012-12-28 Thread Andreas Preikschat
Public bug reported: Hello, In trunk r2132 natural sorting broke on windows. Regards ** Affects: openlp Importance: High Status: New ** Tags: regression -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.l

[Openlp-core] [Bug 779201] Re: QString and QVariant auto-conversion

2012-12-28 Thread Launchpad Bug Tracker
** Branch linked: lp:openlp -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/779201 Title: QString and QVariant auto-conversion Status in OpenLP - Worship Presentation Software: Fix Released Status

[Openlp-core] [Bug 779201] Re: QString and QVariant auto-conversion

2012-12-28 Thread Andreas Preikschat
The build script has to be changed. NOTE: 2.0 still needs the old build script! ** Changed in: openlp/packaging Importance: Undecided => High ** Changed in: openlp/packaging Status: New => Confirmed ** Changed in: openlp/packaging Milestone: None => 2.1.1 ** Changed in: openlp/pa

[Openlp-core] [Bug 779201] Re: QString and QVariant auto-conversion

2012-12-28 Thread Andreas Preikschat
** Also affects: openlp/packaging Importance: Undecided Status: New -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/779201 Title: QString and QVariant auto-conversion Status in OpenLP - Wor

[Openlp-core] [Bug 1094340] Re: Post SIP merge Presentation Tab fails to work

2012-12-28 Thread Andreas Preikschat
** Changed in: openlp Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1094340 Title: Post SIP merge Presentation Tab fails to work Status in OpenLP - Wors

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/autoplay into lp:openlp

2012-12-28 Thread Tim Bentley
Review: Needs Fixing We have moved trunk to be Unicode and QVarient free. Sorry but you need to update your code and resubmit. -- https://code.launchpad.net/~marmyshev/openlp/autoplay/+merge/141382 Your team OpenLP Core is subscribed to branch lp:openlp. _

[Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread noreply
The proposal to merge lp:~googol/openlp/bug-779201-2 into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 Your team Open

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread Raoul Snyman
Review: Approve Looks OK to me, don't have time to test it though. -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Pos

[Openlp-core] [Bug 1094340] Re: Post SIP merge Presentation Tab fails to work

2012-12-28 Thread Andreas Preikschat
** Changed in: openlp Status: Confirmed => Fix Committed ** Changed in: openlp Assignee: (unassigned) => Andreas Preikschat (googol) -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1094340

[Openlp-core] [Bug 1094340] Re: Post SIP merge Presentation Tab fails to work

2012-12-28 Thread Launchpad Bug Tracker
** Branch linked: lp:~googol/openlp/bug-779201-2 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1094340 Title: Post SIP merge Presentation Tab fails to work Status in OpenLP - Worship Presentation S

[Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/bug-779201-2 into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 Your tea

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubsc

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141437 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubsc

[Openlp-core] [Bug 1094340] [NEW] Post SIP merge Presentation Tab fails to work

2012-12-28 Thread Tim Bentley
Public bug reported: Presentation Tab Save has a call to Settings.value without a default value. This fails post the SIP migration Add NONE as the default value and handle a return of None meaning not found. ** Affects: openlp Importance: Critical Assignee: Andreas Preikschat (googol)

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread Jonathan Corwin
Review: Approve Lets get it in. -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141386 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launch

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/show_thumbs_onoff into lp:openlp

2012-12-28 Thread Arjan Schrijver
You're right at the style. I'll fix that before resubmitting. I've moved the initializing code to configUpdated to make the setting active without restarting the program. The problem is not really the performance, as has already been demonstrated. It's more that the thumbnails are simply unneces

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/show_thumbs_onoff into lp:openlp

2012-12-28 Thread Tim Bentley
Review: Needs Fixing This needs to be compatable with lp:~googol/openlp/bug-779201-2 so have a look there for style etc. Why is all of the initialise section being moved to config update? We need a default icon so the question is what is the performance saving being made? If it is only on the

[Openlp-core] [Merge] lp:~arjan-i/openlp/show_thumbs_onoff into lp:openlp

2012-12-28 Thread Arjan Schrijver
Arjan Schrijver has proposed merging lp:~arjan-i/openlp/show_thumbs_onoff into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~arjan-i/openlp/show_thumbs_onoff/+merge/141433 Added an on/off switch in the settings display for displayin

[Openlp-core] [Bug 1094296] Re: LibreOffice 4.0 support

2012-12-28 Thread Tim Bentley
You need to consider that Fedora will not have access to Libraoffice until F19. -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1094296 Title: LibreOffice 4.0 support Status in OpenLP - Worship Prese

[Openlp-core] [Bug 1094300] [NEW] song import - ability to set songbook

2012-12-28 Thread matysek
Public bug reported: Recently I was importing songs from opensong to openlp. I think it could be handy to be able to set songbook (or maybe other song items) for all imported songs. Let me describe the use case scenario: - As an old opensong user I am used to have songs as files split across mu

[Openlp-core] [Bug 1094296] [NEW] LibreOffice 4.0 support

2012-12-28 Thread matysek
Public bug reported: Since libreoffice 4.0 is in beta stage, I think we should start looking at supporting it in the presentation plugin. According to the release notes https://wiki.documentfoundation.org/ReleaseNotes/4.0 these changes could cause openlp to not work with libreoffice 4: - "The bu

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/custom into lp:openlp

2012-12-28 Thread Andreas Preikschat
> Wait: > I am sure, you are going to fix the setValue/value calls after my branch is > merged ;) And I should read what you've already written (sorry): > IMPORTANT: > This contains changes that will conflict with Andreas' changes, so should not > be merged until that > is and I've then updated

Re: [Openlp-core] [Merge] lp:~j-corwin/openlp/custom into lp:openlp

2012-12-28 Thread Tim Bentley
Review: Needs Fixing line 17 text= should be on new line so statement is not line split. Line 240 confuses me. If the original item is a custom why do we need to replace it? The post to set the correct uuid should be enough. -- https://code.launchpad.net/~j-corwin/openlp/custom/+merge/141191 Yo

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-779201-2 into lp:openlp

2012-12-28 Thread Tim Bentley
Review: Approve Spent a good hour trying to break it. I did find an existing bug in exports. Unable to break. Reviewed code and looks fine. Formatting is a mess but we knew that. -- https://code.launchpad.net/~googol/openlp/bug-779201-2/+merge/141386 Your team OpenLP Core is subscribed to bran

[Openlp-core] [Bug 1094198] [NEW] Setting Import fails to find General section

2012-12-28 Thread Tim Bentley
Public bug reported: Export you settings file and you get a nice text file but [General] is exported as [%General] This blocks the import from working as it does not find a [General] section, This exists in 2.0 for the export ** Affects: openlp Importance: Undecided Status: New