Review: Needs Fixing
unable to export 'advanced/stylesheet fix'
--
https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/144656
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/media/+merge/144783
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
The proposal to merge lp:~elderp/openlp/packaging-version into
lp:openlp/packaging has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~elderp/openlp/packaging-version/+merge/144042
--
https://code.launchpad.net/~elderp/openlp/packaging-version/+me
Review: Needs Fixing
Needs a re-role after my merges
--
https://code.launchpad.net/~googol/openlp/clean-up/+merge/144608
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-
The proposal to merge lp:~trb143/openlp/singleton into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/singleton/+merge/144796
--
https://code.launchpad.net/~trb143/openlp/singleton/+merge/144796
Your team OpenLP Co
Review: Approve
Well, all the tests pass, but this line looks a little weird to me:
self.assertEqual(context.exception[0], u'Service test2 not found in list')
--
https://code.launchpad.net/~trb143/openlp/singleton/+merge/144796
Your team OpenLP Core is subscribed to branch lp:openlp.
__
The proposal to merge lp:~elderp/openlp/packaging2-version into
lp:openlp/packaging-2.0 has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~elderp/openlp/packaging2-version/+merge/144041
--
https://code.launchpad.net/~elderp/openlp/packaging2-vers
The proposal to merge lp:~elderp/openlp/packaging-version into
lp:openlp/packaging has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~elderp/openlp/packaging-version/+merge/144042
--
https://code.launchpad.net/~elderp/openlp/packaging-versi
The proposal to merge lp:~elderp/openlp/packaging2-version into
lp:openlp/packaging-2.0 has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~elderp/openlp/packaging2-version/+merge/144041
--
https://code.launchpad.net/~elderp/openlp/packaging
The proposal to merge lp:~trb143/openlp/media into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/media/+merge/144783
--
https://code.launchpad.net/~trb143/openlp/media/+merge/144783
Your team OpenLP Core is subscri
Tim Bentley has proposed merging lp:~trb143/openlp/media into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #885150 in OpenLP: "Need non self contained service files"
https://bugs.launchpad.net/openlp/+bug/885150
Bug #899714 in OpenLP: "Play/Pause button shoul
Review: Needs Fixing
Lots of commented out code in the tests makes it very difficult to read what is
going on. If you need to comment it out, does it really need to be there?
693 + assert (service_item.get_display_title()) == u'Test Custom', u'The
custom title is correct'
The messages in
Tim Bentley has proposed merging lp:~trb143/openlp/media into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Related bugs:
Bug #885150 in OpenLP: "Need non self contained service files"
https://bugs.launchpad.net/openlp/+bug/885150
Bug #899714 in OpenLP: "Play/Pause button shoul
Review: Needs Fixing
Oh, and you're testing the registry, so please name your TestCase accordingly
(and update your docstrings!)...
2255+class TestServiceItem(TestCase):
--
https://code.launchpad.net/~trb143/openlp/singleton/+merge/144640
Your team OpenLP Core is subscribed to branch lp:ope
Review: Needs Fixing
437 + if key in self.service_list:
438 + log.error(u'Duplicate service exception %s' % key)
439 + raise Exception(u'Duplicate service exception %s' % key)
Rather raise a more specific exception, like KeyError.
2271+ # WHEN: I add a service it should save it
Review: Needs Fixing
http://ci.openlp.org/view/Specific%20Branch/job/OpenLP-Pull_and_Run_Functional_Tests/16/console
==
FAIL: Test StartTimeDialog display initialisation
---
Review: Needs Fixing
Line 10 is now wrong following the conversion to central settings.
--
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/143954
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: h
Review: Needs Fixing
Hi Patrick,
Thanks for your patience and your understanding, and trying to get everyone to
agree with each other :-D
Unfortunately I have one last minor request... You've named the checkbox,
"Enable alternating row colours in lists" but I think it is slightly better to
sa
Review: Needs Fixing
Tests still failing.
FAIL: Test the AppLocation.get_data_path() method when a custom location is set
in the settings
As per the output from the test, see
tests/functional/openlp_core_utils/test_applocation.py, line 51, function
get_data_path_with_custom_location_test():
Review: Needs Fixing
A quick look, but please check your comments they give away your cut and paste !
Is the listwidgetwithDND still used if not get rid of it.
Have a look at my singleton merge request this will change some of your code
around plugin manager.
--
https://code.launchpad.net/~a
Review: Approve
--
https://code.launchpad.net/~googol/openlp/central-settings-place/+merge/144656
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.n
Review: Needs Fixing
--
https://code.launchpad.net/~marmyshev/openlp/presentation/+merge/143389
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Public bug reported:
Hello,
trunk r2158, arch linux
1) Add a song to the service manager
2) Right click -> "Auto play Slides"
You see that we use checkboxes in the menu. Instead we should use radio boxes
for the first two entries (each ones excludes the usage of the other).
The last entry is a
Andreas Preikschat has proposed merging
lp:~googol/openlp/central-settings-place into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #1096559 in OpenLP: "Central place for default settings"
https://bugs.launchpad.net/openlp/+bug/1096559
For more details, see:
htt
24 matches
Mail list logo
