[Openlp-core] [Merge] lp:~googol/openlp/registry into lp:openlp

2013-02-11 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/registry into lp:openlp has been updated. Description changed to: Hello, - fixed alert display regression - fixed image plugin regression - fixed remote plugin regression To be reviewed after Tim's branch: lp:~trb143/openlp/event_receiver_removal For mo

[Openlp-core] [Merge] lp:~googol/openlp/registry into lp:openlp

2013-02-11 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/registry into lp:openlp. Requested reviews: Andreas Preikschat (googol) Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~googol/openlp/registry/+merge/147847 Hello, - fixed alert display (regression) To be re

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/imp into lp:openlp. Requested reviews: Tim Bentley (trb143) Andreas Preikschat (googol) Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147841 Modify the way plugins are i

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Jonathan Corwin
Review: Needs Fixing I decided to join in... Line 45, should be a space before the 'and' :) -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147748 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpa

Re: [Openlp-core] [Merge] lp:~trb143/openlp/settings_migration into lp:openlp

2013-02-11 Thread Jonathan Corwin
Review: Needs Fixing Line 9: qq? Is this a debug line that needs removing? The assert messages... still not getting these right. From what I understand, the messages appear if the test fails, but the message once again is stating that they 'is' something, when they won't be that thing if we see

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-02-11 Thread matysek
Today I tested the r2118 - the temp_dir check and relaunching ppt are fixed. There are some other issues: - when opening a presentation the preview of the 1st slide is not generated in openlp. Last time it was created. - What is the use case scenario when the powerpoint should be started? - Sh

[Openlp-core] [Merge] lp:~phill-ridout/openlp/bug1067251 into lp:openlp

2013-02-11 Thread Phill
Phill has proposed merging lp:~phill-ridout/openlp/bug1067251 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1067251 in OpenLP: "Correct focus of theme manager's dialogs" https://bugs.launchpad.net/openlp/+bug/1067251 For more details, see: https://code.laun

[Openlp-core] [Merge] lp:~trb143/openlp/settings_migration into lp:openlp

2013-02-11 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/settings_migration into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/settings_migration/+merge/147755 Add tests for Settings Fix bugs which made nose fail but OpenL

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147748 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/imp into lp:openlp. Requested reviews: Tim Bentley (trb143) Andreas Preikschat (googol) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147748 Modify the way plugins are imported to use the "imp" modu

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Tim Bentley
Need to take some of your own comments :P -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Raoul Snyman
Yeesh you lot are pedantic :-P -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.n

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Andreas Preikschat
Review: Needs Fixing -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsub

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/item_title into lp:openlp

2013-02-11 Thread Andreas Preikschat
Are going to change your code? The "Need fixing"s do not mean that we do not like your idea, it just needs fixing ;) If you need help feel free to ask. -- https://code.launchpad.net/~marmyshev/openlp/item_title/+merge/142941 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Andreas Preikschat
Line 72 and 74: `` not needed as it is a comment :P -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-c

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Raoul Snyman
Is that all you can muster? :-P -- Sent from my Android phone with K-9 Mail. Please excuse my brevity. https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://l

Re: [Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Tim Bentley
Review: Needs Fixing Inconsistent tabbing 79 and 189 -- https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-02-11 Thread Andreas Preikschat
Just a note: when you are ready with your changes (fixed) which were requested then resubmit your proposal (upper-left corner -> Resubmit proposal). Then the developers know that your code base is again read to be reviewed. Keep it up :) -- https://code.launchpad.net/~marmyshev/openlp/presentat

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

2013-02-11 Thread Andreas Preikschat
> 3. Importing the old 'images' setting doesn't work anymore. That's why I > import the new 'image files' setting. This does work, but only after an extra > restart of OpenLP. I still have to figure out why. I wrote this code convert the old settings to the "list" setting. http://bazaar.launchpad

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/imp into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147662 Modify the way plugins are imported to use the "imp" module PyUNO, the LibreOffic

[Openlp-core] [Merge] lp:~raoul-snyman/openlp/imp into lp:openlp

2013-02-11 Thread Raoul Snyman
Raoul Snyman has proposed merging lp:~raoul-snyman/openlp/imp into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~raoul-snyman/openlp/imp/+merge/147660 Modify the way plugins are imported to use the "imp" module PyUNO, the LibreOffic

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

2013-02-11 Thread Phill
On 11 Feb 2013 11:46, "Arjan Schrijver" wrote: > 2. Loading images in a separate thread would be nice because of the slowness of SQLite, but I have no clue how to do that. Is there an example somewhere in the codebase? Have a look at the following link. What you want to do may already be implemen

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

2013-02-11 Thread Arjan Schrijver
Okay, most of your comments are now implemented. I have 3 comments/questions myself: 1. The current group icon is 32x32, but I think it is ugly. Do you want it bigger or smaller? The button icons are 16x16. 2. Loading images in a separate thread would be nice because of the slowness of SQLite,

Re: [Openlp-core] [Question #221503]: Is there a page describing the OSZ file format?

2013-02-11 Thread Jonathan Corwin
Question #221503 on OpenLP changed: https://answers.launchpad.net/openlp/+question/221503 Jonathan Corwin posted a new comment: Regarding the service files, there is an open wishlist item to make a more portable service file, however as with many things it just requires someone with the time to pr

Re: [Openlp-core] [Question #221503]: Is there a page describing the OSZ file format?

2013-02-11 Thread Dave Bevan
Question #221503 on OpenLP changed: https://answers.launchpad.net/openlp/+question/221503 Dave Bevan posted a new comment: Thanks for the hint. I've written two simple osd2json and json2osd scripts which expose the data. For example: #!/usr/bin/python import sys, cPickle try: import json

[Openlp-core] [Merge] lp:~googol/openlp/bug-1100277 into lp:openlp

2013-02-11 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/bug-1100277 into lp:openlp has been updated. Description changed to: Hello, - fixed Bug #1100277 (Songs don't load with latest build) - added nose to check_dependencies.py - fixed version number compare in create_separated_list The translate() returns a

Re: [Openlp-core] [Merge] lp:~googol/openlp/registry into lp:openlp

2013-02-11 Thread Andreas Preikschat
Review: Needs Fixing Blank line -- https://code.launchpad.net/~googol/openlp/registry/+merge/147513 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.

[Openlp-core] [Bug 917599] Re: Bible verses not sorted when sending to preview or live

2013-02-11 Thread Andreas Preikschat
** Changed in: openlp Milestone: None => 2.1.1 ** Changed in: openlp Status: Confirmed => Won't Fix -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/917599 Title: Bible verses not sorted wh

[Openlp-core] [Bug 1047995] Re: Inconvenient focus in Song Editor when adding authors

2013-02-11 Thread Andreas Preikschat
** Changed in: openlp/2.0 Status: Incomplete => In Progress ** Changed in: openlp/2.0 Milestone: None => 2.0.2 ** Changed in: openlp/2.0 Importance: Undecided => Low ** Changed in: openlp/2.0 Assignee: (unassigned) => Andreas Preikschat (googol) ** Changed in: openlp/trunk

[Openlp-core] [Bug 1047995] Re: Inconvenient focus in Song Editor when adding authors

2013-02-11 Thread Andreas Preikschat
** Changed in: openlp/2.0 Status: New => Incomplete -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1047995 Title: Inconvenient focus in Song Editor when adding authors Status in OpenLP - Wors

[Openlp-core] [Bug 1047995] Re: Inconvenient focus in Song Editor when adding authors

2013-02-11 Thread Launchpad Bug Tracker
** Branch linked: lp:~googol/openlp/bug-1047995-2 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1047995 Title: Inconvenient focus in Song Editor when adding authors Status in OpenLP - Worship Prese

[Openlp-core] [Bug 1047995] Re: Inconvenient focus in Song Editor when adding authors

2013-02-11 Thread Launchpad Bug Tracker
** Branch linked: lp:~googol/openlp/bug-1047995 -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1047995 Title: Inconvenient focus in Song Editor when adding authors Status in OpenLP - Worship Present

[Openlp-core] [Bug 1047995] Re: Inconvenient focus in Song Editor when adding authors

2013-02-11 Thread Andreas Preikschat
** Also affects: openlp/trunk Importance: Low Status: Confirmed ** Changed in: openlp/trunk Assignee: (unassigned) => Andreas Preikschat (googol) ** Changed in: openlp/trunk Milestone: None => 2.1.1 ** Also affects: openlp/2.0 Importance: Undecided Status: New -- Y

[Openlp-core] [Merge] lp:~googol/openlp/bug-1047995-2 into lp:openlp/2.0

2013-02-11 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1047995-2 into lp:openlp/2.0. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1047995 in OpenLP: "Inconvenient focus in Song Editor when adding authors" https://bugs.launchpad.net/openlp/+bug/1047995 For more de

[Openlp-core] [Merge] lp:~googol/openlp/bug-1047995 into lp:openlp

2013-02-11 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1047995 into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1047995 in OpenLP: "Inconvenient focus in Song Editor when adding authors" https://bugs.launchpad.net/openlp/+bug/1047995 For more details,

[Openlp-core] [Merge] lp:~googol/openlp/bug-1047995-2 into lp:openlp/2.0

2013-02-11 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/bug-1047995-2 into lp:openlp/2.0. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #1047995 in OpenLP: "Inconvenient focus in Song Editor when adding authors" https://bugs.launchpad.net/openlp/+bug/1047995 For more de

[Openlp-core] [Bug 1090641] Re: CCLI license doesn't display

2013-02-11 Thread Andreas Preikschat
** Changed in: openlp Status: Confirmed => Incomplete -- You received this bug notification because you are a member of OpenLP Core, which is subscribed to OpenLP. https://bugs.launchpad.net/bugs/1090641 Title: CCLI license doesn't display Status in OpenLP - Worship Presentation Softwa

[Openlp-core] [Bug 847663] Re: wiki page - how to write unit tests

2013-02-11 Thread Andreas Preikschat
** Also affects: openlp/website Importance: Undecided Status: New ** Changed in: openlp/website Importance: Undecided => High ** Changed in: openlp/website Status: New => Confirmed ** Changed in: openlp/website Milestone: None => 2.1.1 ** Changed in: openlp/website