Re: [Openlp-core] [Merge] lp:~patrick-zakweb/openlp/duplicate-removal-review into lp:openlp

2013-03-03 Thread Raoul Snyman
Review: Needs Fixing OK, just ran the wizard, and I have some tweaks. 1. On the search page, the second line at the top needs to say, "Please wait while your songs database is searched." 2. When no duplicates are found, the screen has both a "Finish" and a "Cancel" button. Finish should always

Re: [Openlp-core] [Merge] lp:~arjan-i/openlp/images_groups into lp:openlp

2013-03-03 Thread Raoul Snyman
Don't forget to resubmit your merge proposal to include the new revisions. -- https://code.launchpad.net/~arjan-i/openlp/images_groups/+merge/151393 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp

Re: [Openlp-core] [Merge] lp:~phill-ridout/openlp/1114457 into lp:openlp

2013-03-03 Thread Raoul Snyman
Don't forget to resubmit your merge proposal to include the newer revisions. -- https://code.launchpad.net/~phill-ridout/openlp/1114457/+merge/151080 Your team OpenLP Core is requested to review the proposed merge of lp:~phill-ridout/openlp/1114457 into lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-902964-2 into lp:openlp/2.0

2013-03-03 Thread Raoul Snyman
Review: Approve This *should* be OK on modern systems, but on older systems like Ubuntu 10.04 things will fail. Do we want to up our minimum versions again? -- https://code.launchpad.net/~googol/openlp/bug-902964-2/+merge/151088 Your team OpenLP Core is subscribed to branch lp:openlp/2.0. _

Re: [Openlp-core] [Merge] lp:~googol/openlp/bug-902964 into lp:openlp

2013-03-03 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/bug-902964/+merge/151085 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscri

Re: [Openlp-core] [Merge] lp:~trb143/openlp/bootstrap into lp:openlp

2013-03-03 Thread Raoul Snyman
Review: Approve Those tests look MUCH better! -- https://code.launchpad.net/~trb143/openlp/bootstrap/+merge/151298 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@l