Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-03-23 Thread Dmitriy Marmyshev
I returned back the import. Probably it's temperary. Please, try all other behaviors of controllers. -- https://code.launchpad.net/~marmyshev/openlp/presentation/+merge/155063 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: h

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-03-23 Thread matysek
Review: Needs Fixing It's probably not working because with our latest style fixes you replaced from appscript import * with import appscript However, you should then also add prefix appscript to the objects you use from that module like appscript.app appscript.k appscript.CantLaunchA

Re: [Openlp-core] [Merge] lp:~marmyshev/openlp/presentation into lp:openlp

2013-03-23 Thread matysek
Review: Needs Information I'm testing it with macoffice 2011 but: - the macoffice is not recognized by openl - all the presentation controllers are greyed out in properties - in the log there is a text like 2013-03-23 13:22:37,125 presentationplugin INFO

Re: [Openlp-core] [Merge] lp:~trb143/openlp/cherrypy into lp:openlp

2013-03-23 Thread Andreas Preikschat
Review: Needs Information When I go to http://localhost:4316/#search I cannot authenticate. I mean when I am not authenticated I should be redirected to a page where I can authenticate. -- https://code.launchpad.net/~trb143/openlp/cherrypy/+merge/155071 Your team OpenLP Core is subscribed to br

Re: [Openlp-core] [Merge] lp:~googol/openlp/image-threads into lp:openlp

2013-03-23 Thread matysek
When testing this on osx I'm not able to add images to the image plugin: - the 'open file dialog' pops up and immediately disappears - so there is no time to select images and click on 'open' to add them to openlp -- https://code.launchpad.net/~googol/openlp/image-threads/+merge/154600 Your team O

[Openlp-core] [Merge] lp:~trb143/openlp/cleanup into lp:openlp

2013-03-23 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/cleanup into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/cleanup/+merge/155092 Minor cleanups and errors from previous merges. -- https://code.launchpad.net/~trb143/

[Openlp-core] [Merge] lp:~trb143/openlp/cleanup into lp:openlp

2013-03-23 Thread Tim Bentley
Tim Bentley has proposed merging lp:~trb143/openlp/cleanup into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~trb143/openlp/cleanup/+merge/155091 Minor cleanups and errors from previous merges. -- https://code.launchpad.net/~trb143/