lp:~knightrider0xd/openlp/propresenter_5-6_import (revision 2634)
[SUCCESS] https://ci.openlp.io/job/Branch-01-Pull/1352/
[SUCCESS] https://ci.openlp.io/job/Branch-02-Functional-Tests/1271/
[SUCCESS] https://ci.openlp.io/job/Branch-03-Interface-Tests/1210/
[SUCCESS] https://ci.openlp.io/job/Branch-
Sorry for DP. Accidentally chose resubmit.
--
https://code.launchpad.net/~knightrider0xd/openlp/propresenter_5-6_import/+merge/290508
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to
Review: Approve
--
https://code.launchpad.net/~knightrider0xd/openlp/propresenter_5-6_import/+merge/290508
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.la
Review: Resubmit
I've implemented the requested changes, with the exceptions of refactoring the
code for self.copyright and self.ccli_number.
While the code appears similar across all versions, it differs for version 6:
# ProPresenter 4 & 5
self.copyright = root.get('CCLICopyrightInfo')
self.ccl
It CAN BE implemented not mandatory so should not thrown an error.
--
https://code.launchpad.net/~trb143/openlp/themefixes/+merge/290340
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post t
Review: Needs Information
See my inline comment.
Diff comments:
> === modified file 'openlp/core/lib/settingstab.py'
> --- openlp/core/lib/settingstab.py2015-12-31 22:46:06 +
> +++ openlp/core/lib/settingstab.py2016-03-29 17:09:30 +
> @@ -135,4 +135,4 @@
> """
>
Review: Needs Information
All good, would just prefer except over a catch-all
except statement.
Diff comments:
>
> === modified file 'openlp/plugins/bibles/lib/mediaitem.py'
> --- openlp/plugins/bibles/lib/mediaitem.py2016-01-08 17:44:47 +
> +++ openlp/plugins/bibles/lib/mediaitem.py
Review: Needs Fixing
Nicely done! Just some comments to address, and then I think we're good to do.
Diff comments:
> === modified file 'openlp/plugins/songs/lib/importer.py'
> --- openlp/plugins/songs/lib/importer.py 2016-03-20 08:28:41 +
> +++ openlp/plugins/songs/lib/importer.py
This happens when "string" is a blank string. It's actually a bug in the
function that we've come across elsewhere, but I think we did something else to
fix it and didn't fix the function itself.
You should be able to fix that by changing line 532 in
openlp/core/utils/__init__.py to this:
No worries.
This works in most instances, but I get a crash, and I think it's when
get_natural_key is passed a blank string. I don't understand the relevant line
of get_natural_key well enough to fix it - help please?
Traceback (most recent call last):
File
"C:\Users\chris\Documents\OpenLP\n
Hi,
Remember to resubmit your merge proposal when it is ready for another review.
And you should probably just leave the branchs status as "development", we use
"mature" for the release branches :)
--
https://code.launchpad.net/~knightrider0xd/openlp/better-slide-scaling/+merge/289580
Your team O
Not sure about this.
Why have you change themes and not set a parameter in the song settings.
We have 20+ themes and would need to change all of theme.
Not unhappy with the idea just the implementation.
Well done with the theme changes though! but you missed theme.json!
--
https://code.launchpad.
Review: Needs Fixing
Minor tweeks but much better.
Needs tests though!
Diff comments:
>
> === modified file 'openlp/core/ui/advancedtab.py'
> --- openlp/core/ui/advancedtab.py 2016-01-19 06:52:23 +
> +++ openlp/core/ui/advancedtab.py 2016-03-30 17:36:10 +
> @@ -304,6 +307,7 @@
>
** Branch linked: lp:~knightrider0xd/openlp/propresenter_5-6_import
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1358601
Title:
Support ProPresenter 5 song import
Status in OpenLP:
In Progress
Azaziah has proposed merging
lp:~suutari-olli/openlp/show-no-logo-or-background-when-starting into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/show-no-logo-or-background-when-starting/+merge/290507
In this re-propos
The proposal to merge
lp:~suutari-olli/openlp/show-no-logo-or-background-when-starting into lp:openlp
has been updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~suutari-olli/openlp/show-no-logo-or-background-when-starting/+merge/289111
--
Your t
OK :D
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1517500
Title:
import openlyrics xml - KeyError: 'temporary'
Status in OpenLP:
Invalid
Bug description:
windows 7, Portable OpenLP 2.2.1
I
Tomasss, I'm just talking about how OpenLP handles errors, not you :)
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1517500
Title:
import openlyrics xml - KeyError: 'temporary'
Status in OpenLP:
OK, I will try to do it better next time.
Thanks for your good job. God bless you.
--
You received this bug notification because you are a member of OpenLP
Core, which is subscribed to OpenLP.
https://bugs.launchpad.net/bugs/1517500
Title:
import openlyrics xml - KeyError: 'temporary'
Status
19 matches
Mail list logo
