mohij has proposed merging lp:~patrick-zakweb/openlp/live-background-reset into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/live-background-reset/+merge/172193
When replacing live background with an image
Given that this branch seems to be nearing a real merge, I have also proposed
the original duplicate-song-finder branch for merge:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-song-finder/+merge/169659
--
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review-2
> Sorry but if you propose a merge for a branch, get it approved then that is
> the one to merge not a different one.
> Why do we have 2 branches?
At first I proposed the original branch for merge. That one does contain a new
image (the image for the wizard start page). That image took up the ent
lp:~patrick-zakweb/openlp/duplicate-song-finder
Is the correct branch to merge.
This one should be deleted as soon as the merge is through.
--
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review-2/+merge/169614
Your team OpenLP Core is subscribed to branch lp:openlp.
_
mohij has proposed merging lp:~patrick-zakweb/openlp/image-previews into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/169616
This branch does not add any new
The bug with the "replace live background" is already present in trunk. I'll
fix it once this branch is merged since I prefer keeping changes separate.
--
https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/169616
Your team OpenLP Core is subscribed to branch lp:openlp.
_
mohij has proposed merging lp:~patrick-zakweb/openlp/image-previews into
lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/169616
This branch does not add any new
mohij has proposed merging lp:~patrick-zakweb/openlp/image-previews into
lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/169539
This branch does not add any new
Hey, thank you for the quick reply!
> Cancel does not work!
Can you clarify? I tried the cancel button an all wizard pages and it always
instantly exits the wizard here. What's happening for you? What do you expect?
> why do I get "Praise Him You Heavens = a"? a is a blank test song and i
mohij has proposed merging lp:~patrick-zakweb/openlp/image-previews into
lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/161283
This branch does not add any new features. It refactors the
mohij has proposed merging lp:~patrick-zakweb/openlp/pre-wizard-rename-bug into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/pre-wizard-rename-bug/+merge/160973
Correct the naming of preWizard -> pre_wiz
mohij has proposed merging lp:~patrick-zakweb/openlp/image-previews into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/image-previews/+merge/160207
This branch does not add any new features. It refactors the
Please ignore this review proposal for now. I messed it up by removing and
adding resources.py. I didn't manage go get the change out of this branch. So I
created a new branch (again :-( ... ).
duplicate-removal-review-2
^--- that's the new review request
Sorry for the inconvenience.
--
http
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review
> What is this for? Very non standard,
> self.emit(QtCore.SIGNAL(u'song_remove_button_clicked(PyQt_PyObject)'), self)
You proposed to replace the Qt signal-slot mechanism here with the
Registry.register-function/execute mechanism. I disagree here. My intent is to
keep the SongReviewWidget deco
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148561
I resubmitted
The proposal to merge lp:~patrick-zakweb/openlp/duplicate-removal-review into
lp:openlp has been updated.
Description changed to:
I resubmitted this request in a separate branch, because I removed the
resources file to make the diff readable. This basically breaks the branch but
makes it revie
mohij has proposed merging lp:~patrick-zakweb/openlp/duplicate-removal-review
into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/duplicate-removal-review/+merge/148345
This is no real merge request. I would
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge
> Don't use "Diable bla bla bla" in checkboxes. I have to enable a checkbox to
> disable something?
>
> 1) Should be "Enable alternating row colors in lists".
> 2) Please used --fixes lp:# when committing. Also assign
> yourself to the bug you are fixing:
> https://bugs.launchpad.net/openlp/+bug/9
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge
Very minor: Duplicate "should" in several comments. Lines 558, 579, 586, 594,
634, 641.
--
https://code.launchpad.net/~trb143/openlp/media/+merge/141822
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~o
The proposal to merge lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp has been updated.
Description changed to:
Continuation of bug-9362181 branch.
My bzr denied pushing to the other branch with a "different serializers"
incompatibility error. Thus I created a new branch. I hope i
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Andreas Preikschat (googol)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Jonathan Corwin (j-corwin)
Tim Bentley (trb143)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Jonathan Corwin (j-corwin)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Andreas Preikschat (googol)
Jonathan Corwin (j-corwin)
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/139312
Continuation of bug-9362181 branch.
My bzr denied
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-newformat into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-newformat/+merge/139121
Continuation of bug-9362181 branch.
My bzr denied
> Is Line 16 in the correct place? Is it needed or should it be with 11?
As before the large stylesheet block now called "nt_repair_stylesheet" should
only be loaded on Windows.
The removal of alternating row colors is not operating system dependent. So I
guess it's correct the way it is.
> Li
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Andreas Preikschat (googol)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/138884
Merged master
> This change seems to have broken transparent backgrounds for themes so that
> needs to be resolved.
Can you clarify:
Do you mean *this* merge request or the one already in trunk
(lp:~patrick-zakweb/openlp/bug-936281-for20)?
How can I reproduce this?
Thank you!
--
https://code.launchpad.net/~p
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
Andreas Preikschat (googol)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/137454
-Added docstring.
-merge master
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-for20 into
lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-for20/+merge/135750
Remove alternating row colors on Windows OS. No
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281-for20 into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281-for20/+merge/135550
Remove alternating row colors on Windows OS. No
> Does this affect all lists? If so I'm not sure that splitting this merge is
> a good idea.
>
> I'll be honest, I am unable to check this branch out to have a look on a
> windows machine, but I imagine that this would make distinguishing between
> different verses, in the song editor and preview/
> Sorry Patrik, I have one last request. Can you split this into two merges? One
> without the configuration part (just disable alternate rows on Windows) so
> that we can merge it now, and one with the configuration so that we can merge
> it into post-2.0?
>
> Thanks!
Will do, no problem!
--
ht
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/135010
-Fix defaults to activated on Windows and inactive on Linux
> OK, one last silly question:
>
> Why don't we just simply disable alternate rows in Windows? They never see
> alternating row colours anyways, so it wouldn't make a difference to them
> anyway.
Good point. The original reason for not just disabling alternating colors was
the mailing list discu
> The difference in KDE is ugly compared to the normal. Why not just apply this
> to Windows only, since Windows is the only platform with the problem?
>
> Also, last time I tried, I could not access your Windows screenshots.
The fix is configurable in the configuration under Advanced.
It is disa
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp.
Requested reviews:
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/133998
- Made fix configurable in advanced menu.
- Corrected
mohij has proposed merging lp:~patrick-zakweb/openlp/bug-936281 into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~patrick-zakweb/openlp/bug-936281/+merge/132614
This branch add a logic, that changes the alternate-background-color
Then I really don't understand how to use this feature. As far as I
understand, when selecting the same translation as "Version:" and
"Second:" then the exact same text is displayed twice. Can you clarify
what this can be used for? In case I misunderstand the functionality,
can you correct me?
--
Public bug reported:
When using the "Advanced" Tab in the Bible module it is possible to
select the same translation for first and second version. This is
confuses me and I don't see what this could be useful for.
** Affects: openlp
Importance: Undecided
Status: New
--
You receive
*Only* marking items not yet viewed does not always help with knowing
which item is currently active, since one might go back to a previous
entry, then the active one is not the one directly before the first
unviewed.
--
You received this bug notification because you are a member of OpenLP
Core,
49 matches
Mail list logo
