The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/113092
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/113092
Your team OpenLP
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/113092
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/113092
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/113092
Your team O
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/113092
- fixed spelling
--
https://code.launchpad.net/~googol/openlp/image-qu
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
Your team OpenLP
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
Your team O
Review: Approve
line 127 is missing a "y" - but you can fix this later !
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-cor
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112948
Hello
- update the image cache when the image timestamp changes (1. Bug)
-
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112946
Hello
- update the image cache when the image timestamp changes (1. Bug)
-
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes
- reworked image manager's _cache
1. Bug:
1) Display/preview an image.
2) Edit the image.
3) Send it live/preview again.
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes (1. Bug)
- reworked image manager's _cache (2. Bug and 3. Bug)
1. Bug:
1) Display/preview an image.
2) Edit the image.
3)
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes
- reworked image manager's _cache
1. Bug:
1) Display/preview an image.
2) Edit the image.
3) Send it live/preview again.
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/112943
Hello
- update the image cache when the image timestamp changes (1. Bug)
-
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes
- reworked image manager's _cache
Bug1:
1) Display/preview an image.
2) Edit the image.
3) Send it live/preview again.
R
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes
- reworked image manager's _cache
Bug-1:
1) Display/preview an image.
2) Edit the image.
3) Send it live/preview again.
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes
- reworked image manager's _cache
Bug 1:
1) Display/preview an image.
2) Edit the image.
3) Send it live/preview again.
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello
- update the image cache when the image timestamp changes
1) Display/preview an image.
2) Edit the image.
3) Send it live/preview again.
Result:
Cache is not updated.
Expected:
Note (for myself): report bug on get_frame_path() not returning the complete
path (media).
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/110793
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchp
I want to be reviewed first:
https://code.launchpad.net/~googol/openlp/theme/+merge/112804
And then I'll need to do some more work.
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/110793
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Resubmit
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/110793
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
Going to resubmit this?
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/110793
Your team OpenLP Core is requested to review the proposed merge of
lp:~googol/openlp/image-queue into lp:openlp.
___
Mailing list: https://launchpad.net/~ope
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/110793
NOT TO BE REVIEWED PRIOR TO THE 1.9.10 RELEASE!
Hello
- update the im
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
Your team OpenLP
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
Your team O
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/108539
Hello,
- stop the imageManager when closing O
> 9 + self.imageThread = ImageThread(self)
> 10 self._conversion_queue = PriorityQueue()
> 11 + self.stop_manager = False
>
> Naming conventions...
As far as I remember python objects are words_with_underscore and Qt objects
camelCase (independently from being used in a python or
Review: Needs Fixing
9 + self.imageThread = ImageThread(self)
10 self._conversion_queue = PriorityQueue()
11 + self.stop_manager = False
Naming conventions...
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/107549
Your team OpenLP Core is subscribed to branch lp:o
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/107549
Hello,
- stop the imageManager when closing OpenLP (when you add some image
Review: Needs Fixing
Line 115 and below should not be in "If save settings" block.
They close the database connections and clean up so yo need them to run
regardless.
ServiceManager.cleanUp should also be called regardless.
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/107529
Y
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/107529
Hello,
- stop the imageManager when closing OpenLP (when you add some
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
Your team OpenLP
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello,
I have added a secondary criterion for the image queue to privilege images
which were added earlier over images which were added later when both have the
same priority.
For mor
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
Your team O
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
Hello,
I have added a secondary criterion for
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104849
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Review: Needs Fixing
> NUMBER
Capital letters should only be used for constants. "number" is perfectly fine,
though I'm not too sure I'd use that word exactly, perhaps "count"?
24 + Each item in the queue must be tuple with three values. The fist value
"first", not "fist"
--
https://cod
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104834
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscr
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104834
Hello,
I have added a secondary criterion for the image queue to privi
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104833
Hello,
I have added a secondary criterion for the image queue to privi
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Description changed to:
Hello,
I have added a secondary criterion for the image queue to privilege images
which were added later over images which were added earlier when both have the
same priority.
NOTE: D
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/104832
Hello,
I have added a secondary criterion for the image queue to privi
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Your team OpenLP Co
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Your team Ope
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
I hope I didn't miss anything... :-)
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Your team OpenLP Core is requested to review the proposed merge of
lp:~googol/openlp/image-queue into lp:openlp.
___
Mailing list: https://launch
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Hello,
- small image queue fix
When the QImage was created before it wa
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Work in progress
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Your
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/67221
Hello,
- small image queue fix
When the QImage was created before it wa
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
Your team OpenLP Co
The proposal to merge lp:~googol/openlp/image-queue into lp:openlp has been
updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
Your team Ope
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Review: Approve
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscrib
Andreas Preikschat has proposed merging lp:~googol/openlp/image-queue into
lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65969
Hello,
I changed the image manager in two ways
I changed this. Also we remove the image from the queue when we remove the
image form the cache.
--
https://code.launchpad.net/~googol/openlp/image-queue/+merge/65892
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://la
Review: Needs Fixing
You've changed "_clean_cache()" to "_process_cache()", can you also change
"_clean_queue" to something else? Maybe "_conversion_queue", or something else
a little more descriptive. "_clean_queue" make it sound like the images are
"dirty" as opposed to unprocessed or unconver
60 matches
Mail list logo
