[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2013-04-20 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/159950 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/159950 Your team OpenLP Core is s

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2013-04-20 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/159950 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2013-04-20 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/159950 Hello, - close file -- https://code.launchpad.net/~googol/openlp/trivial/+mer

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-12-04 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-12-03 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-12-03 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-12-02 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-12-02 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/137442 - removed not needed 'QtCore.Qt.OtherFocusReason' from setFocus calls - fixed '

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-10-02 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/127555 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/127555 Your team OpenLP

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-10-02 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/127555 - removed not needed 'QtCore.Qt.OtherFocusReason' from setFocus calls - fixed '

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-12 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/114698 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/114698 Your team OpenLP

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-12 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Description changed to: NOTE: To be reviewed after the 1.9.11 release. - removed not needed 'QtCore.Qt.OtherFocusReason' from setFocus calls - fixed 'short' lines - changed addItem to addItems when possible - other

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-12 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/114698 NOTE: To be reviewed after the 1.9.11 release. - removed not needed 'QtCore.Qt

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-08 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-08 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-08 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-07 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-07 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/113827 clean ups -- https://code.launchpad.net/~googol/openlp/trivial/+merge/113827

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-02 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-02 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-02 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-01 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-07-01 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/112944 - fixed variable name -- https://code.launchpad.net/~googol/openlp/trivial/+m

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-17 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Jonathan Corwin
Review: Approve OK. Need to learn to look at the right merge proposal, and also to read the existing code properly when comparing with new :) Approved. -- https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 Your team OpenLP Core is subscribed to branch lp:openlp. ___

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Andreas Preikschat
Ooops... I resubmitted because of a change in my code (not as a response to you). > Although wondering what verseId on line 162 did to upset you :) Local variables use underscore_variable_names >Rather than splitting the title if it contains any \n's (which will cause a >blank title if there i

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Jonathan Corwin
Review: Needs Fixing I'm not too keen on refactors/tidies at this stage, it's all too easy to introduce mistakes or miss a variable. However this time I will let it pass. Although wondering what verseId on line 162 did to upset you :) Needs fixing for: Rather than splitting the title if it cont

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Jonathan Corwin
Review: Needs Information Where does the title in add_from_text get used? -- https://code.launchpad.net/~googol/openlp/trivial/+merge/110662 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core P

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/110664 Hello, Various clean ups: - refactor method argument - some variable name fix

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/110663 Hello, Various clean ups: - refactor method argument - some variable name fix

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-16 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/110662 Hello, Various clean ups: - refactor method argument - some variable name fix

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/109485 Hello, - clean ups -- https://code.launchpad.net/~googol/openlp/trivial/+merge/109

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread Tim Bentley
Review: Needs Fixing Totally disagree with the cleanups in Htmlbuilder they make the code harder to read. Rest is fine. -- https://code.launchpad.net/~googol/openlp/trivial/+merge/109484 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mai

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-06-09 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/109484 Hello, - clean ups -- https://code.launchpad.net/~googol/openlp/trivial/+merg

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-20 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-20 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-20 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-19 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-19 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106499 random clean ups -- https://code.launchpad.net/~googol/openlp/trivial/+merge/1

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-18 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-18 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-18 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-17 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-17 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/106252 Hello, - removed a work around as it should not be needed any longer - uncomme

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-07 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-07 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-07 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-07 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-07 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/104926 Hello, If you select a service item and right click it no shortcuts are shown

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-05 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-05 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-05 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-05 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-05 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/104831 Hello, - random clean ups -- https://code.launchpad.net/~googol/openlp/trivia

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-01 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-01 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-01 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-01 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-05-01 Thread Andreas Preikschat
> Receiver.send_message(u'openlp_phonon_creation') removal needs to be > considered. Cannot remember why this was added but it was so what is the > impact of it's loss. This was added because the phonon (media object?) creation was slow on some computer. However, we do not connect to this signa

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-30 Thread Tim Bentley
Review: Needs Information Receiver.send_message(u'openlp_phonon_creation') removal needs to be considered. Cannot remember why this was added but it was so what is the impact of it's loss. -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Your team OpenLP Core is subscribed t

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-28 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/103988 Hello, - removed dead code - refactor version comparison code -- https://co

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-28 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/103981 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-28 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/103981 Hello, - removed dead code - refactor version comparison code -- https://code

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-22 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-21 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-21 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-21 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-21 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Description changed to: Hello, - added favicon to remote pages Icon: 32x32 4,2 KB (4.286 Byte) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 -- https://code.launchpad.net/

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-21 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Description changed to: Hello, - added favicon to remote pages For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102962 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-18 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-18 Thread Raoul Snyman
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 Your team OpenLP Core is

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-16 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-15 Thread Tim Bentley
Review: Approve os is fine as it does not impact any code. -- https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : op

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-15 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: Jonathan Corwin (j-corwin) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/102027 Hello, - trivial clean ups -- https://code.launchpad.net/~googol/openlp/triv

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-15 Thread Andreas Preikschat
> Are there benefits of import os vs import os.path, or is import os.path wrong? import os vs. import os.path is a funny thing. For example see http://stackoverflow.com/questions/2724348/should-i-use-import-os-path-or-import-os import os.path does not make sense to me, because it actually import

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-12 Thread Jonathan Corwin
Review: Needs Fixing Are there benefits of import os vs import os.path, or is import os.path wrong? Line 63: If you're going to fix the indent, you may as well fix the spelling too of this very important comment :) -- https://code.launchpad.net/~googol/openlp/trivial/+merge/101741 Your team O

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2012-04-12 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/101741 Hello, - trivial clean ups -- https://code.launchpad.net/~googol/openlp/trivi

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-12-19 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 Your team OpenLP Core is subscri

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-12-18 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-12-18 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 Your team OpenLP Core is s

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-12-18 Thread Tim Bentley
Review: Approve Simple one -- https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Uns

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-12-18 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/86174 Added floft to the list of packagers -- https://code.launchpad.net/~googol/open

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-11-19 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/82772 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/82772 Your team OpenLP Core is subscri

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-11-19 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/82772 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/82772 Your team OpenLP Core is s

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-11-19 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/82772 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-11-19 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/82772 - do not (re)load the list twice when cloning a theme The list is already (re)l

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread noreply
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 Your team OpenLP Core is subscri

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Tim Bentley
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 -- https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 Your team OpenLP Core is s

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

Re: [Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscribe :

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Description changed to: Hello, - removed obsolete signals (e. g. videodisplay_start, videodisplay_play, videodisplay_pause, videodisplay_stop, videodisplay_background) - renamed signals (maindisplay_* -> live_displ

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Description changed to: Hello, - removed obsolete signals (e. g. videodisplay_start, videodisplay_play, videodisplay_pause, videodisplay_stop, videodisplay_background, ) - renamed signals (maindisplay_* -> live_dis

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Andreas Preikschat
The proposal to merge lp:~googol/openlp/trivial into lp:openlp has been updated. Commit Message changed to: - removed obsolete signals - renamed signals - rearranged the signals to groups For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 -- https://code.launc

[Openlp-core] [Merge] lp:~googol/openlp/trivial into lp:openlp

2011-10-22 Thread Andreas Preikschat
Andreas Preikschat has proposed merging lp:~googol/openlp/trivial into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~googol/openlp/trivial/+merge/80124 Hello, - removed obsolete signals (e. g. videodisplay_start, videodisplay_play,

  1   2   >