The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
--
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
Your team OpenLP Core is subscribed to branch lp:o
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
--
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
Your team OpenLP Core is subscribed to branc
Review: Approve
Looks alright to me, but I don't have any weird old service files to test with.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Commit Message changed to:
Bug #882819 - recover v1.x theme file names from XML info
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
--
https://code.launchpad.net/~m2j/openlp/work/+merge/8
Meinert Jordan has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Jon Tibble (meths)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/85949
Hmm, I implemented file name recovery from the XML file content for v1.x
themes.
Good point, to transfer v1.x code into a seperate method.
About the file_is_unicode() method: In the used case the function does not make
more then calling decode() and log a caught the excepting. Then it needs an
additional check and and error dialog on the callers side.
IMHO it makes the code
Review: Needs Fixing
Whilst I can see what you are doing I would like the code restructured.
The V1 code was kept in it's own method for a reason (it will die at some
point) and I did not want that mixed too much with V2.
Lines 119 - 146 should be in there own method.
Why remove file_is_unicode
Meinert Jordan has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Jon Tibble (meths)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/85413
Hmm, I implemented file name recovery from the XML file content for v1.x
themes. As I thought about mor
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
--
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
Your team OpenLP Core is subscribed to branch lp:o
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
--
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
Your team OpenLP Core is subscribed to branc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Sorry, I missed to adapt a comment.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/83350
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
U
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/83351
Bug #875286
use VerseType.Other if it is not recogniced during OpenSong import.
--
https://code.launchpad.net/~
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/83350
Bug #875286
use VerseType.Other if it is not recogniced during OpenSong import.
--
https://code.launchpad.net/~
Good idea. To be honest just ATM I can't imagine any case, where you need to
have another default value, but your suggestion saves a some lines of code and
makes it more descriptive.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Your team OpenLP Core is subscribed to branch lp:open
Instead of using "strict=False", why not use "default=VerseType.Other", which
makes the function more useful.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https:/
Review: Approve
I think this OK but I cannot test it.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@li
Hi,
it would be nice to know, what has to be fixed. I answerd all questions and
still I don't know, what should be changed. Please write further information,
what syntactic or semantic errors need to be fixed in my code.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Your team OpenL
Ah, another thing: I decided to make False as default, as this is also default
for the existing methods from_tag, from_string, translated_name and
translated_tag
--
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Your team OpenLP Core is subscribed to branch lp:openlp.
This is, what it is intended to do. It returns None, if it reaches the end of
the function w/o passing a return statement. We need this case, as there are
several calls, where the return value is tested to be None. This is for example
the case each time I added True to existing calls.
--
https:
Review: Needs Fixing
Not sure about 52.
What happens if Strict is True we have a null return?
Do we need strict? Would it not be better just to return Other?
--
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Your team OpenLP Core is subscribed to branch lp:openlp.
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/82668
Bug #875286
use VerseType.Other if it is not recogniced during OpenSong import.
--
https://code.launchpad.
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
Your team OpenLP Core is subscribed to branch lp:o
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
Your team OpenLP Core is subscribed to branc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
add uno to the dependency check
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80428
Your team OpenLP Cor
Oh, right I haven't seen that. So it makes no sense ATM.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80390
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@
Review: Needs Fixing
Sorry but I will reject the changes to HTMLbuilder eimach has a different set
in the pipe line.
The uno one is OK.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80390
Your team OpenLP Core is subscribed to branch lp:openlp.
__
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80390
name placeholders in extensive string substitutions
add uno to the dependency check
--
https://code.launchp
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
Your team OpenLP Core is subscribed to branch lp:o
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
Your team OpenLP Core is subscribed to branc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80126
add version information for mako, migrate and uno to exceptionform
--
https://code.launchpad.net/~m2j/openlp/wor
Review: Needs Fixing
Do not like "ok" how about "< 0.7" which is more correct
--
https://code.launchpad.net/~m2j/openlp/work/+merge/80077
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/80077
add version information for mako, migrate and uno to exceptionform
--
https://code.launchpad.net/~m2j/openl
> I don't think migrate.__version__ is available in all versions of migrate... I
> think it's actually only available in 0.7, or whatever the latest version is.
Oh, you're right. It is available in 0.7.1 but not in 0.6. Should I set the
version string to 'OK' if there is no __version__?
--
https
I don't think migrate.__version__ is available in all versions of migrate... I
think it's actually only available in 0.7, or whatever the latest version is.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/79997
Your team OpenLP Core is requested to review the proposed merge of
lp:~m2j/open
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/79997
add version information for mako, migrate and uno to exceptionform
--
https://code.launchpad.net/~m2j/openl
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
--
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
Your team OpenLP Core is subscribed to branch lp:o
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
--
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
Your team OpenLP Core is subscribed to branc
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
Nice
--
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https://launchpad.
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/79481
- exception dialog uses Qt call instead of external library
- unicode support in report text and attached fi
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
Bug #609356 in OpenLP: "Web bibles don't download all their books on import"
https://bugs.launchpad.net/openlp/+bug/609356
Bug #661867 in OpenLP: "Invalid author added in
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/45653
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45653
Your team OpenLP Core is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45653
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https:
Review: Approve
Approved
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45653
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Related bugs:
#609356 Web bibles don't download all their books on import
https://bugs.launchpad.net/bugs/609356
#661867 Invalid author added in song dialog
https://bugs.launchpad.net/bug
Review: Needs Fixing
Looks good and I would approve but you have changed some code I have moved
around in ThemeManager in my updates.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45628
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Hit the wrong button. Wanted to renew the other one as there was a merge
conflict.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45628
Your team OpenLP Core is requested to review the proposed merge of
lp:~m2j/openlp/work into lp:openlp.
___
M
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#609356 Web bibles don't download all their books on import
https://bugs.launchpad.net/bugs/609356
#661867 Invalid author added in song dialog
https://bugs.launchpad.ne
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#609356 Web bibles don't download all their books on import
https://bugs.launchpad.net/bugs/609356
#661867 Invalid author added in song dialog
https://bugs.launchpad.ne
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/45506
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45506
Your team OpenLP Core is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45506
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https:
Review: Approve
Approved.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45506
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
TRB: I removed add the tristate stuff, as superfly doesn't like it. Where do
you want now comments?
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45506
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad
Review: Needs Fixing
No Comments
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45506
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsu
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Related bugs:
#609356 Web bibles don't download all their books on import
https://bugs.launchpad.net/bugs/609356
#661867 Invalid author added in song dialog
https://bugs.launchpad.net/bug
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/45504
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45504
Your team OpenLP Core is subscribed to branch
Ah, now I understand, what you mean. I'll add some comments.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45504
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-c
Review: Needs Fixing
Ok but there is no explanation in a comment as to why you are doing this.
Come back in six months an try to remember why and you may be scratching your
head.
I am already.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45504
Your team OpenLP Core is subscribed to bran
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
Tim Bentley (trb143)
Related bugs:
#609356 Web bibles don't download all their books on import
https://bugs.launchpad.net/bugs/609356
#661867 Invalid author added in song dialog
https://bugs.launchpad.net/bug
The user will never interact with a tristate button, because this is only for
optical reasons (all tristate buttons are disabled).
I have now added a '%s (unavailable)' tag to the corresponding CheckBoxes.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45500
Your team OpenLP Core is subscr
Review: Needs Fixing
Some documentation needs to be added to explain what the states mean.
No problems in principle with the change but the use of Tristate needs to be
defined and documented.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45500
Your team OpenLP Core is subscribed to branch
m2j has proposed merging lp:~m2j/openlp/work into lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
Related bugs:
#609356 Web bibles don't download all their books on import
https://bugs.launchpad.net/bugs/609356
#661867 Invalid author added in song dialog
https://bugs.launchpad.ne
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/45300
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45300
Your team OpenLP Core is subscribed to branch
Review: Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45300
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe : https:
Review: Approve
Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45300
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
Review: Needs Fixing
670 + if not bible:
671 + QtGui.QMessageBox.information(self.parent.mediaItem,
672 + translate('BiblesPlugin.BibleManager',
673 + 'No Bibles available'),
674 + translate('BiblesPlugin.BibleManager',
675 + 'There are no Bibles currently installed. Please
Review: Approve
Approved.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45287
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/45215
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45215
Your team OpenLP Core is subscribed to branch
Review: Approve
Approved
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45215
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
Review: Approve
All good from me.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45215
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Uns
Review: Needs Fixing
It looks like you're trying to achieve some formatting in that HideMode
docstring? Unfortunately that is not valid reStructuredText, which is what
docstrings should be formatted in. Here's a better formatting:
"""
This is an enumeration class which specifies the dif
Review: Needs Fixing
Too Early in the morning.
Wrong State!
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45024
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-
Review: Approve
Need to respin as I have changed the Advanced Tab in the last Head merge
Thanks for sorting out the EventResize methods
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45024
Your team OpenLP Core is subscribed to branch lp:openlp.
Additional to the requested changes there is a new QValidator for the remote
addressLineEdit which allows IP4 addresses.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/45024
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing li
Review: Needs Fixing
I don't like how I cannot see the edges of the TabWidget anymore. There needs
to be an 8 pixel space between the edge of the dialog and the TabWidget. Also,
there needs to be an 8 pixel margin around the gorup boxes, and an 8 pixel
padding inside the group boxes.
--
https:/
Review: Needs Fixing
20 This is basically an enumeration class which specifies differnt hiding
modes
21 for the display. The option ``Blank`` to cover the display black. The
option
22 ``Theme`` removes the content from the theme. ``Screen`` finally hides
the
23 output, so tha
Review: Approve
Looks Ok in one respect but this is a bit change.
The resizeEvent is copied a lot even if it is doing the same calc on different
events.
Can it made part of the super class?
We also seem to be having a game of lets reformat layout between different
developers where
lines are ref
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/44896
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44896
Your team OpenLP Core is subscribed to branch
Review: Approve
Hrm, it seems that KDE-proper applications add the application name in the
title of all windows (for the most part, there are a few that don't), but most
other applications on my system don't do that. I know that it is not something
that is done on Windows, and on OS X there isn'
Review: Approve
Approve
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44896
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe :
AFAIK most applications have the name in all window titles. This is useful for
window managing. OpenLP does not have this. So I will remove strings. If we
want to have them s/o should go through all dialogs at once. A new merge
request will follow.
--
https://code.launchpad.net/~m2j/openlp/work
Review: Needs Fixing
515 + 'Edit Theme %s - OpenLP')) % self.theme.theme_name)
519 + 'New Theme - OpenLP'))
We don't need the " - OpenLP" in there, surely?
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44853
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
Approved
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44853
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscribe
Now, as I have to resubmit, I've integrated a fix for bug #695136 and the
resizing preview.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44783
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~op
Oh, sorry. I accidently updated the branch without thinking of the merge
request.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44783
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Review: Needs Fixing
Please either remove the revision since submitting this merge proposal, or
resubmit the merge proposal so that it includes this revision.
Thanks.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44783
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Review: Approve
Looks Ok now.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44783
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubsc
Review: Needs Fixing
Line 596 removing the frame for a protected Theme name does not look nice.
Transition Check box should be reversed and the label looks in the wrong place
now.
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44761
Your team OpenLP Core is subscribed to branch lp:openlp.
The changes to slidecontroller.py are not necessary (line 121, 129, 138),
because this is already changed in my merge proposal.
https://code.launchpad.net/~googol-hush/openlp/slidecontroller/+merge/44744
Cheers
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44761
Your team OpenLP Core is
(oops, that should read, "(yes, not *your* code...")
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44748
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@list
Review: Needs Fixing
In terms of consistent naming scheme, there is (for instance)
"mainColourButtonClicked" and "mainColorButton" (see the missing "u"?). It's
not a formal naming scheme, but I think consensus in IRC is that we use British
English, i.e. Colour over Color.
Also, you have snippe
The proposal to merge lp:~m2j/openlp/work into lp:openlp has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~m2j/openlp/work/+merge/44508
--
https://code.launchpad.net/~m2j/openlp/work/+merge/44508
Your team OpenLP Core is subscribed to branch lp:o
1 - 100 of 202 matches
Mail list logo
