The proposal to merge lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
has been updated.
Status: Approved => Merged
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54977
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts
The proposal to merge lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
has been updated.
Status: Needs review => Approved
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54977
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-s
Review: Approve
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54977
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
As TRB143 mentioned in the chat the QSettings should be correct without the
additional 'OpenLP' parameters
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54977
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Thanks Raoul, as we just chatted on IRC, the script is called via make from the
resources/osx directory (where the get_version.py is also located), the
.version will be later copied into the application package
(OpenLP.app/Contents/MacOS)
--
https://code.launchpad.net/~matthiashub/openlp/osx-bu
Review: Approve
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54977
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Just make sure that when you run the "get_version" file, that either you are in
the directory where OpenLP trunk is checked out to, or you specify the path to
OpenLP. Also make sure that you output the version file to the right place.
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-s
The proposal to merge lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
has been updated.
Description changed to:
- using raouls get_version script from
http://wiki.openlp.org/Packaging:Version_Script to create the .version file
during the build process
- fixed the language configuration
The proposal to merge lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
has been updated.
Description changed to:
using raouls get_version script from
http://wiki.openlp.org/Packaging:Version_Script to create the .version file
during the build process
fixed the language configuration sav
Matthias Hub has proposed merging lp:~matthiashub/openlp/osx-build-scripts into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54977
- using raouls get_version script from
http://wiki.open
The proposal to merge lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54955
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scr
Review: Approve
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Excellent
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.laun
Review: Approve
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54955
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Matthias Hub has proposed merging lp:~matthiashub/openlp/osx-build-scripts into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/54955
Changes did for the packaging of 1.9.5 (version 1346 con
The proposal to merge lp:~matthiashub/openlp/osx-build-scripts into lp:openlp
has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51473
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scr
Review: Approve
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51473
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Review: Approve
Thanks!
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51473
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launch
Review: Approve
Looks good.
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51473
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.la
Matthias Hub has proposed merging lp:~matthiashub/openlp/osx-build-scripts into
lp:openlp.
Requested reviews:
Matthias Hub (matthiashub)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51473
Added OS X build scripts
The commented lines were used with the old PyInstaller version. I removed it.
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51448
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.n
Review: Needs Fixing
Line 9 is also too long.
Lines 450-459 are commented out. If you're never going to use this code, rather
remove it. If you are, perhaps put a condition in for it? "if a then ..."
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51448
Your team OpenL
Matthias Hub has proposed merging lp:~matthiashub/openlp/osx-build-scripts into
lp:openlp.
Requested reviews:
Matthias Hub (matthiashub)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51448
Added OS X build scripts
Hi Mathias, you need to resubmit your merge proposal by clicking on the link at
the top of the right-hand column.
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51433
Your team OpenLP Core is subscribed to branch lp:openlp.
Review: Resubmit
Thanks a lot for looking into the code! Updated as recommended (hope I got
everything...)
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51433
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mai
Oh, can you also just add a "readme.txt" file which details where your script
expects PyInstaller, etc to be and how to run it? See
scripts/windows-builder.py for an example.
--
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51433
Your team OpenLP Core is subscribed to b
Review: Needs Fixing
Note: line numbers below relate to the diff, not the actual files.
Is there a reason line 9 uses "QtGui.QApplication" as opposed to "OpenLP",
since "OpenLP is a derivative of QtGui.QApplication?
Lines 352 to 357:
- Your variables need to conform to the coding standards, i.e.
Matthias Hub has proposed merging lp:~matthiashub/openlp/osx-build-scripts into
lp:openlp.
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~matthiashub/openlp/osx-build-scripts/+merge/51433
Added OS X build scripts
Please note: there is also one
28 matches
Mail list logo
