[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-04 Thread noreply
The proposal to merge lp:~smpettit/openlp/packaging into lp:openlp has been updated. Status: Approved => Merged For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 Your team OpenLP Co

[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Tim Bentley
The proposal to merge lp:~smpettit/openlp/packaging into lp:openlp has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 Your team Ope

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Jonathan Corwin
Review: Approve Tim, pyinstaller handles all that, all Stevan has done is add a comment telling future Windows packagers what to install should he ever retire! -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 Your team OpenLP Core is subscribed to branch lp:openlp. _

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Tim Bentley
Review: Needs Information Should we not include mako in the package. There may be problems installing it on machines wuth only penlp installed. -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 Your team OpenLP Core is subscribed to branch lp:openlp. ___

[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/packaging into lp:openlp. Requested reviews: Tim Bentley (trb143) For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63405 Fixed traceback error that occurs in windows-builder.py if the bzr version info co

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63403 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-06-03 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/packaging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/63403 Fixed traceback error that occurs in windows-builder.py if the bzr version inf

[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-05-13 Thread noreply
The proposal to merge lp:~smpettit/openlp/packaging into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/60909 -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/60909 Your team OpenL

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-05-13 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/60909 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-05-13 Thread Raoul Snyman
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/packaging/+merge/60909 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-05-13 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/packaging into lp:openlp. Requested reviews: Raoul Snyman (raoul-snyman) For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/60909 windows-builder.py - Changes to support the documentation trunk and produce

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-05-13 Thread Raoul Snyman
Review: Needs Fixing The following lines have commas that need a space after them: 47 + u'..',u'documentation')) 68 + copy(os.path.join(helpfile_path,u'Openlp.chm'), 79 + print u'Deleting previous manual build...',manual_build_path -- https://code.launchpad.net/~smpettit/openlp/pa

[Openlp-core] [Merge] lp:~smpettit/openlp/packaging into lp:openlp

2011-05-12 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/packaging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/packaging/+merge/60855 windows-builder.py - Changes to support the documentation trunk and produce th

[Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-10 Thread noreply
The proposal to merge lp:~smpettit/openlp/Packaging into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60452 -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60452 Your team OpenL

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-10 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60452 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-09 Thread Tim Bentley
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60452 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-09 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/Packaging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) Related bugs: Bug #780020 in OpenLP: "installer doesn't pin openlp on windows 7" https://bugs.launchpad.net/openlp/+bug/780020 For more details, see: https://code.la

[Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-05 Thread noreply
The proposal to merge lp:~smpettit/openlp/Packaging into lp:openlp has been updated. Status: Needs review => Merged For more details, see: https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60063 -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60063 Your team OpenL

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-05 Thread Andreas Preikschat
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60063 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-05 Thread Jonathan Corwin
Review: Approve -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60063 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists.launchpad.net Unsubscrib

[Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-05 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/Packaging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/60063 Modified windows-builder.py to include qt_xx.qm files in ..\dist\OpenLP\i18n t

[Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-04 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/Packaging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/59972 Modified windows-builder.py to include qt_xx.qm files in ..\dist\OpenLP\i18n t

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-04 Thread Tim Bentley
Review: Needs Fixing You have merge conflicts in your tree. Update your local version from trunk and resubmit -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/59815 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-03 Thread Stevan Pettit
I made the changes as requested/suggested -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/59815 Your team OpenLP Core is subscribed to branch lp:openlp. ___ Mailing list: https://launchpad.net/~openlp-core Post to : openlp-core@lists

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-03 Thread Raoul Snyman
Review: Needs Fixing 19 + source = os.path.join(site_packages,u'PyQt4',u'translations') 24 + os.path.join(dist_path,u'i18n', filename)) You need spaces after your commas. 22 + if filename.startswith(u'qt_') and filename.endswith(u'.qm') and len(filename) == 8: This line is longer

Re: [Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-03 Thread Jonathan Corwin
Review: Needs Fixing Line 19 and 24 there should be a single space after the comma. Wouldn't it be less complex to use os.listdir instead of os.walk, since there aren't any subfolders to traverse? -- https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/59815 Your team OpenLP Core is subsc

[Openlp-core] [Merge] lp:~smpettit/openlp/Packaging into lp:openlp

2011-05-03 Thread Stevan Pettit
Stevan Pettit has proposed merging lp:~smpettit/openlp/Packaging into lp:openlp. Requested reviews: OpenLP Core (openlp-core) For more details, see: https://code.launchpad.net/~smpettit/openlp/Packaging/+merge/59815 Include qt_xx.qm files into the distribution directory ..\i18n . Multilingual