The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368843
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscri
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Adds basic streaming service item
UI to set up streaming
Fix issues with suffix refactor
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Adds basic streaming service item
UI to set up streaming
Fix issues with suffix refactor
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368842
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb143/
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscri
Review: Needs Fixing
Just one inconsistency with text labels (see inline) and the failed linting,
but other than that looks ok!
Diff comments:
>
> === modified file 'openlp/core/ui/media/mediatab.py'
> --- openlp/core/ui/media/mediatab.py 2019-05-04 19:47:06 +
> +++ openlp/core/ui/media/m
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/368841
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb143/
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Adds basic streaming service item
UI to set up streaming
Fix issues with suffix refactor
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366957
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Approve
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366957
Your team OpenLP Core is subscribed to branch lp:openlp.
___
Mailing list: https://launchpad.net/~openlp-core
Post to : openlp-core@lists.launchpad.net
Unsubscri
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Media plays successfully and cleanups.
Added VLC additions
Requested reviews:
Tomas Groth (tomasgroth)
Raoul Snyman (raoul-snyman)
For more details, see:
https://code.launchpad.net/~trb143/openlp/m
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Review: Needs Fixing
I tried running the branch on a windows system which I then realized didn't
have VLC. But it resulted in this traceback: https://bin.snyman.info/mmmvuquw
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608
Your team OpenLP Core is subscribed to branch lp:op
Review: Needs Fixing
Looks good.
One thing I would prefer to change though, is "VLC additions" aka "VLC
additional commands". They are not commands, they are command line arguments,
so I would call them "VLC arguments". In my opinion, "additions" is ambiguous
and unclear.
--
https://code.laun
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Media plays successfully and cleanups.
Added VLC additions
Requested reviews:
Tomas Groth (tomasgroth)
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366608
Media
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336
--
Your team OpenLP Core is subscribed to branch lp:openlp.
_
Prints are there as the code just explodes on my machine and shuts OpenLP down.
No worth doing anything cute while it is this state! They never get called.
Happy to move flag.
--
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336
Your team OpenLP Core is subscribed to branch lp:o
Review: Needs Fixing
A few comments below. Will try to test on a few systems later.
Diff comments:
>
> === modified file 'openlp/core/ui/generaltab.py'
> --- openlp/core/ui/generaltab.py 2019-03-16 10:20:46 +
> +++ openlp/core/ui/generaltab.py 2019-04-21 12:51:38 +
> @@ -113,6
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Media plays successfully and cleanups.
Added VLC additions
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366336
Medi
The proposal to merge lp:~trb143/openlp/more_media into lp:openlp has been
updated.
Status: Needs review => Superseded
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366335
--
Your team OpenLP Core is requested to review the proposed merge of
lp:~trb143/
Tim Bentley has proposed merging lp:~trb143/openlp/more_media into lp:openlp.
Commit message:
Media plays successfully and cleanups.
Added VLC additions
Requested reviews:
OpenLP Core (openlp-core)
For more details, see:
https://code.launchpad.net/~trb143/openlp/more_media/+merge/366335
Medi
22 matches
Mail list logo
