Re: [ovs-dev] ITS Helpdesk / RESET wachtwoord

2016-12-18 Thread Paula Francisca Varas Munoz
From: Paula Francisca Varas Munoz Sent: Sunday, December 18, 2016 11:38 PM Subject: ITS Helpdesk / RESET wachtwoord Uw huidige wachtwoord vervalt in de komende 24 uur, bent u hier op gericht om vriendelijk op ITS Helpdesk / RESET wachtwoord om uw wac

Re: [ovs-dev] [PATCH v3 14/16] ovn-controller: Rename all_lports to local_lports.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > This sset has always just contained the names of logical ports that are > local to the current hypervisor, but the name 'all_lports' implied that it > contained the name of every logical port. > > Signed-off-by: Ben Pfaff > Acked-by: Mickey S

Re: [ovs-dev] [PATCH v3 13/16] ovn-controller: Drop most uses of OVS patch ports.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > Until now, ovn-controller has implemented OVN logical patch ports and > l3gateway ports in terms of OVS patch ports. It is a hassle to create and > destroy ports, and it is also wasteful compared to what the patch ports > actually buy us: the

Re: [ovs-dev] [PATCH v3 12/16] ovn-controller: Avoid code duplication getting chassis record.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel --- > ovn/controller/binding.c| 26 ++ > ovn/controller/binding.h| 6 +++--- > ovn/controller/chassis.c| 12 +++- > ovn/controller

Re: [ovs-dev] [PATCH v3 11/16] pnysical: Factor code out of consider_port_binding().

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > These functions will have an additional user in an upcoming commit. > > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel --- > ovn/controller/physical.c | 227 +++--- > > 1 file changed, 134 inse

[ovs-dev] does ovs have plan or idea to integrate with vpn and loadbalance?

2016-12-18 Thread lg.yue
does ovs have plan or idea to integrate with pn and loadbalance? thanks ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/listinfo/ovs-dev

Re: [ovs-dev] [PATCH v3 10/16] ovn-controller: Handle only relevant ports and flows.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > On a particular hypervisor, ovn-controller only needs to handle ports > and datapaths that have some relationship with it, that is, the > ports that actually reside on the hypervisor, plus all the other ports on > those ports' datapaths, plus a

Re: [ovs-dev] [PATCH v3 09/16] lport: Add index for logical datapaths.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > This will have its first real user in an upcoming commit. > > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel --- > ovn/controller/lport.c | 62 ++ > +++ > ovn/controller/lport.h |

Re: [ovs-dev] [PATCH v3 08/16] lport: Tolerate null pointers in destroy functions.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > The coding style says to do this. > > The actual caller doesn't pass a null pointer. > > Signed-off-by: Ben Pfaff Acked-by: Mickey Spiegel --- > ovn/controller/lport.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/ovn/c

Re: [ovs-dev] [PATCH v3 07/16] lport: Be a little more careful building lport index.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > It seems like a good idea to check for and warn about all kinds of > duplicates, and to avoid segfaulting if a datapath column is empty. > (However, the database schema should prevent both issues.) > > Signed-off-by: Ben Pfaff Acked-by: Mick

Re: [ovs-dev] [PATCH v3 06/16] ovn-controller: Make indexes more broadly available.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > This will allow binding_run() to use them in an upcoming commit. > > Signed-off-by: Ben Pfaff Acked-by: Mickey Spiegel --- > ovn/controller/ovn-controller.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff -

Re: [ovs-dev] [PATCH v3 02/16] ovsdb-idl: Drop write-only member from struct ovsdb_idl_condition.

2016-12-18 Thread Mickey Spiegel
On Sun, Dec 18, 2016 at 12:18 AM, Ben Pfaff wrote: > The 'tc' member of struct ovsdb_idl_condition was written but never read, > so remove it. > > Signed-off-by: Ben Pfaff > Acked-by: Mickey Spiegel --- > lib/ovsdb-idl-provider.h | 1 - > lib/ovsdb-idl.c | 9 +++-- > 2 files chan

[ovs-dev] Sync on PTAP, EXT-382 and NSH

2016-12-18 Thread Jan Scheurich
Hello all, I would like to call for a final sync meeting before the Christmas break. Now that we have gone through the main aspects of the design, I would like to focus on how to divide the entire function into manageable pieces, discuss the potential work split, an integration anatomy and a ro

Re: [ovs-dev] [PATCH v2 00/11] ovn: get rid of most uses of patch ports

2016-12-18 Thread Ben Pfaff
On Fri, Dec 16, 2016 at 02:25:26PM -0800, Ben Pfaff wrote: > At least a v3 will be forthcoming to incorporate Darrell and Liran's > "datapaths of interest" concept, but I said yesterday that I'd send a > revised version before v3 is ready. > > v1->v2: >- Fixed some bugs reported by Mickey thro

[ovs-dev] [PATCH v3 15/16] ovsdb-idl: Change interface to conditional monitoring.

2016-12-18 Thread Ben Pfaff
Most users of OVSDB react to whatever is currently in their view of the database, as opposed to keeping track of changes and reacting to those changes individually. The interface to conditional monitoring was different, in that it expected the client to say what to add or remove from monitoring in

[ovs-dev] [PATCH v3 16/16] ovn-controller: Monitor only necessary southbound rows.

2016-12-18 Thread Ben Pfaff
Until now, ovn-controller has replicated all of the southbound database (through the IDL). This is inefficient, especially in a large OVN setup where many logical networks are not present on an individual hypervisor. This commit improves on the situation somewhat, by making ovn-controller replicat

[ovs-dev] [PATCH v3 13/16] ovn-controller: Drop most uses of OVS patch ports.

2016-12-18 Thread Ben Pfaff
Until now, ovn-controller has implemented OVN logical patch ports and l3gateway ports in terms of OVS patch ports. It is a hassle to create and destroy ports, and it is also wasteful compared to what the patch ports actually buy us: the ability to "save and restore" a packet around a recursive tri

[ovs-dev] [PATCH v3 14/16] ovn-controller: Rename all_lports to local_lports.

2016-12-18 Thread Ben Pfaff
This sset has always just contained the names of logical ports that are local to the current hypervisor, but the name 'all_lports' implied that it contained the name of every logical port. Signed-off-by: Ben Pfaff --- ovn/controller/binding.c| 25 + ovn/controller

[ovs-dev] [PATCH v3 12/16] ovn-controller: Avoid code duplication getting chassis record.

2016-12-18 Thread Ben Pfaff
Signed-off-by: Ben Pfaff --- ovn/controller/binding.c| 26 ++ ovn/controller/binding.h| 6 +++--- ovn/controller/chassis.c| 12 +++- ovn/controller/chassis.h| 3 ++- ovn/controller/ovn-controller.c | 8 +--- 5 files changed, 2

[ovs-dev] [PATCH v3 10/16] ovn-controller: Handle only relevant ports and flows.

2016-12-18 Thread Ben Pfaff
On a particular hypervisor, ovn-controller only needs to handle ports and datapaths that have some relationship with it, that is, the ports that actually reside on the hypervisor, plus all the other ports on those ports' datapaths, plus all of the ports and datapaths that are reachable from those v

[ovs-dev] [PATCH v3 11/16] pnysical: Factor code out of consider_port_binding().

2016-12-18 Thread Ben Pfaff
These functions will have an additional user in an upcoming commit. Signed-off-by: Ben Pfaff --- ovn/controller/physical.c | 227 +++--- 1 file changed, 134 insertions(+), 93 deletions(-) diff --git a/ovn/controller/physical.c b/ovn/controller/physical.c

[ovs-dev] [PATCH v3 09/16] lport: Add index for logical datapaths.

2016-12-18 Thread Ben Pfaff
This will have its first real user in an upcoming commit. Signed-off-by: Ben Pfaff --- ovn/controller/lport.c | 62 + ovn/controller/lport.h | 33 -- ovn/controller/ovn-controller.c | 4 +++ 3 files changed, 97 insert

[ovs-dev] [PATCH v3 08/16] lport: Tolerate null pointers in destroy functions.

2016-12-18 Thread Ben Pfaff
The coding style says to do this. The actual caller doesn't pass a null pointer. Signed-off-by: Ben Pfaff --- ovn/controller/lport.c | 8 1 file changed, 8 insertions(+) diff --git a/ovn/controller/lport.c b/ovn/controller/lport.c index 3484c2c..38aca22 100644 --- a/ovn/controller/lpo

[ovs-dev] [PATCH v3 07/16] lport: Be a little more careful building lport index.

2016-12-18 Thread Ben Pfaff
It seems like a good idea to check for and warn about all kinds of duplicates, and to avoid segfaulting if a datapath column is empty. (However, the database schema should prevent both issues.) Signed-off-by: Ben Pfaff --- ovn/controller/lport.c | 12 1 file changed, 12 insertions(+

[ovs-dev] [PATCH v3 06/16] ovn-controller: Make indexes more broadly available.

2016-12-18 Thread Ben Pfaff
This will allow binding_run() to use them in an upcoming commit. Signed-off-by: Ben Pfaff --- ovn/controller/ovn-controller.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 8ba98bd..efbd02

[ovs-dev] [PATCH v3 05/16] ofp-actions: Add clone action.

2016-12-18 Thread Ben Pfaff
From: William Tu This patch adds OpenFlow clone action with syntax as below: "clone([action][,action...])". The clone() action makes a copy of the current packet and executes the list of actions against the packet, without affecting the packet after the "clone(...)" action. In other word, the p

[ovs-dev] [PATCH v3 04/16] ofp-actions: Move function for struct ofpact_nest near struct definition.

2016-12-18 Thread Ben Pfaff
This seems like a logical place for it. Signed-off-by: Ben Pfaff --- include/openvswitch/ofp-actions.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/openvswitch/ofp-actions.h b/include/openvswitch/ofp-actions.h index 946beaf..ecafbea 100644 --- a/inclu

[ovs-dev] [PATCH v3 03/16] ofp-actions: Use struct ext_action_header for appropriate actions.

2016-12-18 Thread Ben Pfaff
A few Open vSwitch extension actions have no fixed arguments but do have variable-length options that follow the header, and an upcoming commit will add another such action. There is little value in having individual structures for these actions, since they all have the same form, so this commit m

[ovs-dev] [PATCH v3 01/16] ovn-controller: Don't enable IDL tracking.

2016-12-18 Thread Ben Pfaff
IDL tracking has a cost and nothing in ovn-controller was getting any value for that cost, so diable it. Signed-off-by: Ben Pfaff --- ovn/controller/ovn-controller.c | 5 - 1 file changed, 5 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-controller.c index 4f

[ovs-dev] [PATCH v3 02/16] ovsdb-idl: Drop write-only member from struct ovsdb_idl_condition.

2016-12-18 Thread Ben Pfaff
The 'tc' member of struct ovsdb_idl_condition was written but never read, so remove it. Signed-off-by: Ben Pfaff --- lib/ovsdb-idl-provider.h | 1 - lib/ovsdb-idl.c | 9 +++-- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/lib/ovsdb-idl-provider.h b/lib/ovsdb-idl-pro

[ovs-dev] [PATCH v3 00/16] ovn: get rid of most uses of patch ports

2016-12-18 Thread Ben Pfaff
v1->v2: - Fixed some bugs reported by Mickey throughout the series. - Patches 1 and 2 are new. - Patch 3 is modified in various ways, most notably to avoid using the datapath "sample" action, to add a test, and to better conform to style in a few small ways. v2->v3: - Patch 5 is

Re: [ovs-dev] [PATCH v2 03/11] ofp-actions: Add clone action.

2016-12-18 Thread Ben Pfaff
On Sat, Dec 17, 2016 at 08:19:34AM -0800, William Tu wrote: > Thanks for the patch, I have some comments. > > > +static char * OVS_WARN_UNUSED_RESULT > > +parse_CLONE(char *arg, struct ofpbuf *ofpacts, > > + enum ofputil_protocol *usable_protocols) > > +{ > > + > > +const size_t ct