How about:
struct ovsdb_idl_table {
...
const struct ovsdb_idl_table_class *table_class
}
struct ovsdb_idl {
const struct ovsdb_idl_class *idl_class;
Besides of that, I see many places consume the table class.
Do you mind to make a macro helps to fetch the class?
Like:
#d
I see, for flows in phy-phy setup, they should not be calculate cksum.
I will revise my patch to do the cksum for vhost port only. I will send a
new patch next week.
Thanks
Zhenyu Gao
2017-08-08 17:53 GMT+08:00 Loftus, Ciara :
> >
> > Hi Loftus,
> >
> > Thanks for testing and the comments!
> > C
How about mutable --> is_mutable ?
Thanks
Zhenyu Gao
2017-08-10 6:27 GMT+08:00 Joe Stringer :
> In C++, 'mutable' is a keyword. If this is used as the name for a field,
> then C++ compilers can get confused about the context and fail to
> compile references to such fields. Rename the field to '
why not remove the function of route_table_link_del to name_table_change() ?
On Wed, Aug 9, 2017 at 3:41 PM, fukaige wrote:
> From: Kaige Fu
>
> Start a virtual machine with its backend tap device attached to a brought up
> linux bridge.
> If we delete the linux bridge when vm is still running,
On 08/09/2017 08:47 AM, Kevin Traynor wrote:
On 08/08/2017 07:15 PM, Greg Rose wrote:
> On 08/01/2017 08:58 AM, Kevin Traynor wrote:
>> Previously rxqs were assigned to pmds by round robin in
>> port/queue order.
>>
>> Now that we have the processing cycles used for existing rxqs,
>> use that inf
Hi Ben,
Thanks for your response!
I have reported this to b...@openvswitch.org.
Below is what I have shared to b...@openvswitch.org.
Issue summary:
--
On setting, "ovsdb-server/set-sync-exclude-tables" for certain tables,
ovsdb-server replication does not work.
i.e the ovsdb-server
Previously, netdev_ports_insert() would allocate and insert an
ifindex->odp_port mapping, but netdev_ports_remove() would never remove
the mapping or free the mapping structure. This patch fixes these up.
Fixes: 32b77c316d9982("dpif: Save added ports in a port map.")
Reported-by: Andy Zhou
Signed
On 9 August 2017 at 13:59, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:37:52PM -0700, Joe Stringer wrote:
>> The style guide states that lines should not end with '?' or ':'. Check
>> for this and report an error.
>>
>> Signed-off-by: Joe Stringer
>
> The comment should be updated since the sty
On 9 August 2017 at 13:58, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:37:51PM -0700, Joe Stringer wrote:
>> Most of the prerequisite checks so far matched on filenames that ended
>> in some character followed by 'c' or 'h', rather than a filename that
>> ends in '.c' or '.h'. Fix this.
>>
>> Si
On 9 August 2017 at 13:58, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:37:50PM -0700, Joe Stringer wrote:
>> The 'Expressions' section of the coding style specifies that one space
>> should be on either side of infix binary and ternary operators. This
>> adds a check to checkpatch.py for most of
On 9 August 2017 at 13:46, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 01:38:05PM -0700, Joe Stringer wrote:
>> Signed-off-by: Joe Stringer
>
> For all three patches:
> Acked-by: Ben Pfaff
Thanks, applied to master.
___
dev mailing list
d...@openvswitc
En línea y en Vivo / Para todo su Equipo con una sola Conexión
Conviértase en un Excelente Líder - técnicas y Consejos
25 de Agosto - Online en Vivo - 10:00 a 13:00 y de 15:00 a 18:00Hrs
Aprenda a manejar con habilidad las metas y objetivos de su área y conducir a
su personal al logro
On 8 August 2017 at 18:16, Andy Zhou wrote:
> On Tue, Aug 8, 2017 at 5:10 PM, Joe Stringer wrote:
>> Previously, netdev_ports_insert() would allocate and insert an
>> ifindex->odp_port mapping, but netdev_ports_remove() would never remove
>> the mapping or free the mapping structure. This patch f
On 8 August 2017 at 18:33, Andy Zhou wrote:
> On Tue, Aug 8, 2017 at 5:10 PM, Joe Stringer wrote:
>> Commit 32b77c316d9982("dpif: Save added ports in a port map.")
>> introduced tracking of all dpif ports by taking a reference on each
>> available netdev when the dpif is opened, but it failed to
struct ovs_action_encap_nsh is the only one way we transfer all the data for
encap_nsh, netlink allows variable attribute, so I don't think we break netlink
convention or abuse this variable feature.
Even if we bring nested attributes to handle this, OVS_ACTION_ATTR_ENCAP_NSH is
still length-va
Now that the 'new' datum is named 'new_datum', be more consistent by
renaming 'old' to 'old_datum' to match.
Signed-off-by: Joe Stringer
---
v2: New patch.
---
lib/ovsdb-data.h | 4 +--
lib/ovsdb-idl-provider.h | 22 +++---
lib/ovsdb-idl.c | 74 +
In C++, 'new' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'new_datum' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v2: Rebase.
Rename 'new_' to 'new_datu
In C++, 'mutable' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'mutable_' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v2: Rebase.
---
lib/ovsdb-idl-provider
In C++, 'class' is a keyword. If this is used as the name for a field,
then C++ compilers can get confused about the context and fail to
compile references to such fields. Rename the field to 'class_' to
avoid this issue.
Signed-off-by: Joe Stringer
---
v2: Rebase.
---
lib/db-ctl-base.c|
In the OVSDB IDL, we use C++ keywords such as "new", "mutable", "class"
for variable and field names. This series adds an underscore after each
usage of these names, to improve the ability to use the IDL from C++ code.
This series focuses primarily on code that exists in the tree; To
address such p
-Original Message-
From: Aaron Conole
Date: Wednesday, August 9, 2017 at 12:51 PM
To: Darrell Ball
Cc: Joe Stringer , Darrell Ball , ovs dev
Subject: Re: [ovs-dev] [patch_v4] dp-packet: Reset DPDK HWOL checksum flags on
init.
Darrell Ball writes:
> Thanks Joe
> I f
> From: "Ben Pfaff"
> To: "Lance Richardson"
> Cc: d...@openvswitch.org
> Sent: Wednesday, August 9, 2017 4:47:49 PM
> Subject: Re: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse
> build.
>
> On Wed, Aug 09, 2017 at 04:36:42PM -0400, Lance Richardson wrote:
> > > From: "Ben Pf
On Wed, Aug 09, 2017 at 01:37:52PM -0700, Joe Stringer wrote:
> The style guide states that lines should not end with '?' or ':'. Check
> for this and report an error.
>
> Signed-off-by: Joe Stringer
The comment should be updated since the style considers && at the end of
a line to be OK:
> +
On Wed, Aug 09, 2017 at 01:37:51PM -0700, Joe Stringer wrote:
> Most of the prerequisite checks so far matched on filenames that ended
> in some character followed by 'c' or 'h', rather than a filename that
> ends in '.c' or '.h'. Fix this.
>
> Signed-off-by: Joe Stringer
Acked-by: Ben Pfaff
__
On Wed, Aug 09, 2017 at 01:37:50PM -0700, Joe Stringer wrote:
> The 'Expressions' section of the coding style specifies that one space
> should be on either side of infix binary and ternary operators. This
> adds a check to checkpatch.py for most of these.
>
> The regex won't match if there are sp
On Wed, Aug 09, 2017 at 08:12:36PM +, Yang, Yi Y wrote:
> Ben, do you mean we bring two new attributes (OVS_NSH_ATTR_MD1 and
> OVS_NSH_ATTR_MD2) and embed one of them in OVS_ACTION_ATTR_ENCAP_NSH?
Yes.
> Anyway we need to use a struct or something else to transfer those
> metadata between fun
On Wed, Aug 09, 2017 at 04:36:42PM -0400, Lance Richardson wrote:
> > From: "Ben Pfaff"
> > To: d...@openvswitch.org
> > Cc: "Ben Pfaff"
> > Sent: Thursday, July 27, 2017 4:41:05 PM
> > Subject: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse
> > build.
> >
> > Newer travis e
On Wed, Aug 09, 2017 at 01:38:05PM -0700, Joe Stringer wrote:
> Signed-off-by: Joe Stringer
For all three patches:
Acked-by: Ben Pfaff
___
dev mailing list
d...@openvswitch.org
https://mail.openvswitch.org/mailman/listinfo/ovs-dev
-Original Message-
From: "Chandran, Sugesh"
Date: Wednesday, August 9, 2017 at 12:55 PM
To: Darrell Ball , Ben Pfaff
Cc: "d...@openvswitch.org"
Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on
init.
Regards
_Sugesh
> >
Signed-off-by: Joe Stringer
---
ovn/northd/ovn-northd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ovn/northd/ovn-northd.c b/ovn/northd/ovn-northd.c
index 99d15a7a56c4..49e4ac3383d3 100644
--- a/ovn/northd/ovn-northd.c
+++ b/ovn/northd/ovn-northd.c
@@ -1886,7 +1886,7 @@ o
Signed-off-by: Joe Stringer
---
ofproto/ofproto-dpif-ipfix.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ofproto/ofproto-dpif-ipfix.c b/ofproto/ofproto-dpif-ipfix.c
index fcba02e45b75..472c27281d5f 100644
--- a/ofproto/ofproto-dpif-ipfix.c
+++ b/ofproto/ofproto-dpif-ipfix.
Signed-off-by: Joe Stringer
---
lib/netdev-dummy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/netdev-dummy.c b/lib/netdev-dummy.c
index 62ddd0c67834..f731af1dfd0e 100644
--- a/lib/netdev-dummy.c
+++ b/lib/netdev-dummy.c
@@ -1574,7 +1574,7 @@ netdev_dummy_receive(struc
The style guide states that lines should not end with '?' or ':'. Check
for this and report an error.
Signed-off-by: Joe Stringer
---
v2: Restrict to '?' and ':'.
Make sure that goto tags aren't flagged.
---
utilities/checkpatch.py | 14 +-
1 file changed, 13 insertions(+), 1 del
Most of the prerequisite checks so far matched on filenames that ended
in some character followed by 'c' or 'h', rather than a filename that
ends in '.c' or '.h'. Fix this.
Signed-off-by: Joe Stringer
---
utilities/checkpatch.py | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff
The 'Expressions' section of the coding style specifies that one space
should be on either side of infix binary and ternary operators. This
adds a check to checkpatch.py for most of these.
The regex won't match if there are speech marks on the line, because
the style should not apply to the conten
This commit builds on the non-root ovs work and adds a udev rule which will
automatically set the group permissions of vfio devices.
Signed-off-by: Aaron Conole
---
Systemd folks say that this is not something that should be a part of systemd,
but should be part of openvswitch. I can make a case
> From: "Ben Pfaff"
> To: d...@openvswitch.org
> Cc: "Ben Pfaff"
> Sent: Thursday, July 27, 2017 4:41:05 PM
> Subject: [ovs-dev] [PATCH 1/2] travis: Explicitly disable LLVM for sparse
> build.
>
> Newer travis environments claim to have LLVM support (llvm-config exists
> and works) but in r
On 9 August 2017 at 12:51, Aaron Conole wrote:
> Darrell Ball writes:
>
>> Thanks Joe
>> I forgot to add your Tested-by to V5; I have been testing this myself;
>> but let me know if you would like it added – I can send a V6.
>
> It will automatically be added by patchwork. It is sufficient to
>
Hi,
I was curious to know if you would be interested in AdvancedMD Users List
2017?
Let me know your target criteria and we will revert back to you with further
details.
Target Users:
Geography:
Looking forward to continued success with you.
Regards,
Kristina Jones | Marketing
On Aug 10, 2017 12:06 AM, "Ben Pfaff" wrote:
On Fri, Aug 04, 2017 at 04:09:58PM +0530, Numan Siddique wrote:
> On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote:
>
> > On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > This patch adds a new
Noticed, please check the reply for that one.
-Original Message-
From: Ben Pfaff [mailto:b...@ovn.org]
Sent: Thursday, August 10, 2017 4:04 AM
To: Yang, Yi Y
Cc: d...@openvswitch.org
Subject: Re: [PATCH v1 1/2] nsh: enable struct ovs_action_encap_nsh to support
variable length
I gave a
Ben, do you mean we bring two new attributes (OVS_NSH_ATTR_MD1 and
OVS_NSH_ATTR_MD2) and embed one of them in OVS_ACTION_ATTR_ENCAP_NSH? Anyway we
need to use a struct or something else to transfer those metadata between
functions, how do you think we can handle this without metadata in struct
On Wed, Aug 9, 2017 at 3:38 PM, Lance Richardson wrote:
> Ensure that JSON is utf-8 encoded and that bytes sent/received on
> the stream sockets are in utf-8 form. Add a test case to verify
> that unicode data can be sent/received successfully using Python
> IDL module.
>
> Co-authored-by: Terry W
On Mon, Aug 07, 2017 at 01:27:37PM -0700, Andy Zhou wrote:
> On Mon, Jun 5, 2017 at 6:04 PM, Ben Pfaff wrote:
> > OVS has common infrastructure functions for getting the current time, but
> > this code was not using them. It is not clear why, so this commit changes
> > it to use them.
> >
> > Sig
I gave a more detailed explanation later:
https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337164.html
On Wed, Aug 09, 2017 at 07:52:38PM +, Yang, Yi Y wrote:
> Ben, no matter it is MD type 1 or MD type 2, we use the same netlink
> attribute OVS_ACTION_ATTR_ENCAP_NSH to transfer the
As part of a devargs rework in DPDK, the PCI header file was removed, and
needs to be directly included. This isn't required to build with 17.05 or
earlier, but will be required should a future update happen.
Signed-off-by: Aaron Conole
---
lib/netdev-dpdk.c | 1 +
1 file changed, 1 insertion(+
On Tue, Aug 08, 2017 at 02:55:05PM +0800, Yi Yang wrote:
> commit 3d2fbd70bda514f7327970b859663f34f994290c brought
> duplicate description about Experimenter classes
> ONFOXM_ET and NXOXM_NSH in lib/meta-flow.xml, branch-2.8
> has the same issue.
>
> Signed-off-by: Yi Yang
Thanks, applied to mas
On Wed, Aug 09, 2017 at 03:42:05PM -0400, Russell Bryant wrote:
> It looked OK for me other than how it made my terminal crash when I
> tried to view it. :-)
It sounds like you should report a bug to the terminal emulator
maintainers. Output shouldn't be able to crash a terminal.
___
On Tue, Aug 08, 2017 at 05:03:10PM +0300, Roi Dayan wrote:
> Hi,
>
> The first patch is to avoid false errors about getting ifindex
> as the device might disappear already.
> The second patch is a fix for dumping vxlan rules with ovs-dpctl.
Thanks for the fixing. I applied these patches to maste
Regards
_Sugesh
> > >
> > > Correct, I reused reset_dp_packet_checksum_ol_flags() to do the
> > initialization as well
> > > I could also have created a separate function.
> > >
> > > In case a DPDK dev is used, those flags will be managed by DPDK.
>
Ben, no matter it is MD type 1 or MD type 2, we use the same netlink attribute
OVS_ACTION_ATTR_ENCAP_NSH to transfer these data, another netlink attribute
OVS_KEY_ATTR_NSH is for struct ovs_key_nsh. So I can't catch your point, can
you explain it more?
-Original Message-
From: Ben Pfaff
Darrell Ball writes:
> Thanks Joe
> I forgot to add your Tested-by to V5; I have been testing this myself;
> but let me know if you would like it added – I can send a V6.
It will automatically be added by patchwork. It is sufficient to
download (ex: https://patchwork.ozlabs.org/patch/799499/mbo
On 8 August 2017 at 19:10, Darrell Ball wrote:
> Thanks Joe
> I forgot to add your Tested-by to V5; I have been testing this myself; but
> let me know if you would like it added – I can send a V6.
No worries, it looks like you'll resubmit with a slightly different
approach so feel free to drop t
> From: "Russell Bryant"
> To: "Ben Pfaff"
> Cc: "Lance Richardson" , "ovs dev"
> Sent: Wednesday, August 9, 2017 3:42:05 PM
> Subject: Re: [ovs-dev] [PATCH] python: make python idl unicode-tolerant
>
> On Wed, Aug 9, 2017 at 3:32 PM, Ben Pfaff wrote:
> > On Wed, Aug 09, 2017 at 03:27:32PM -04
On Wed, Aug 9, 2017 at 3:32 PM, Ben Pfaff wrote:
> On Wed, Aug 09, 2017 at 03:27:32PM -0400, Russell Bryant wrote:
>> On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote:
>> > Ensure that JSON is utf-8 encoded and that bytes sent/received on
>> > the stream sockets are in utf-8 form. Add a tes
Ensure that JSON is utf-8 encoded and that bytes sent/received on
the stream sockets are in utf-8 form. Add a test case to verify
that unicode data can be sent/received successfully using Python
IDL module.
Co-authored-by: Terry Wilson
Signed-off-by: Terry Wilson
Signed-off-by: Lance Richardson
On Wed, Aug 09, 2017 at 03:27:32PM -0400, Russell Bryant wrote:
> On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote:
> > Ensure that JSON is utf-8 encoded and that bytes sent/received on
> > the stream sockets are in utf-8 form. Add a test case to verify
> > that unicode column data can be se
On Tue, Aug 8, 2017 at 2:44 PM, Lance Richardson wrote:
> Ensure that JSON is utf-8 encoded and that bytes sent/received on
> the stream sockets are in utf-8 form. Add a test case to verify
> that unicode column data can be sent/received successfully using
> Python module.
>
> JSON encoder magic t
On Wed, Aug 9, 2017 at 1:29 PM, Ben Pfaff wrote:
> On Tue, Aug 01, 2017 at 12:19:18PM -0400, Russell Bryant wrote:
>> Add native support for active-standby HA in ovn-northd by having each
>> instance attempt to acquire an OVSDB lock. Only the instance of
>> ovn-northd that currently holds the loc
-Original Message-
From: "Chandran, Sugesh"
Date: Wednesday, August 9, 2017 at 11:17 AM
To: Darrell Ball , Ben Pfaff
Cc: "d...@openvswitch.org"
Subject: RE: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on
init.
Hi Darrel,
I reviewed and tested the patch
On Fri, Aug 04, 2017 at 09:54:26AM -0400, Lance Richardson wrote:
> > From: "Ben Pfaff"
> > To: d...@openvswitch.org
> > Cc: "Ben Pfaff" , "Stuart Cardall"
> >
> > Sent: Friday, 14 July, 2017 12:42:54 AM
> > Subject: [ovs-dev] [PATCH] ovs-vsctl-bashcomp: Make compatible with busybox
> > "awk".
Hello,
We are students trying to extend OVS in the Linux environment for our
research works. We have primitive understandings of OVS after reading the
documents. However, we are uncertain whether we are on the adequate
track. The new features of our design and our speculated starting points
are
Hi Darrel,
I reviewed and tested the patch.
It does fixed the UT failures in --with-dpdk case.
One comment below.
Regards
_Sugesh
> -Original Message-
> From: ovs-dev-boun...@openvswitch.org [mailto:ovs-dev-
> boun...@openvswitch.org] On Behalf Of Darrell Ball
> Sent: Wednesday, August
On Fri, Aug 04, 2017 at 04:09:58PM +0530, Numan Siddique wrote:
> On Fri, Aug 4, 2017 at 3:02 AM, Ben Pfaff wrote:
>
> > On Mon, Jul 31, 2017 at 06:11:35PM +0530, nusid...@redhat.com wrote:
> > > From: Numan Siddique
> > >
> > > This patch adds a new OVN action 'put_nd_ra_opts' to support native
Hmm, it was the first time I'd used the internal system tester so I must have
invoked it improperly. I'll fix these issues and send out a v2.
Thanks,
--Justin
> On Aug 8, 2017, at 6:02 PM, Darrell Ball wrote:
>
> I just did a second round
>
> One correction for first round 73 should have b
Thanks, applied to master.
On Wed, Aug 09, 2017 at 06:09:12PM +, Darrell Ball wrote:
> Acked-by: Darrell Ball
>
> -Original Message-
> From: on behalf of Ben Pfaff
> Date: Wednesday, August 9, 2017 at 10:43 AM
> To: "d...@openvswitch.org"
> Cc: Ben Pfaff
> Subject: [ovs-dev] [PAT
On Wed, Aug 09, 2017 at 09:41:51AM +, Yang, Yi Y wrote:
> Hi, Jan
>
> I have worked out a patch, will send it quickly for Ben. In addition, I also
> will send out a patch to change encap_nsh &decap_nsh to push_nsh and pop_nsh.
> Per comments from all the people, we all agreed to do so :-)
>
Acked-by: Darrell Ball
-Original Message-
From: on behalf of Ben Pfaff
Date: Wednesday, August 9, 2017 at 10:43 AM
To: "d...@openvswitch.org"
Cc: Ben Pfaff
Subject: [ovs-dev] [PATCH] dp-packet: Use OVS_UNUSED to mark possibly unused
parameters.
This is the way usually used in
On Wed, Aug 09, 2017 at 07:45:13PM +0800, Yi Yang wrote:
> In order to adapt to MD type 1 and MD type 2 at the same
> time and avoid breaking Linux kernel uAPI later, we change
> struct ovs_action_encap_nsh to the below format.
>
> struct ovs_action_encap_nsh {
> uint8_t flags;
> uint8_t m
-Original Message-
From: Ben Pfaff
Date: Wednesday, August 9, 2017 at 10:40 AM
To: Darrell Ball
Cc: Darrell Ball , "d...@openvswitch.org"
Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on
init.
On Wed, Aug 09, 2017 at 05:32:02PM +, Darrell Ball w
This is the way usually used in OVS.
Signed-off-by: Ben Pfaff
---
lib/dp-packet.h | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/lib/dp-packet.h b/lib/dp-packet.h
index 9dbb611d95fb..8f52feeefa39 100644
--- a/lib/dp-packet.h
+++ b/lib/dp-packet.h
@@ -615,46
On Wed, Aug 09, 2017 at 05:32:02PM +, Darrell Ball wrote:
>
>
> -Original Message-
> From: on behalf of Ben Pfaff
> Date: Wednesday, August 9, 2017 at 10:15 AM
> To: Darrell Ball
> Cc: "d...@openvswitch.org"
> Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum f
-Original Message-
From: on behalf of Ben Pfaff
Date: Wednesday, August 9, 2017 at 10:15 AM
To: Darrell Ball
Cc: "d...@openvswitch.org"
Subject: Re: [ovs-dev] [patch_v5] dp-packet: Reset DPDK HWOL checksum flags on
init.
On Tue, Aug 08, 2017 at 06:54:46PM -0700, Darrell Ball wro
On Tue, Aug 01, 2017 at 12:19:18PM -0400, Russell Bryant wrote:
> Add native support for active-standby HA in ovn-northd by having each
> instance attempt to acquire an OVSDB lock. Only the instance of
> ovn-northd that currently holds the lock will make active changes to
> the OVN databases.
>
>
On Tue, Aug 08, 2017 at 06:54:46PM -0700, Darrell Ball wrote:
> Reset the DPDK HWOL checksum flags in dp_packet_init_.
> The new HWOL bad checksum flag is uninitialized for non-dpdk ports and
> this is noticed as test failures using netdev-dummy ports, when built with
> the --with-dpdk flag set. He
On Tue, Aug 08, 2017 at 11:57:36PM -0700, Darrell Ball wrote:
> The following error is seen:
> 17.05.1/build/build/lib/librte_eal/linuxapp/igb_uio/igb_uio.c:29:
> /home/travis/build/darball/ovs/linux-3.16.46/arch/x86/include/asm/
> dma-mapping.h:32:35: error: inlining failed in call to ‘get_dma_ops
On Wed, Aug 09, 2017 at 05:23:20PM +0800, Sam wrote:
> Hi all,
>
> I'm using autotest to test ovs, and I write a new *.at file using only one
> AT_CHECK sentence like this:
>
> AT_CHECK([ovs-appctl dpdk/bond-show dpdkb2], [0], [stdout])
> > AT_CHECK([[sed '/ACTIVE/p' stdout | head -4]], [0], [[LA
On Wed, Aug 09, 2017 at 05:34:16PM +0530, Arunkumar Rg wrote:
> Hi All,
>
> I need a clarification on ovsdb-server replication's
> set-sync-exclude-tables.
>
> *Is there a way, by which we can say exclude syncing specific column of a
> table??*
>
> The use case I'm looking at is:
>
>1. The
On 08/08/2017 07:15 PM, Greg Rose wrote:
> On 08/01/2017 08:58 AM, Kevin Traynor wrote:
>> Previously rxqs were assigned to pmds by round robin in
>> port/queue order.
>>
>> Now that we have the processing cycles used for existing rxqs,
>> use that information to try and produced a better balanced
Rxqs consumed processing cycles are used to improve the balance
of how rxqs are assigned to pmds. Currently some reconfiguration
is needed to perform a reassignment.
Add an ovs-appctl command to perform a new assignment in order
to balance based on the latest rxq processing cycle information.
Not
Up to his point rxqs are sorted by processing cycles they
consumed and assigned to pmds in a round robin manner.
Ian pointed out that on wrap around the most loaded pmd will be
the next one to be assigned an additional rxq and that it would be
better to reverse the pmd order when wraparound occurs
Previously rxqs were assigned to pmds by round robin in
port/queue order.
Now that we have the processing cycles used for existing rxqs,
use that information to try and produced a better balanced
distribution of rxqs across pmds. i.e. given multiple pmds, the
rxqs which have consumed the largest a
Count the cycles used for processing an rxq during the
pmd rxq interval. As this is an in flight counter and
pmds run independently, also store the total cycles used
during the last full interval.
Signed-off-by: Kevin Traynor
---
lib/dpif-netdev.c | 65 +++
Add two counters to dp_netdev_rxq which will be used for storing the
processing cycles of an rxq. Processing cycles will be stored in reference
to a defined interval. One counter is used for storing cycles during the
current in progress interval, while the other is used to store the cycles
of the l
Soon we will want to store processing cycle counts in the dp_netdev_rxq,
so use that as a basis for the polled_queue that pmd_thread_main uses.
Signed-off-by: Kevin Traynor
---
lib/dpif-netdev.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/dpif-netdev.c b/li
For the DPDK datapath, by default rxqs are assigned to available pmds
in round robin order with no weight or priority.
It can happen that some very busy queues are handled by one pmd which
does not have enough cycles to prevent packets being dropped on them.
While at the same time another pmd whic
> Maybe I don't fully understand what you're trying to say, but I want to use
> unsafe function in dpif-netdev for per-flow packet batching (see the patch)
> and it should not be internal for that case.
> (It's safe to use unsafe function there because per-flow batches are
> guaranteed to be less t
On 08.08.2017 21:36, Andy Zhou wrote:
> On Mon, Aug 7, 2017 at 11:01 PM, Ilya Maximets wrote:
>> On 07.08.2017 23:24, Andy Zhou wrote:
>>> On Mon, Aug 7, 2017 at 8:50 AM, Ilya Maximets
>>> wrote:
Almost all batch usecases covered by the new API introduced
in commit 72c84bc2db23 ("dp-pa
On Wed, Aug 9, 2017 at 5:01 AM, Miguel Angel Ajo Pelayo
wrote:
> Nice idea, I have btw some comments/thoughts/questions regarding this:
>
> 1) Does OVSDB have any heartbeat protocol? (to detect that one northd has
> died even during inactive periods).
Yes, it does. By deafult, both ends of an OV
On 09.08.2017 15:35, Bodireddy, Bhanuprakash wrote:
>>>
>>> +static int
>>> +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) {
>>> +struct dpdk_tx_queue *txq = &dev->tx_q[qid];
>>> +struct rte_mbuf **cur_pkts = (struct rte_mbuf
>>> +**)txq->vhost_burst_pkts;
>>> +
>>> +int
>enable)
if (enable) {
dev->tx_q[qid].map = qid;
>>
>> Here flushing required too because we're possibly enabling previously
>remapped queue.
>>
} else {
+/* If the queue is disabled in the guest, the
corresponding
On 09.08.2017 15:29, Bodireddy, Bhanuprakash wrote:
> Hi Ilya,
>>>
>>> +/* Flush tx queues.
>>> + * This is done periodically to empty the intermediate queue in case
>>> +of
>>> + * fewer packets (< INTERIM_QUEUE_BURST_THRESHOLD) buffered in the
>> queue.
>>> + */
>>> +static int
>>> +netdev_dpdk_t
Hi Ben,
As Miklos is on vacation, let me answer your questions.
The 'latest_nw_tos' variable is storing always the updated value of 'nw_tos'.
It is not always the same as 'flow->nw_tos'. E.g. in xlate_sample_action(),
'flow' pointer is declared just before calling tnl_port_send(). In case of MPL
>>
>> +static int
>> +netdev_dpdk_vhost_tx_burst(struct netdev_dpdk *dev, int qid) {
>> +struct dpdk_tx_queue *txq = &dev->tx_q[qid];
>> +struct rte_mbuf **cur_pkts = (struct rte_mbuf
>> +**)txq->vhost_burst_pkts;
>> +
>> +int tx_vid = netdev_dpdk_get_vid(dev);
>> +int tx_qid = qid
Hi Ilya,
>>
>> +/* Flush tx queues.
>> + * This is done periodically to empty the intermediate queue in case
>> +of
>> + * fewer packets (< INTERIM_QUEUE_BURST_THRESHOLD) buffered in the
>queue.
>> + */
>> +static int
>> +netdev_dpdk_txq_flush(struct netdev *netdev, int qid , bool
>> +concurrent_tx
[ View in browser ]( http://r.newsletter.bonescamail.nl/nru6rm8uoatrf.html
)
TYJ SPRING ROLL PASTRY SINGAPORE
Code - Description
8842 - 215 mm 40 leaves 20 x 500 gr
8843 - 250 mm 30 leaves 30 x 500 gr
1 Box € 1,75
10 Box € 1,65
Palet € 1,55 per pack!
This email was sent t
On 09.08.2017 13:03, Ilya Maximets wrote:
> One more comment inline.
>
> On 09.08.2017 11:06, Ilya Maximets wrote:
>> Not a full review.
>> One comment inline.
>>
>>> Add netdev_dpdk_vhost_txq_flush(), that flushes packets on vHost User
>>> port queues. Also add netdev_dpdk_vhost_tx_burst() functi
Hi All,
I need a clarification on ovsdb-server replication's
set-sync-exclude-tables.
*Is there a way, by which we can say exclude syncing specific column of a
table??*
The use case I'm looking at is:
1. The replication is configured for DB "hardware_vtep".
2. I'm trying to use the "ovsdb
Please ignore this one and use this series
https://mail.openvswitch.org/pipermail/ovs-dev/2017-August/337128.html which
includes this one.
-Original Message-
From: Yang, Yi Y
Sent: Wednesday, August 9, 2017 5:56 PM
To: d...@openvswitch.org
Cc: b...@ovn.org; Yang, Yi Y
Subject: [PATCH]
In order to adapt to MD type 1 and MD type 2 at the same
time and avoid breaking Linux kernel uAPI later, we change
struct ovs_action_encap_nsh to the below format.
struct ovs_action_encap_nsh {
uint8_t flags;
uint8_t mdtype;
uint8_t mdlen;
uint8_t np;
__be32 path_hdr;
uint
1 - 100 of 115 matches
Mail list logo