Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

Hi Ilya, I had a look at the patch that you have submitted. In push_tnl_action, I can see that with the patch you are trying to return error in case we don’t find the tunnel port or return the error that netdev_push header returns. And we are deciding to delete the batch in the calling functi

[ovs-dev] [PATCH v2 2/2] Add GTP-U unit test cases

From: Feng Yang This patch adds a basic GTP-U test case to tests/tunnel.at, GTP-U pop and push test cases to tests/tunnel-push-pop.at. Signed-off-by: Feng Yang Signed-off-by: Yi Yang --- tests/ofproto.at | 4 +++- tests/tunnel-push-pop.at | 19 +++ tests/tunnel.at

[ovs-dev] [PATCH v2 0/2] Add GTP-U tunnel support in DPDK userspace

v1 -> v2: - Add new packet_type PT_GTPU_MSG to handle GTP-U signaling message, GTP-U signaling message should be steered into a control plane handler by explicit openflow entry in flow table. - Fix gtpu_flags and gptu_msgtype set issue. - Verify communication with kernel GTP implement

[ovs-dev] [PATCH v2 1/2] userspace datapath: Add GTP-U tunnel support

From: Feng Yang GPRS Tunneling Protocol (GTP) is a group of IP-based communications protocols used to carry general packet radio service (GPRS) within GSM, UMTS and LTE networks. GTP can be decomposed into separate protocols, GTP-C, GTP-U and GTP'. GTP-U is used for carrying user data within th

Re: [ovs-dev] [PATCH v2] datapath: compat: Fix build on RHEL 7.5

On Fri, May 11, 2018 at 10:32 AM, Yi-Hung Wei wrote: > 1) OVS datapath compat modules breaks on RHEL 7.5, because it moves > ndo_change_mtu function pointer from 'struct net_device_ops' to > 'struct net_device_ops_extended'. > > 2) RHEL 7.5 introduces the MTU range checking as mentioned in > 6c0bf

Re: [ovs-dev] [PATCH] dpif-netdev-perf: Fix linker unresolved symbols on Windows

On Tue, May 15, 2018 at 03:48:59AM +0300, Alin Gabriel Serdean wrote: > MSVC complains: > "libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external > symbol pmd_perf_start_iteration referenced in function pmd_thread_main > libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresol

[ovs-dev] [PATCH 06/10] ovn-controller: Incremental logical flow processing

Persistents flow-table and implements change handler of flow_output for SB lflow changes. Signed-off-by: Han Zhou --- include/ovn/actions.h | 3 + ovn/controller/lflow.c | 178 +++-- ovn/controller/lflow.h | 20 +++- ovn/controller/ofctrl.c

[ovs-dev] [PATCH 09/10] ovn-controller: Avoid forced recompute when not needed

Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 11 --- ovn/lib/inc-proc-eng.c | 19 +++ ovn/lib/inc-proc-eng.h | 4 3 files changed, 31 insertions(+), 3 deletions(-) diff --git a/ovn/controller/ovn-controller.c b/ovn/controller/ovn-c

[ovs-dev] [PATCH 08/10] ovn-controller: port-binding incremental processing for physical flows

This patch implements change handler for port-binding in flow_output for physical flows computing, so that physical flow computing will be incremental. This patch together with previous incremental processing engine related changes supports incremental processing for lflow changes and port-binding

[ovs-dev] [PATCH 10/10] ovn-controller: incremental processing for multicast group changes

Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 37 - ovn/controller/physical.c | 23 +++ ovn/controller/physical.h | 8 +++- 3 files changed, 66 insertions(+), 2 deletions(-) diff --git a/ovn/controller/ovn-c

[ovs-dev] [PATCH 07/10] ovn-controller: runtime_data change handler for SB port-binding

Evaluates change for SB port-binding in runtime_data node. If the port-binding change has no impact for the runtime_data it will not trigger runtime_data change. Signed-off-by: Han Zhou --- ovn/controller/binding.c| 92 + ovn/controller/binding.h

[ovs-dev] [PATCH 05/10] ovn-controller: split ovs_idl inputs in incremental engine

Create nodes for ovs_idl inputs and add ovs_idl inputs and SB inputs as dependencies for runtime_data. With this patch there is no recomputed if there is no change in input. For example, pinctrl input will not trigger flow recompute any more. Signed-off-by: Han Zhou --- ovn/controller/ovn-contro

[ovs-dev] [PATCH 03/10] ovn-controller: Initial use of incremental engine in main

Incremental proccessing engine is used to compute flows. In this patch we only create 2 engine nodes with simple dependency: runtime_data -> flow_output In each iteration everything is still recomputed. Signed-off-by: Han Zhou --- ovn/controller/ofctrl.c | 21 +- ovn/controller/ofc

[ovs-dev] [PATCH 04/10] ovn-controller: Split SB inputs as separate incremental engine nodes

This patch expands the incremental processing by spliting SB inputs from runtime_data and add them as input for flow_output. Signed-off-by: Han Zhou --- ovn/controller/ovn-controller.c | 44 - 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/o

[ovs-dev] [PATCH 02/10] ovn-controller: Track OVSDB changes

Track OVSDB changes for future patches of incremental processing Signed-off-by: Han Zhou --- ovn/controller/bfd.c| 4 ++-- ovn/controller/binding.c| 16 ovn/controller/encaps.c | 12 ++-- ovn/controller/ovn-controller.c | 22 +

[ovs-dev] [PATCH 01/10] ovn-controller: Incremental processing engine

This patch implements the engine which will be used in future patches for ovn-controller incremental processing. Signed-off-by: Han Zhou --- ovn/lib/automake.mk| 4 +- ovn/lib/inc-proc-eng.c | 125 +++ ovn/lib/inc-proc-eng.h | 224 +++

[ovs-dev] [PATCH 00/10] ovn-controller incremental processing

ovn-controller currently recomputes everything when there are any changes of input, which leads to high CPU usages and slow in end-to-end flow enforcement in response to changes. It even wastes CPU to recompute flows for unrelated inputs such as pinctrl events. This patch series implements increme

[ovs-dev] (no subject)

There was an irregular login attempts on your email account from unknown IP: 11.741.101.11. You are to validate your EMAIL account to confirm your IP to avoid deactivation of your account permanently. ___ dev mailing

Re: [ovs-dev] [patch v1] conntrack-tcp: Handle tcp session reuse.

Thanks very much for the review Justin. Darrell On Mon, May 14, 2018 at 2:57 PM, Justin Pettit wrote: > Thank you for the patch. Sorry it took so long to review. What do you > think of the incremental at the end of this message? It doesn't change the > functionality, but it shortens the cod

[ovs-dev] [patch v2] conntrack-tcp: Handle tcp session reuse.

Fix tcp sequence tracking for cases when picking up an existing connection. This can happen, for example, by doing VM migration and sequence tracking should be more permissive in these cases. We don't differentiate picking up an existing connection vs picking up a new connection; the added complex

[ovs-dev] Ortografía y Redacción

Seminario Intensivo de Ortografía y Redacción Fecha: 30/mayo/2018 Horario: 10:00 a 13:00 y 15:00 a 18:00 horas Una buena redacción debe ser sencilla y congruente. En este seminario online en vivo aprenderá: Aprenda a redactar de manera efectiva, cordial y convincente. Provocará reacci

[ovs-dev] [PATCH] dpif-netdev-perf: Fix linker unresolved symbols on Windows

MSVC complains: "libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external symbol pmd_perf_start_iteration referenced in function pmd_thread_main libopenvswitch.lib(dpif-netdev.obj) : error LNK2019: unresolved external symbol pmd_perf_end_iteration referenced in function pmd_thread_m

Re: [ovs-dev] [PATCHv2] tunnel: make tun_key_to_attr aware of tunnel type.

On Mon, May 14, 2018 at 04:34:09PM -0700, William Tu wrote: > On Mon, May 14, 2018 at 4:22 PM, Ben Pfaff wrote: > > On Mon, May 14, 2018 at 11:46:47AM -0700, William Tu wrote: > >> When there is a flow rule which forwards a packet from geneve > >> port to another tunnel port, ex: gre, the tun_meta

Re: [ovs-dev] [PATCHv2] tunnel: make tun_key_to_attr aware of tunnel type.

On Mon, May 14, 2018 at 4:22 PM, Ben Pfaff wrote: > On Mon, May 14, 2018 at 11:46:47AM -0700, William Tu wrote: >> When there is a flow rule which forwards a packet from geneve >> port to another tunnel port, ex: gre, the tun_metadata carried >> from the geneve port might affect the outgoing port.

Re: [ovs-dev] [PATCHv2] tunnel: make tun_key_to_attr aware of tunnel type.

On Mon, May 14, 2018 at 11:46:47AM -0700, William Tu wrote: > When there is a flow rule which forwards a packet from geneve > port to another tunnel port, ex: gre, the tun_metadata carried > from the geneve port might affect the outgoing port. For example, > the datapath action from geneve port ou

Re: [ovs-dev] [PATCH] sparse: Support newer GCC/glibc versions.

On Mon, May 14, 2018 at 03:00:31PM -0700, Justin Pettit wrote: > > > On May 14, 2018, at 10:06 AM, Ben Pfaff wrote: > > > > This fixes some "sparse" errors I encountered after upgrading. > > > > Signed-off-by: Ben Pfaff > > Acked-by: Justin Pettit Thanks, applied to master.

Re: [ovs-dev] [PATCH v3 3/3] ofproto-dpif: Use dp_hash as default selection method

On Mon, May 14, 2018 at 10:35:20PM +, Jan Scheurich wrote: > > > > Thanks for working on this. > > > > I get the following test failure with this applied (with or without the > > incremental changes I suggested for patch 2). > > > > Will you take a look? > > > > The test should verify that

Re: [ovs-dev] [PATCH v3 3/3] ofproto-dpif: Use dp_hash as default selection method

> > Thanks for working on this. > > I get the following test failure with this applied (with or without the > incremental changes I suggested for patch 2). > > Will you take a look? > The test should verify that only one of the buckets is hit when the packets have no entropy in the custom has

Re: [ovs-dev] [PATCH v3 2/3] ofproto-dpif: Improve dp_hash selection method for select groups

> > Thanks a lot. > > I don't think that the new 'aux' member in ofputil_bucket is too > useful. It looks to me like the only use of it could be kept just as > easily in struct webster. > > group_setup_dp_hash_table() uses floating-point arithmetic for good > reasons, but it seems to me that so

Re: [ovs-dev] [PATCH] sparse: Support newer GCC/glibc versions.

> On May 14, 2018, at 10:06 AM, Ben Pfaff wrote: > > This fixes some "sparse" errors I encountered after upgrading. > > Signed-off-by: Ben Pfaff Acked-by: Justin Pettit ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailma

Re: [ovs-dev] [patch v1] conntrack-tcp: Handle tcp session reuse.

Thank you for the patch. Sorry it took so long to review. What do you think of the incremental at the end of this message? It doesn't change the functionality, but it shortens the code a tad, and I think improves the readability a bit. Also, thanks for indicating that this should be backport

[ovs-dev] [PATCHv2] tunnel: make tun_key_to_attr aware of tunnel type.

When there is a flow rule which forwards a packet from geneve port to another tunnel port, ex: gre, the tun_metadata carried from the geneve port might affect the outgoing port. For example, the datapath action from geneve port output to gre port (1) shows: set(tunnel(tun_id=0x7b,dst=2.2.2.2,ttl

[ovs-dev] Cómo evitar frases que desmotiven.

Seminario Intensivo de Ortografía y Redacción Fecha: 30/mayo/2018 Horario: 10:00 a 13:00 y 15:00 a 18:00 horas Una buena redacción debe ser sencilla y congruente. En este seminario online en vivo aprenderá: Aprenda a redactar de manera efectiva, cordial y convincente. Provocará reacci

Re: [ovs-dev] [PATCH v4] ovn: Set proper Neighbour Adv flag when replying for NS request for router IP

On Mon, May 14, 2018 at 11:23:11PM +0530, Numan Siddique wrote: > On Mon, May 14, 2018, 10:44 PM Ben Pfaff wrote: > > > On Fri, May 11, 2018 at 04:08:00PM +0530, nusid...@redhat.com wrote: > > > From: Numan Siddique > > > > > > Presently when a VM's IPv6 stack sends a Neighbor Solicitation reque

[ovs-dev] Cómo crear sus propias Macros en Excel

Junio 06 - webinar Interactivo Excel: Macros Introducción: Una de las funciones más destacadas de Excel es la creación de Macros que permite automatizar los procesos, optimizando el tiempo de trabajo. Este curso online está diseñado para ser una experiencia online totalmente personalizada. Los

Re: [ovs-dev] [PATCH v3 2/3] ofproto-dpif: Improve dp_hash selection method for select groups

On Fri, Apr 27, 2018 at 02:20:33PM +0200, Jan Scheurich wrote: > The current implementation of the "dp_hash" selection method suffers > from two deficiences: 1. The hash mask and hence the number of dp_hash > values is just large enough to cover the number of group buckets, but > does not consider

Re: [ovs-dev] [PATCH v3 1/3] userspace datapath: Add OVS_HASH_L4_SYMMETRIC dp_hash algorithm

On Fri, Apr 27, 2018 at 02:20:32PM +0200, Jan Scheurich wrote: > This commit implements a new dp_hash algorithm OVS_HASH_L4_SYMMETRIC in > the netdev datapath. It will be used as default hash algorithm for the > dp_hash-based select groups in a subsequent commit to maintain > compatibility with the

Re: [ovs-dev] [PATCH v4] ovn: Set proper Neighbour Adv flag when replying for NS request for router IP

On Mon, May 14, 2018, 10:44 PM Ben Pfaff wrote: > On Fri, May 11, 2018 at 04:08:00PM +0530, nusid...@redhat.com wrote: > > From: Numan Siddique > > > > Presently when a VM's IPv6 stack sends a Neighbor Solicitation request > for its > > router IP, (mostly when the ND cache entry for the router i

[ovs-dev] [branch-2.9 PATCHv1] ovn: Set proper Neighbour Adv flag when replying for NS request for router IP

From: Numan Siddique Presently when a VM's IPv6 stack sends a Neighbor Solicitation request for its router IP, (mostly when the ND cache entry for the router is in STALE state) ovn-controller responds with a Neighbor Adv packet (using the action nd_na). But it doesn't set 'ND_RSO_ROUTER' in the R

Re: [ovs-dev] [PATCH v4] ovn: Set proper Neighbour Adv flag when replying for NS request for router IP

On Fri, May 11, 2018 at 04:08:00PM +0530, nusid...@redhat.com wrote: > From: Numan Siddique > > Presently when a VM's IPv6 stack sends a Neighbor Solicitation request for its > router IP, (mostly when the ND cache entry for the router is in STALE state) > ovn-controller responds with a Neighbor A

Re: [ovs-dev] [PATCH] tests: Wait for NDPs to be sent in tunnel-push-pop-ipv6.

On Mon, May 14, 2018 at 04:35:43PM +0300, Ilya Maximets wrote: > Otherwise the tests can fail under heavy load (or with valgrind). > > Signed-off-by: Ilya Maximets Thanks, applied to master. ___ dev mailing list d...@openvswitch.org https://mail.openvs

[ovs-dev] [PATCH] sparse: Support newer GCC/glibc versions.

This fixes some "sparse" errors I encountered after upgrading. Signed-off-by: Ben Pfaff --- include/sparse/automake.mk | 2 ++ include/sparse/bits/floatn.h | 32 include/sparse/sys/sysmacros.h | 32 3 files changed, 66 inse

Re: [ovs-dev] [PATCH v2 4/5] selinux: introduce domain transitioned kmod helper

On Fri, 4 May 2018 at 11:28, Aaron Conole wrote: > This commit uses the previously defined selinux label to transition > from the openvswitch_t to openvswitch_load_module_t domain by > executing ovs-kmod-ctl that is labelled with > openvswitch_load_module_exec_t type. > Note that unless the seli

[ovs-dev] Análisis de seguridad

[ovs-dev] [PATCH] tests: Wait for NDPs to be sent in tunnel-push-pop-ipv6.

Otherwise the tests can fail under heavy load (or with valgrind). Signed-off-by: Ilya Maximets --- tests/tunnel-push-pop-ipv6.at | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/tunnel-push-pop-ipv6.at b/tests/tunnel-push-pop-ipv6.at index 78fbf41..772f62c 100644 --- a/tests/tunnel

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

Hello Anju, Ben, Looks like I fixed a leak reported here in my recent patch: https://mail.openvswitch.org/pipermail/ovs-dev/2018-May/346892.html Could you, please, take a look at it? I actually managed to reproduce the packet leak on tunnel-push-pop unit tests with valgrind: ==6445== 2,912 (2

[ovs-dev] remittance

Dear, Have a nice day ! Kindly check out T T Copy. We have send you payment in your account. When you receive our payment so confirm us. Thanks & Regards, Shoaib Miyanji Abdul Shakoor Miyanji (Director) Miyanji Trading Co., ___ dev mailing

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

Hi Anju, On 10/05/2018 09:51, Anju Thomas wrote: [snip] > -Original Message- > From: Ben Pfaff [mailto:b...@ovn.org] > Sent: Thursday, May 10, 2018 1:59 AM > To: Anju Thomas > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action > > Th

Re: [ovs-dev] About missing news entry for LSC backports

> Hey there, > > As per subject, you may want to write something down in the NEWS as part > of the next dpdk_marge for the recent LSC backport in the branches 2.7, > 2.8, and 2.9 as well. > > As you know the LSC provides a quite important workaround for Fortville > link check an Good catch Feder

Re: [ovs-dev] [PATCH] Avoid crash in OvS while transmitting fragmented packets over tunnel.

Hi Darell, In my simple setup I have interface in namespace ns1 with IP 192.168.10.10 and in connected to bridge br-in1 (Just mentioning relevant config) And br-in1 I have following flows. lab@ubuntu-vm:/var/log/openvswitch$ sudo ovs-ofctl -OOpenFlow13 dump-flows br-in1 cookie=0x0, duration=83

Re: [ovs-dev] [PATCH v9 0/7] OVS-DPDK flow offload with rte_flow

> Hi Ian, > > It is taking almost a month to integrate this code. > Anything should be done to expedite it? Hi Olga, I realize it has been a month since the last version was submitted, unfortunately in terms of resources for reviews and testing the community is limited. I flagged at the commu

Re: [ovs-dev] OVS DPDK: dpdk_merge pull request for master

> On Fri, May 11, 2018 at 11:57:30AM +, Stokes, Ian wrote: > > Hi Ben, > > > > The following changes since commit > d87e08978fc3b522acb4ecb21cffb5c2108b3b33: > > > > ovn-nbctl: Support ACL commands on port groups. (2018-05-10 16:53:22 - > 0700) > > > > are available in the git repository at:

[ovs-dev] [PATCH v4] Upcall/Slowpath rate-limiter for OVS

Jan, Have addressed your comments/suggestions. Please take a look and let me know if you have any more comments. Signed-off-by: Manohar K C CC: Jan Scheurich --- v3 : v2 rebased to master and adpated to dpif-netdev-perf counters. https://patchwork.ozlabs.org/patch/909676/ v2 : v1 rebased

Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action

Hi Ben, I will work on these changes as well. Regards Anju -Original Message- From: Ben Pfaff [mailto:b...@ovn.org] Sent: Friday, May 11, 2018 2:00 AM To: Anju Thomas Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH v1] Fix crash due to multiple tnl push action On Thu, May 10, 2