Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-07-24 Thread Keshav Gupta
om Cc: d...@openvswitch.org Subject: Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS. Hi all, It seems Rohith Basavaraja email has been disabled. I believe it's too late for someone else to pick up Rohith's work, right? Federico On Mon, 11 Jun 2018 at 10:33, Stokes, Ian

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-07-24 Thread Federico Iezzi
lcome. > > > We in Ericsson cannot do that currently due to license restrictions. > > > > > > Regards, Jan > > > > > > > -Original Message- > > > > From: ovs-dev-boun...@openvswitch.org > > > > > > > On Behalf Of Roh

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-07-10 Thread Federico Iezzi
ently due to license restrictions. > > > > > > Regards, Jan > > > > > > > -Original Message- > > > > From: ovs-dev-boun...@openvswitch.org > > > > > > > On Behalf Of Rohith Basavaraja > > > > Sent: Friday, 25 May, 20

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-06-11 Thread Stokes, Ian
t; > We in Ericsson cannot do that currently due to license restrictions. > > > > Regards, Jan > > > > > -Original Message- > > > From: ovs-dev-boun...@openvswitch.org > > > > > On Behalf Of Rohith Basavaraja > > > Sent: F

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-06-08 Thread Federico Iezzi
inal Message- > > From: ovs-dev-boun...@openvswitch.org > On Behalf Of Rohith Basavaraja > > Sent: Friday, 25 May, 2018 07:37 > > To: Ben Pfaff > > Cc: d...@openvswitch.org > > Subject: Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS. > > > &

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-06-06 Thread Jan Scheurich
> -Original Message- > From: ovs-dev-boun...@openvswitch.org On > Behalf Of Rohith Basavaraja > Sent: Friday, 25 May, 2018 07:37 > To: Ben Pfaff > Cc: d...@openvswitch.org > Subject: Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS. > > Thanks Ben

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-25 Thread Federico Iezzi
Hello everyone, May I ask to provide some (even brief) documentation about each specific drop counter? That would really help understanding why a specific drop is happening. Thanks, Federico On 25 May 2018 at 07:44, Rohith Basavaraja wrote: > Hi Greg, > > Thanks a lot for sharing the info. > B

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-24 Thread Rohith Basavaraja
Hi Greg, Thanks a lot for sharing the info. Ben clarified that it should be ok if this new stuff is used only in the DPDK datapath and it’s not used in the kernel datapath. Thanks Rohith On 24/05/18, 9:05 PM, "Gregory Rose" wrote: On 5/23/2018 7:19 PM, Rohith Basavaraja wrote: > Hi B

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-24 Thread Rohith Basavaraja
Thanks Ben for the clarification. Yes this new stuff is used only in the DPDK datapath and it’s not used in the kernel datapath. Thanks Rohith On 25/05/18, 2:52 AM, "Ben Pfaff" wrote: On Thu, May 24, 2018 at 02:19:06AM +, Rohith Basavaraja wrote: > Only changes in > datapath/l

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-24 Thread Ben Pfaff
On Thu, May 24, 2018 at 02:19:06AM +, Rohith Basavaraja wrote: > Only changes in > datapath/linux/compat/include/linux/openvswitch.h > are related to OvS Kernel module. On a second look, I see that the new stuff here is only for the DPDK datapath. If you don't intend to add this feature t

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-24 Thread Gregory Rose
On 5/23/2018 7:19 PM, Rohith Basavaraja wrote: Hi Ben, Only changes in datapath/linux/compat/include/linux/openvswitch.h are related to OvS Kernel module. The changes in openvswitch.h are not upstreamed yet. Can you please let me know the procedure for submitting the Changes for OvS Kernel Mod

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-23 Thread Rohith Basavaraja
Hi Ben, Only changes in datapath/linux/compat/include/linux/openvswitch.h are related to OvS Kernel module. The changes in openvswitch.h are not upstreamed yet. Can you please let me know the procedure for submitting the Changes for OvS Kernel Module?. In the meanwhile can I get code review

Re: [ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-23 Thread Ben Pfaff
I see that this adds code to the OVS kernel module. Are these changes upstream already in Linux? Usually we use an "upstream first" philosophy regarding the kernel module. ___ dev mailing list d...@openvswitch.org https://mail.openvswitch.org/mailman/li

[ovs-dev] [PATCH] Improved Packet Drop Statistics in OVS.

2018-05-23 Thread Rohith Basavaraja
Currently OVS maintains explicit packet drop/error counters only on port level. Packets that are dropped as part of normal OpenFlow processing are counted in flow stats of “drop” flows or as table misses in table stats. These can only be interpreted by controllers that know the sema