Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-25 Thread Ben Pfaff
On Fri, May 25, 2018 at 05:56:51AM -0700, William Tu wrote: > > > > OK, now I understand what's going on. This is only used to define the > > format of the OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS attribute. Since it's not > > a wire format at all, we don't need to use ovs_16aligned_be32 either, > > and a

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-25 Thread William Tu
> > OK, now I understand what's going on. This is only used to define the > format of the OVS_TUNNEL_KEY_ATTR_ERSPAN_OPTS attribute. Since it's not > a wire format at all, we don't need to use ovs_16aligned_be32 either, > and an "int" is fine too. > > Since erspan_metadata is part of the kernel A

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-25 Thread Darrell Ball
On Thu, May 24, 2018 at 2:16 PM, Ben Pfaff wrote: > On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote: > > On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote: > > > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote: > > >> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball > wrote:

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-24 Thread Ben Pfaff
On Thu, May 24, 2018 at 05:22:37PM -0700, William Tu wrote: > On Thu, May 24, 2018 at 2:16 PM, Ben Pfaff wrote: > > On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote: > >> On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote: > >> > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-24 Thread William Tu
On Thu, May 24, 2018 at 2:16 PM, Ben Pfaff wrote: > On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote: >> On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote: >> > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote: >> >> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote: >> >>

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-24 Thread Ben Pfaff
On Thu, May 24, 2018 at 12:08:31PM -0700, William Tu wrote: > On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote: > > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote: > >> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote: > >> > The struct erspan_metadata is updated to replace the 'v

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-24 Thread William Tu
On Thu, May 24, 2018 at 10:20 AM, Ben Pfaff wrote: > On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote: >> On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote: >> > The struct erspan_metadata is updated to replace the 'version' >> > placeholder with the erspan base hdr. Also, the erspan

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-24 Thread Ben Pfaff
On Thu, May 24, 2018 at 05:36:10AM -0700, William Tu wrote: > On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote: > > The struct erspan_metadata is updated to replace the 'version' > > placeholder with the erspan base hdr. Also, the erspan > > index is defined explicitly as ovs_16aligned_be32 to

Re: [ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-24 Thread William Tu
On Wed, May 23, 2018 at 7:13 PM, Darrell Ball wrote: > The struct erspan_metadata is updated to replace the 'version' > placeholder with the erspan base hdr. Also, the erspan > index is defined explicitly as ovs_16aligned_be32 to mirror > its encoding. > Changes to odp_util result from updating t

[ovs-dev] [patch v4 2/2] packets: ersapn_metadata header fixups.

2018-05-23 Thread Darrell Ball
The struct erspan_metadata is updated to replace the 'version' placeholder with the erspan base hdr. Also, the erspan index is defined explicitly as ovs_16aligned_be32 to mirror its encoding. Changes to odp_util result from updating the erspan index type. CC: William Tu Fixes: 068794b43f0e ("ers