Stephen Finucane writes:
> This reverts commit f09bfd460814d7125437b0b45a183a221692584a. We haven't
> actually released a version of Patchwork with this release yet so it
> seems odd to skip it entirely. It's also incorrect, in that it adds an
> additional release note rather than remove the one
Andrew Donnellan writes:
> On 5/11/19 2:18 pm, Stephen Finucane wrote:
>> On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote:
>>> Enable Python 3.8 in our tests and list it as a supported version.
>>>
>>> Signed-off-by: Andrew Donnellan
>>
>> LGTM, but let's hold off on this until 2.2 is
Stephen Finucane writes:
> On Tue, 2019-10-29 at 18:26 +1100, Daniel Axtens wrote:
>> The .env setup didn't do GID. It's a bit of a chore to do because
>> there doesn't seem to be a GID shell variable and because we need
>> to do a bit more work to get a multi-line thing, but this should
>> work.
On 5/11/19 2:18 pm, Stephen Finucane wrote:
On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote:
Enable Python 3.8 in our tests and list it as a supported version.
Signed-off-by: Andrew Donnellan
LGTM, but let's hold off on this until 2.2 is out.
Given there are no code changes neces
Stephen Finucane writes:
> On Tue, 2019-10-29 at 17:47 +1100, Daniel Axtens wrote:
>> It's no longer supported upstream, per
>> https://www.djangoproject.com/download/#supported-versions
>>
>> Signed-off-by: Daniel Axtens
>
> Hmm, can we not do this until after we've release Patchwork 2.2 (I'll
On Thu, 2019-10-24 at 14:10 +1100, Andrew Donnellan wrote:
> Enable Python 3.8 in our tests and list it as a supported version.
>
> Signed-off-by: Andrew Donnellan
LGTM, but let's hold off on this until 2.2 is out.
Stephen
___
Patchwork mailing list
This reverts commit f09bfd460814d7125437b0b45a183a221692584a. We haven't
actually released a version of Patchwork with this release yet so it
seems odd to skip it entirely. It's also incorrect, in that it adds an
additional release note rather than remove the one that has not yet been
included in a
On Tue, 2019-10-29 at 18:26 +1100, Daniel Axtens wrote:
> The .env setup didn't do GID. It's a bit of a chore to do because
> there doesn't seem to be a GID shell variable and because we need
> to do a bit more work to get a multi-line thing, but this should
> work.
>
> While we're at it, change t
On Tue, 2019-10-29 at 18:26 +1100, Daniel Axtens wrote:
> We're not doing a good job of it, the versions are out of date and
> we keep forgetting to update the README. We are a bit better at
> making release notes, so just point people there.
>
> Signed-off-by: Daniel Axtens
Same comments as pre
On Tue, 2019-10-29 at 18:26 +1100, Daniel Axtens wrote:
> Signed-off-by: Daniel Axtens
Same comments as previous patch.
Reviewed-by: Stephen Finucane
___
Patchwork mailing list
Patchwork@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/patchwork
On Tue, 2019-10-29 at 17:47 +1100, Daniel Axtens wrote:
> It's no longer supported upstream, per
> https://www.djangoproject.com/download/#supported-versions
>
> Signed-off-by: Daniel Axtens
Hmm, can we not do this until after we've release Patchwork 2.2 (I'll
be back from PTO/the OpenInfra Summ
Daniel Axtens writes:
> Hi Mete,
>
> Apologies for the delay in getting back to you. I'm kicking the tyres of
> this, so I'll have a few comments across the series. Maybe hold off on
> doing a new version until I get through the whole series - I don't want
> to waste your effort on doing lots of
Applied, with an adjusted release note. Distros might not ship a newer
version - if not, people who are committed to running distro versions
should run Django 1.11, which is still supported.
Daniel Axtens writes:
> It's no longer supported upstream, per
> https://www.djangoproject.com/download/#
Both applied, thanks.
Andrew Donnellan writes:
> In HTML5, the type attribute of a script tag is optional if it's
> JavaScript.
>
> Remove all occurrences. The only real gain is slightly smaller page output,
> but it also shuts up validators that like to be noisy about this.
>
> Signed-off-by: A
Applied, thanks.
Andrew Donnellan writes:
> It's not valid to put a inside an . Move the download buttons in
> the submission template outside the tag.
>
> Signed-off-by: Andrew Donnellan
>
> ---
> v1->v2
> - make it look the same as before (Daniel)
> ---
> patchwork/templates/patchwork/subm
Hi Mete,
I tried to test code coverage for this and it turns out it's failing the
test suite on python2.7 and python3.5:
https://travis-ci.org/daxtens/patchwork/builds/606997177
You should be able to test this locally with:
docker-compose run web --tox
All the tox environments should pass.
If yo
16 matches
Mail list logo