Re: [PATCH] tests: Rename inaccurately named test_patchwork_from_header

2019-10-17 Thread Daniel Axtens
Andrew Donnellan writes: > On 18/10/19 3:02 pm, Daniel Axtens wrote: >> Andrew Donnellan writes: >> >>> The test_patchwork_from_header test claims to test for the presence of the >>> X-Patchwork-From header, when we actually call it X-Patchwork-Sender. >> X-Patchwork-Submitter, surely? > > Wow,

Re: [PATCH] tests: Rename inaccurately named test_patchwork_from_header

2019-10-17 Thread Andrew Donnellan
On 18/10/19 3:02 pm, Daniel Axtens wrote: Andrew Donnellan writes: The test_patchwork_from_header test claims to test for the presence of the X-Patchwork-From header, when we actually call it X-Patchwork-Sender. X-Patchwork-Submitter, surely? Wow, the irony of me getting this wrong in the c

Re: [PATCH] tests: Rename inaccurately named test_patchwork_from_header

2019-10-17 Thread Daniel Axtens
Andrew Donnellan writes: > The test_patchwork_from_header test claims to test for the presence of the > X-Patchwork-From header, when we actually call it X-Patchwork-Sender. X-Patchwork-Submitter, surely? (I didn't even know that one existed!) Regards, Daniel > > Fix it. > > Signed-off-by: Andr

[PATCH] tests: Rename inaccurately named test_patchwork_from_header

2019-10-17 Thread Andrew Donnellan
The test_patchwork_from_header test claims to test for the presence of the X-Patchwork-From header, when we actually call it X-Patchwork-Sender. Fix it. Signed-off-by: Andrew Donnellan --- patchwork/tests/test_mboxviews.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/