Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-26 Thread Daniel Axtens
Andrew Donnellan writes: > On 07/08/18 17:20, Daniel Axtens wrote: >> I wonder if we could let authenticated users do slower queries. Maybe >> something for later. Let's split the difference at 250 then, I'd be >> happy to merge that. > > If you want to take this patch and s/500/250/g during merg

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-08 Thread Stewart Smith
Daniel Axtens writes: > FWIW we now have this applied on patchwork.ozlabs.org and it appears to > be working. Would like some more input as to what an appropriate default > limit is. My completely fact-free feeling/opinion is that if it takes more than ~1sec to run on O

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-08 Thread Stewart Smith
Andrew Donnellan writes: > On 26/07/18 23:24, Daniel Axtens wrote: >> Andrew Donnellan writes: >> >>> On 24/07/18 15:10, Andrew Donnellan wrote: In 41790caf59ad ("REST: Limit max page size") we limited the maximum page size to the default page size in the settings. This turns

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-08 Thread Stewart Smith
Andrew Donnellan writes: > On 24/07/18 15:10, Andrew Donnellan wrote: >> In 41790caf59ad ("REST: Limit max page size") we limited the maximum page >> size to the default page size in the settings. >> >> This turns out to be rather restrictive, as we usually want to keep the >> default page size l

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-07 Thread Andrew Donnellan
On 07/08/18 17:20, Daniel Axtens wrote: I wonder if we could let authenticated users do slower queries. Maybe something for later. Let's split the difference at 250 then, I'd be happy to merge that. If you want to take this patch and s/500/250/g during merge then I'd be happy with that. -- A

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-07 Thread Daniel Axtens
FWIW we now have this applied on patchwork.ozlabs.org and it appears to be working. Would like some more input as to what an appropriate default limit is. >>> >>> My completely fact-free feeling/opinion is that if it takes more than >>> ~1sec to run on Ozlabs, it's probably too high

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-08-06 Thread Andrew Donnellan
On 26/07/18 23:24, Daniel Axtens wrote: Andrew Donnellan writes: On 24/07/18 15:10, Andrew Donnellan wrote: In 41790caf59ad ("REST: Limit max page size") we limited the maximum page size to the default page size in the settings. This turns out to be rather restrictive, as we usually want to

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-07-26 Thread Daniel Axtens
Andrew Donnellan writes: > On 24/07/18 15:10, Andrew Donnellan wrote: >> In 41790caf59ad ("REST: Limit max page size") we limited the maximum page >> size to the default page size in the settings. >> >> This turns out to be rather restrictive, as we usually want to keep the >> default page size

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-07-25 Thread Andrew Donnellan
On 24/07/18 15:10, Andrew Donnellan wrote: In 41790caf59ad ("REST: Limit max page size") we limited the maximum page size to the default page size in the settings. This turns out to be rather restrictive, as we usually want to keep the default page size low, but an administrator may want to allo

Re: [RFC PATCH] REST: Add new setting for maximum API page size

2018-07-23 Thread Andrew Donnellan
On 24/07/18 15:10, Andrew Donnellan wrote: diff --git a/docs/deployment/configuration.rst b/docs/deployment/configuration.rst index 347485636d47..e599522a412b 100644 --- a/docs/deployment/configuration.rst +++ b/docs/deployment/configuration.rst @@ -88,7 +88,13 @@ Enable the :doc:`REST API <../a

[RFC PATCH] REST: Add new setting for maximum API page size

2018-07-23 Thread Andrew Donnellan
In 41790caf59ad ("REST: Limit max page size") we limited the maximum page size to the default page size in the settings. This turns out to be rather restrictive, as we usually want to keep the default page size low, but an administrator may want to allow API clients to fetch more than that per req