Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Patrick R. Michaud
On Wed, Jun 27, 2007 at 10:52:49PM -0700, chromatic wrote: > On Wednesday 27 June 2007 22:38:17 Andy Lester wrote: > > > It'd have to be against the last update from svn of the file itself. > > Yes. ...just to toss some random brainstorms into the mix here... To avoid svn-specific behavior, is

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread chromatic
On Wednesday 27 June 2007 23:00:49 Andy Lester wrote: > What if we have the Perl::Critic checks as Subversion commit hooks? > Could email p6i with the results, too. That's what we do at work, > and it's annoying, but it's there and it's pretty in-your-face. If it doesn't hose svk push, where the

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Andy Lester
On Jun 28, 2007, at 12:52 AM, chromatic wrote: Heck, you didn't even *compile* before one of your checkins yesterday. And really, this speaks even more about where the check should be. What if we have the Perl::Critic checks as Subversion commit hooks? Could email p6i with the results, to

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Andy Lester
On Jun 28, 2007, at 12:52 AM, chromatic wrote: Heck, you didn't even *compile* before one of your checkins yesterday. Yeah, I did. I just had modified something else on a wild tear, forgot to revert it, and did a commit hours later. Sorry about that. -- Andy Lester => [EMAIL PROTECTED]

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread chromatic
On Wednesday 27 June 2007 22:38:17 Andy Lester wrote: > It'd have to be against the last update from svn of the file itself. Yes. > I'm not sure I like the idea of relying on a given VCS. I know > Parrot's hosted in Subversion, but what about the Git folks? As soon as they start reporting fail

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Andy Lester
Modified since when? Modified since the most recent checkout, of course. Check svn or svk status. Run these time-consuming analysis tests on only the modified files. It'd have to be against the last update from svn of the file itself. I'm not sure I like the idea of relying on a given V

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread chromatic
On Wednesday 27 June 2007 22:09:55 Andy Lester wrote: > On Jun 27, 2007, at 11:50 PM, chromatic wrote: > > I'd like to see an option to run it only on *modified* files. > Modified since when? Modified since the most recent checkout, of course. Check svn or svk status. Run these time-consumin

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Andy Lester
On Jun 27, 2007, at 11:50 PM, chromatic wrote: I'd like to see an option to run it only on *modified* files. Modified since when? -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread chromatic
On Wednesday 27 June 2007 13:22:22 Andy Lester wrote: > The Perl::Critic testing in t/codingstd/perlcritic.t needs to be > optional. The existence of Perl::Critic on a machine doesn't mean > that it's appropriate to run Perl::Critic on the Parrot code. I'd like to see an option to run it only on

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread James E Keenan
Andy Lester wrote: Maybe it's just my system that's being butt slow on it. Anyone else getting times like this? -- On my Linux Virtual Machine: [li11-226:parrot] 503 $ time perl t/codingstd/perlcritic.t # Perl::Critic::Bangs not installed: not testing for TODO items in code 1..9 ok 1 - Co

[svn:perl6-synopsis] r14426 - doc/trunk/design/syn

2007-06-27 Thread larry
Author: larry Date: Wed Jun 27 14:28:27 2007 New Revision: 14426 Modified: doc/trunk/design/syn/S12.pod Log: Clarification suggested by TheDamian++. Modified: doc/trunk/design/syn/S12.pod == --- doc/trunk/design/syn/

Re: t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Andy Lester
On Jun 27, 2007, at 3:22 PM, Andy Lester wrote: The Perl::Critic testing in t/codingstd/perlcritic.t needs to be optional. The existence of Perl::Critic on a machine doesn't mean that it's appropriate to run Perl::Critic on the Parrot code. Following up, it takes almost 11 unresponsive mi

[svn:perl6-synopsis] r14425 - doc/trunk/design/syn

2007-06-27 Thread larry
Author: larry Date: Wed Jun 27 13:39:48 2007 New Revision: 14425 Modified: doc/trunk/design/syn/S12.pod Log: Clarify that method hypers can be called in any order. Modified: doc/trunk/design/syn/S12.pod == --- doc/tr

t/codingstd/perlcritic.t needs to be optional

2007-06-27 Thread Andy Lester
The Perl::Critic testing in t/codingstd/perlcritic.t needs to be optional. The existence of Perl::Critic on a machine doesn't mean that it's appropriate to run Perl::Critic on the Parrot code. xoa -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance

Re: What should I work on at the hackathon tomorrow and Friday?

2007-06-27 Thread Eric Hanchrow
That's a generous offer. How about activating the TODO test described in http://rt.perl.org/rt3/Ticket/Display.html?id=42996, and making it pass? -- A DRE voting system is one of the simplest computer applications you could imagine. It just adds by one. -- Brit Williams, emeritus profe

What should I work on at the hackathon tomorrow and Friday?

2007-06-27 Thread Andy Lester
I'm taking requests: http://use.perl.org/~petdance/journal/33615 xoxo, Andy -- Andy Lester => [EMAIL PROTECTED] => www.petdance.com => AIM:petdance