Re: [perl #42883] [PATCH] Fix up headerfile guards

2007-05-08 Thread Klaas-Jan Stol
On 5/8/07, Mark Glines via RT <[EMAIL PROTECTED]> wrote: On Sat May 05 09:37:44 2007, particle wrote: > On 5/4/07, via RT Mark Glines at parrotcode.org> wrote: > > * Standardize on PARROT_*_GUARD style names for these lines (some > > headers used a style that looks like "__PIRLEXER_H" instead)

[perl #42883] [PATCH] Fix up headerfile guards

2007-05-08 Thread Mark Glines via RT
On Sat May 05 09:37:44 2007, particle wrote: > On 5/4/07, via RT Mark Glines at parrotcode.org> wrote: > > * Standardize on PARROT_*_GUARD style names for these lines (some > > headers used a style that looks like "__PIRLEXER_H" instead) > > > there's a problem here... compilers/imcc/pirlexer.h is

Re: [perl #42883] [PATCH] Fix up headerfile guards

2007-05-07 Thread Bernhard Schmalhofer
Mark Glines schrieb: * Fix up the indentation problems caused by the above bullet point. (TODO: why does t/codingstd/c_indent.t require indentation for #if and #ifdef, but not for #ifndef?) As far as I understand c_indent.t, #ifndef is also covered Except that it isn't. If you app

Re: [perl #42883] [PATCH] Fix up headerfile guards

2007-05-06 Thread Mark Glines
On Sat, 05 May 2007 07:58:45 -0700 "Bernhard Schmalhofer via RT" <[EMAIL PROTECTED]> wrote: > > * Fix up the indentation problems caused by the above bullet point. > > (TODO: why does t/codingstd/c_indent.t require indentation for #if > > and #ifdef, but not for #ifndef?) > As far as I understand c

Re: [perl #42883] [PATCH] Fix up headerfile guards

2007-05-06 Thread Bernhard Schmalhofer
Jerry Gay via RT schrieb: On 5/4/07, via RT Mark Glines <[EMAIL PROTECTED]> wrote: * Standardize on PARROT_*_GUARD style names for these lines (some headers used a style that looks like "__PIRLEXER_H" instead) It looks like the __FOO_H convention was only used in compilers/pirc. There a

Re: [perl #42883] [PATCH] Fix up headerfile guards

2007-05-05 Thread jerry gay
On 5/4/07, via RT Mark Glines <[EMAIL PROTECTED]> wrote: * Standardize on PARROT_*_GUARD style names for these lines (some headers used a style that looks like "__PIRLEXER_H" instead) there's a problem here... compilers/imcc/pirlexer.h is a *generated* header file. next time somebody runs C to