On Wed May 07 13:45:37 2008, [EMAIL PROTECTED] wrote:
>
> I would prefer the phrase "space delimited string" since a tab
> character could be a single whitespace?
>
Cf. http://svn.perl.org/parrot/trunk/lib/Parrot/Configure/Step/Methods.pm
What ultimately was committed to trunk was: "Single
wh
On Sat, Apr 26, 2008 at 10:15:05AM -0700, James Keenan via RT wrote:
> On Sat Apr 26 09:37:06 2008, geoff wrote:
> > On Sat, 2008-04-26 at 09:25 -0700, James Keenan via RT wrote:
>
> > > +are to be added. Wordspace-delimited string.
> >
> > Did you mean "Whitespace-delimited"?
>
> No, because
Having heard no objections, I've applied the patch, incorporating
suggestions from Geoffrey Broadwell, in r27226.
On Sat Apr 26 09:37:06 2008, geoff wrote:
> On Sat, 2008-04-26 at 09:25 -0700, James Keenan via RT wrote:
> > +are to be added. Wordspace-delimited string.
>
> Did you mean "Whitespace-delimited"?
No, because I don't want people adding tabs here.
But would 'single whitespace' be more clear?
On Sat, 2008-04-26 at 09:25 -0700, James Keenan via RT wrote:
> Please review revised patch attached. Geoff, does this work for you?
> Jerry, okay on Win32?
Generally, yes. One tiny nit:
> +=item * C
> +
> +Libraries to be added where no OS-specific or OS/C-compiler-specific
> libraries
> +are
Please review revised patch attached. Geoff, does this work for you?
Jerry, okay on Win32?
(All tests passing on Darwin and Linux.)
Index: lib/Parrot/Configure/Step/Methods.pm
===
--- lib/Parrot/Configure/Step/Methods.pm(rev
On Fri, 2008-04-25 at 09:39 -0700, jerry gay wrote:
> On Fri, Apr 25, 2008 at 8:38 AM, Geoffrey Broadwell <[EMAIL PROTECTED]> wrote:
> > (Subtle note -- the || really wants to be //, but as I recall we're not
> > allowed to assume that // is there yet.)
> >
> correct, parrot depends on perl 5.8,
On Fri, Apr 25, 2008 at 8:38 AM, Geoffrey Broadwell <[EMAIL PROTECTED]> wrote:
> (Subtle note -- the || really wants to be //, but as I recall we're not
> allowed to assume that // is there yet.)
>
correct, parrot depends on perl 5.8, so we can't rely on //.
so i strongly suggest you use the idi
On Fri, 2008-04-25 at 03:45 -0700, James Keenan via RT wrote:
> > Other than having a Darwin case, how is it different than the pattern?
> The Darwin case is the difference.
Ah.
> > my $platform = $os =~ /mswin32/i && $cc =~ /^gcc/i ? 'win32_gcc' :
> > $os =~ /mswin32/i
On Thu Apr 24 20:49:05 2008, geoff wrote:
> On Thu, 2008-04-24 at 19:55 -0700, James Keenan via RT wrote:
> > Please see patch attached. It turned out that config/auto/opengl.pm
> > didn't quite conform to the pattern, so I left it unchanged.
>
> Other than having a Darwin case, how is it differe
On Thu, 2008-04-24 at 21:53 -0700, Mark Glines wrote:
> On Thu, 24 Apr 2008 20:48:34 -0700
> Geoffrey Broadwell <[EMAIL PROTECTED]> wrote:
> > my $platform = $os =~ /mswin32/i && $cc =~ /^gcc/i ? 'win32_gcc' :
> > $os =~ /mswin32/i ? 'win32_other' :
> >
On Thu, 24 Apr 2008 20:48:34 -0700
Geoffrey Broadwell <[EMAIL PROTECTED]> wrote:
> Also, the implementation of C<_add_to_libs> is a little wordy. How's
> this?
>
> sub _add_to_libs {
> my ($self, $args) = @_;
> croak "_add_to_libs() takes hashref" unless ref($args) eq 'HASH';
>
>
On Thu, 2008-04-24 at 19:55 -0700, James Keenan via RT wrote:
> Please see patch attached. It turned out that config/auto/opengl.pm
> didn't quite conform to the pattern, so I left it unchanged.
Other than having a Darwin case, how is it different than the pattern?
Also, the implementation of C<
On Wed Apr 23 18:40:46 2008, [EMAIL PROTECTED] wrote:
> There are five configuration step classes where the class's runstep()
> method has an internal subroutine called _handle_mswin32(). These
> classes are:
>
> config/auto//crypto.pm
> config/auto//gettext.pm
> config/auto//gmp.pm
> config/
I think this is an idea worth exploring, but we'll have to re-survey the
current config step classes carefully before proceeding.
There are certain methods (_init and runstep) which are part of the
public interface each class must implement. _init(), in turn, must
provide a 'description' attribute
On Wed, 2008-04-23 at 18:40 -0700, James Keenan wrote:
> There are five configuration step classes where the class's runstep()
> method has an internal subroutine called _handle_mswin32(). These
> classes are:
>
> config/auto//crypto.pm
> config/auto//gettext.pm
> config/auto//gmp.pm
> config
# New Ticket Created by James Keenan
# Please include the string: [perl #53270]
# in the subject line of all future correspondence about this issue.
# http://rt.perl.org/rt3/Ticket/Display.html?id=53270 >
There are five configuration step classes where the class's runstep()
method has an in
17 matches
Mail list logo
