Re: confused parameter order asking for trouble

2004-06-28 Thread Dan Sugalski
On Fri, 25 Jun 2004, Nicholas Clark wrote: > On Fri, Jun 25, 2004 at 02:43:14PM +0200, Leopold Toetsch wrote: > > Nicholas Clark <[EMAIL PROTECTED]> wrote: > > > On Fri, Jun 25, 2004 at 09:46:53AM +0200, Leopold Toetsch wrote: > > >> > > >> Yep. I'd swap function names as well as argument order, s

Re: confused parameter order asking for trouble

2004-06-26 Thread Leopold Toetsch
Nicholas Clark <[EMAIL PROTECTED]> wrote: > ... committed the change to ponie to keep it in sync, > and then realised I'd not checked the entire parrot source tree for any > other instances of these functions. extend.h isn't included inside Parrot. I don't know, if there are any embedders/extende

Re: confused parameter order asking for trouble

2004-06-25 Thread Nicholas Clark
On Fri, Jun 25, 2004 at 02:43:14PM +0200, Leopold Toetsch wrote: > Nicholas Clark <[EMAIL PROTECTED]> wrote: > > On Fri, Jun 25, 2004 at 09:46:53AM +0200, Leopold Toetsch wrote: > >> > >> Yep. I'd swap function names as well as argument order, so that > >> everything matches the vtable prototype. >

Re: confused parameter order asking for trouble

2004-06-25 Thread Leopold Toetsch
Nicholas Clark <[EMAIL PROTECTED]> wrote: > On Fri, Jun 25, 2004 at 09:46:53AM +0200, Leopold Toetsch wrote: >> >> Yep. I'd swap function names as well as argument order, so that >> everything matches the vtable prototype. > void Parrot_PMC_set_intkey_intval(Parrot_INTERP interp, Parrot_PMC > pmc

Re: confused parameter order asking for trouble

2004-06-25 Thread Nicholas Clark
On Fri, Jun 25, 2004 at 09:46:53AM +0200, Leopold Toetsch wrote: > Nicholas Clark <[EMAIL PROTECTED]> wrote: > > I've just fallen into this trap, and I doubt I'll be the last one: > > > void Parrot_PMC_set_intval_intkey(Parrot_INTERP interp, Parrot_PMC pmc, Parrot_Int > > value, Parrot_Int key) {

Re: confused parameter order asking for trouble

2004-06-25 Thread Leopold Toetsch
Nicholas Clark <[EMAIL PROTECTED]> wrote: > I've just fallen into this trap, and I doubt I'll be the last one: > void Parrot_PMC_set_intval_intkey(Parrot_INTERP interp, Parrot_PMC pmc, Parrot_Int > value, Parrot_Int key) { > VTABLE_set_integer_keyed_int(interp, pmc, key, value); >} > Is ther

confused parameter order asking for trouble

2004-06-24 Thread Nicholas Clark
I've just fallen into this trap, and I doubt I'll be the last one: void Parrot_PMC_set_intval_intkey(Parrot_INTERP interp, Parrot_PMC pmc, Parrot_Int value, Parrot_Int key) { VTABLE_set_integer_keyed_int(interp, pmc, key, value); } Is there any reason why the vtable is key, value but the ex