On Wed, Jun 13, 2018 at 4:00 PM, Victoria Henry wrote:
> Hi,
>
> Khushboo, thanks for making some of the changes we mentioned in our
> previous email.
> But when you say that they share logic and the code is
>
> if self.node_type == 'procedure':
>
> 50+ lines of code
>
> else:
>
> 50+ lines of co
Hi,
Khushboo, thanks for making some of the changes we mentioned in our
previous email.
But when you say that they share logic and the code is
if self.node_type == 'procedure':
50+ lines of code
else:
50+ lines of code
This tells us that they share some logic but there is a huge difference
be
Thanks, patch applied.
On Wed, Jun 13, 2018 at 12:43 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Please ignore my previous patch. Find the attached updated patch.
>
> On Wed, Jun 13, 2018 at 9:32 AM, Khushboo Vashi <
> khushboo.va...@enterprisedb.com> wrote:
>
>> Hi Victoria,
>
Hi Khushboo,
The following change is allowing the creation of procedures in postgresql
versions less then 11 and also GreenPlum
---
a/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/static/js/procedure.js
+++
b/web/pgadmin/browser/server_groups/servers/databases/schemas/fu
Hi
On Thu, Jun 7, 2018 at 11:27 AM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please ignore my previous patch, find the attached updated one.
>
I found a couple of issues with this:
- Clicking the + button on the Parameters tab does nothing in either Create
or Edit mode
Hi,
Please ignore my previous patch, find the attached updated one.
Thanks,
Khushboo
On Wed, Jun 6, 2018 at 12:12 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi,
>
> Please find the attached patch to fix #3362 - Fix the functions for PG
> v11, and add support procedure for PG
Hi,
Please find the attached patch to fix #3362 - Fix the functions for PG v11,
and add support procedure for PG v11.
Thanks,
Khushboo
diff --git a/docs/en_US/procedure_dialog.rst b/docs/en_US/procedure_dialog.rst
index da5f34f..82c2227 100644
--- a/docs/en_US/procedure_dialog.rst
+++ b/docs/en_U
