Re: ALTER VIEW

2002-02-22 Thread Dave Page
> -Original Message- > From: Jean-Michel POURE [mailto:[EMAIL PROTECTED]] > Sent: 22 February 2002 22:11 > To: Dave Page; [EMAIL PROTECTED] > Subject: Re: ALTER VIEW > > > Le Vendredi 22 Février 2002 23:06, Dave Page a écrit : > > > 5) The modifications to the SQL property are messy &

Re: ALTER VIEW

2002-02-22 Thread Jean-Michel POURE
Le Vendredi 22 Février 2002 23:06, Dave Page a écrit : > 1) Don't create the view twice, create the fake one then rename it - it's > less expensive and avoids the potential for the second create to fail. OK > 2) The szOldDefintion stuff can now be removed. OK > 3) The OID and Definition could be

Re: Triggers

2002-02-22 Thread Dave Page
> -Original Message- > From: Jean-Michel POURE [mailto:[EMAIL PROTECTED]] > Sent: 22 February 2002 22:07 > To: Dave Page > Cc: [EMAIL PROTECTED] > Subject: Triggers > > > Dear Dave, > > I commited a first implementation of pseudo ALTER TRIGGER to > CVS. Could you > please advice me

Triggers

2002-02-22 Thread Jean-Michel POURE
Dear Dave, I commited a first implementation of pseudo ALTER TRIGGER to CVS. Could you please advice me on the following points: 1) How can I drop / add the trigger node after ALTER. 2) I don't know how to uncheck checkboxes in frmTrigger form. These are very simple things to do... Have a niv

ALTER VIEW

2002-02-22 Thread Dave Page
Hi Jean-Michel, I just took a look at the latest ALTER VIEW code. Sorry, but I have a number of problems with this version: 1) Don't create the view twice, create the fake one then rename it - it's less expensive and avoids the potential for the second create to fail. 2) The szOldDefintion stuf

Re: Feature requests after crash

2002-02-22 Thread Dave Page
Comments prefixed with DP _Original message Subject:Re: [pgadmin-hackers] Feature requests after crash Sender: Jean-Michel POURE <[EMAIL PROTECTED]> Date: Fri, 22 Feb 2002 19:24:14 + > my_sum(int4, int4) > "My_Sum"(int4, int4) > My_Sum(int4, int4)

Update trigger name

2002-02-22 Thread Jean-Michel POURE
Dear friends, We are implementing trigger pseudo ALTER in pgAdmin2 Does this work to update trigger name : UPDATE tg_trigger SET tgname = 'newname' WHERE tgname = 'oldname'; Is this safe? Regards, Jean-Michel

Re: Feature requests after crash

2002-02-22 Thread Jean-Michel POURE
> my_sum(int4, int4) > "My_Sum"(int4, int4) > My_Sum(int4, int4) Yes, but such a redundancy would be detected, which is ***better*** than nothing. We can then issue a warning instead of "blocking everything". Furthermore, many names are not case sensitive because of SQL (tables, views), which

Re: Feature requests after crash

2002-02-22 Thread Dave Page
ILIKE will not work correctly in *many* situations. Consider the following functions: my_sum(int4, int4) RETURNS int4 my_sum(int8, int8) RETURNS int8 In a function, a line of code reads: $var = my_sum($1, $2); How do we know which function this is without parsing the code to figure out what $

Re: Feature requests after crash

2002-02-22 Thread Jean-Michel POURE
Le Jeudi 21 Février 2002 23:39, Dave Page a écrit : > Without these parsers, we will not be able to track dependencies within > functions or views. Why do we need parsers? pgAdmin I had very simple queries to track dependencies (ILIKE '%function_foo%' clause). This suffice to build a provides

Re: Feature requests after crash

2002-02-22 Thread Jean-Michel POURE
Dear Dave, pseudo ALTER VIEW is commited to CVS. I changed a little bit pgView->SQL which can be used for any SQL generation. This will make it easier to maintain SQL when PostgreSQL evolves. What do you think? Cheers, Jean-Michel