Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-03-03 Thread Guillaume Lelarge
Le 03/03/2010 22:04, Guillaume Lelarge a écrit : > Le 03/03/2010 22:02, Maga Abdurakhmanov a écrit : >> Any chance to apply this fix? >> > > My bad. I completely forgot about it when I was on holidays. Thanks for > reminding me. Let me check this first. > Applied, thanks. -- Guillaume. http:

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-03-03 Thread Guillaume Lelarge
Le 03/03/2010 22:02, Maga Abdurakhmanov a écrit : > Any chance to apply this fix? > My bad. I completely forgot about it when I was on holidays. Thanks for reminding me. Let me check this first. > On Tue, Feb 23, 2010 at 4:51 PM, Maga Abdurakhmanov wrote: > >> Hi! >> I've found a bug in my prev

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-03-03 Thread Maga Abdurakhmanov
Any chance to apply this fix? On Tue, Feb 23, 2010 at 4:51 PM, Maga Abdurakhmanov wrote: > Hi! > I've found a bug in my previous patch. Font size when highlighting braces > is different from default. > Please see fix in attach. Thanks! > -- Sincerely, Magomed maqdev-brace-font-size.patch De

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-23 Thread Maga Abdurakhmanov
Hi! I've found a bug in my previous patch. Font size when highlighting braces is different from default. Please see fix in attach. Thanks! maqdev-brace-font-size.patch Description: Binary data -- Sent via pgadmin-hackers mailing list ([email protected]) To make changes to your subs

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-14 Thread Guillaume Lelarge
Le 14/02/2010 10:58, Guillaume Lelarge a écrit : > Le 14/02/2010 10:44, Maga Abdurakhmanov a écrit : >> Hi! >> >> Seems like that size parameter of color picker is ignored on Windows. I've >> changed size of color pickers to 25,12d and nothing is changed >> (see an attach). On windows all texts fit

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-14 Thread Guillaume Lelarge
Le 14/02/2010 10:44, Maga Abdurakhmanov a écrit : > Hi! > > Seems like that size parameter of color picker is ignored on Windows. I've > changed size of color pickers to 25,12d and nothing is changed > (see an attach). On windows all texts fits fine. I can't test it on > GTK/Linux, sorry. > I ch

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-14 Thread Maga Abdurakhmanov
Hi! Seems like that size parameter of color picker is ignored on Windows. I've changed size of color pickers to 25,12d and nothing is changed (see an attach). On windows all texts fits fine. I can't test it on GTK/Linux, sorry. > > Thanks. I'm waiting on Maga's answer about the change of width,

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-13 Thread Guillaume Lelarge
Le 13/02/2010 22:51, Dave Page a écrit : > On Sat, Feb 13, 2010 at 9:46 PM, Guillaume Lelarge > wrote: >> Le 13/02/2010 22:30, Guillaume Lelarge a écrit : >>> Le 13/02/2010 20:04, Maga Abdurakhmanov a écrit : Hi, I've made changes to the patch according to Guillaume suggestions. See an a

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-13 Thread Dave Page
On Sat, Feb 13, 2010 at 9:46 PM, Guillaume Lelarge wrote: > Le 13/02/2010 22:30, Guillaume Lelarge a écrit : >> Le 13/02/2010 20:04, Maga Abdurakhmanov a écrit : >>> Hi, I've made changes to the patch according to Guillaume suggestions. >>> See an attached file. Thanks! >>> >> >> So far, so good.

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-13 Thread Guillaume Lelarge
Le 13/02/2010 22:30, Guillaume Lelarge a écrit : > Le 13/02/2010 20:04, Maga Abdurakhmanov a écrit : >> Hi, I've made changes to the patch according to Guillaume suggestions. >> See an attached file. Thanks! >> > > So far, so good. > > I only have one complaint. The UI on GTK is weird. Did you wo

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-13 Thread Guillaume Lelarge
Le 13/02/2010 20:04, Maga Abdurakhmanov a écrit : > Hi, I've made changes to the patch according to Guillaume suggestions. > See an attached file. Thanks! > So far, so good. I only have one complaint. The UI on GTK is weird. Did you work on Windows? (the "Stripping trailing CRs from patch." mess

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-13 Thread Maga Abdurakhmanov
Hi, I've made changes to the patch according to Guillaume suggestions. See an attached file. Thanks! * if "Use system background color" is checked, the associated > wxColourPickerCtrl widgets should be disabled > * the same for "Use system foreground color" > * "Element colour x" doesn't mean

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-10 Thread Guillaume Lelarge
Le 09/02/2010 22:48, Maga Abdurakhmanov a écrit : >> >> >> * "Element colour x" doesn't mean anything to our users, the text >> should be replaced with a better text (for example "SQL words", >> "Text literals", or something better) >> >> > Anybody can help with this? Not me at least. I don't

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-09 Thread Maga Abdurakhmanov
> > > * "Element colour x" doesn't mean anything to our users, the text > should be replaced with a better text (for example "SQL words", > "Text literals", or something better) > > Anybody can help with this? I've found some description of elements in STC sources, but still have questions. D

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-09 Thread Dave Page
On Tue, Feb 9, 2010 at 6:14 AM, Maga Abdurakhmanov wrote: > I don't understand the reason why I should get rid of custom background and > foreground. With this patch you have an option to use system background > colour, or if you like it you can use your own background color, the same is > with th

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-09 Thread Guillaume Lelarge
Le 09/02/2010 07:17, Maga Abdurakhmanov a écrit : >> >> I like it. Seems good to me. Works on Linux. I'm less sure for Mac OS X. >> > > Did the system background color working on linux? > Yes. -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Maga Abdurakhmanov
> > I like it. Seems good to me. Works on Linux. I'm less sure for Mac OS X. > Did the system background color working on linux? > Anyways, the UI needs some more work: > > * if "Use system background color" is checked, the associated > wxColourPickerCtrl widgets should be disabled > * the s

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Maga Abdurakhmanov
I don't understand the reason why I should get rid of custom background and foreground. With this patch you have an option to use system background colour, or if you like it you can use your own background color, the same is with the foreground color. On Tue, Feb 9, 2010 at 12:50 AM, Guillaume Lel

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Guillaume Lelarge
Le 08/02/2010 22:46, Dave Page a écrit : > Yes, I still object. The background colour should come from the OS or > window manager as it would in other apps. > > The highlighting customisation is good though, and essential with the above. > If I understand you correctly, Maga only has to get rid

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Dave Page
Yes, I still object. The background colour should come from the OS or window manager as it would in other apps. The highlighting customisation is good though, and essential with the above. On 2/8/10, Guillaume Lelarge wrote: > Le 08/02/2010 22:39, Dave Page a écrit : >> I should read more carefu

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Guillaume Lelarge
Le 08/02/2010 22:39, Dave Page a écrit : > I should read more carefully :-(. Ignore my last paragraph. > Sorry, I don't get it. You still have an objection to this patch or not ? -- Guillaume. http://www.postgresqlfr.org http://dalibo.com -- Sent via pgadmin-hackers mailing list (pgadmin-h

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Dave Page
I should read more carefully :-(. Ignore my last paragraph. On 2/8/10, Dave Page wrote: > I object. > > The correct solution here is to use the colour configured in the > OS/window manager. > > When that is done, we'll also need a way to allow the user to > configure the syntax highlighting colou

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Dave Page
I object. The correct solution here is to use the colour configured in the OS/window manager. When that is done, we'll also need a way to allow the user to configure the syntax highlighting colours so they don't clash. On 2/8/10, Guillaume Lelarge wrote: > Hi Maga, > > Le 07/02/2010 02:43, Maga

Re: [pgadmin-hackers] SQL Syntax Highlight Configuration

2010-02-08 Thread Guillaume Lelarge
Hi Maga, Le 07/02/2010 02:43, Maga Abdurakhmanov a écrit : > [...] > I'm tired to see always white background of SQL editor, while background > color on my system has another color and is not so bright. > So I implemented feature to allow custom configuration for SQL syntax > highlight, default ba