Re: pgsql: aio: Add core asynchronous I/O infrastructure

2025-03-19 Thread Tom Lane
Andres Freund writes: > On 2025-03-18 11:26:15 -0400, Tom Lane wrote: >> Well, if we don't want to fix it I can just adjust my warning-scraping >> script to ignore these. Let's wait a bit and see if any newer >> compilers warn similarly before deciding. > FWIW, adding a few casts does silence th

Re: pgsql: aio: Add core asynchronous I/O infrastructure

2025-03-19 Thread Andres Freund
Hi, On 2025-03-18 11:26:15 -0400, Tom Lane wrote: > Andres Freund writes: > > I wonder if we should instead either ask those buildfarm animals to be > > disabled or have the warning manually disabled. I don't think it's a good > > investment on our part to work towards warning cleanliness on clan

pgsql: Update a code comment

2025-03-19 Thread Peter Eisentraut
Update a code comment The comment explained that ALTER TABLE ADD CONSTRAINT USING INDEX is only supported with a btree index. (This is not being changed.) The reason is to keep upgrades robust, as explained there. The other part of the comment, that btree is the only unique index kind anyway, i

pgsql: meson: Flush stdout in testwrap

2025-03-19 Thread Andres Freund
meson: Flush stdout in testwrap Otherwise the progress won't reliably be displayed during a test. Reviewed-by: Noah Misch Discussion: https://postgr.es/m/kx6xu7suexal5vwsxpy7ybgkcznx6hgywbuhkr6qabcwxjqax2@i4pcpk75jvaa Backpatch-through: 16 Branch -- master Details --- https://git.post

pgsql: meson: Flush stdout in testwrap

2025-03-19 Thread Andres Freund
meson: Flush stdout in testwrap Otherwise the progress won't reliably be displayed during a test. Reviewed-by: Noah Misch Discussion: https://postgr.es/m/kx6xu7suexal5vwsxpy7ybgkcznx6hgywbuhkr6qabcwxjqax2@i4pcpk75jvaa Backpatch-through: 16 Branch -- REL_16_STABLE Details --- https://g

pgsql: Add some new hooks so extensions can add details to EXPLAIN.

2025-03-19 Thread Robert Haas
Add some new hooks so extensions can add details to EXPLAIN. Specifically, add a per-node hook that is called after the per-node information has been displayed but before we display children, and a per-query hook that is called after existing query-level information is printed. This assumes that e