pgsql: aio: Fix crash potential for pg_aios views due to late state upd

2025-04-25 Thread Andres Freund
aio: Fix crash potential for pg_aios views due to late state update pgaio_io_reclaim() reset the fields in PgAioHandle before updating the state to IDLE or incrementing the generation. For most things that's OK, but for pg_get_aios() it is not - if it copied the PgAioHandle while fields were being

pgsql: aio: Improve debug logging around waiting for IOs

2025-04-25 Thread Andres Freund
aio: Improve debug logging around waiting for IOs Trying to investigate a bug report by Alexander Lakhin made it apparent that the debug logging around waiting for IO completion is insufficient. Fix that. Discussion: https://postgr.es/m/h4in2db37vepagmi2oz5vvqymjasc5gyb4lpqkunj4eusu274i@37jpd3c2

pgsql: Fix bug allowing io_combine_limit > io_max_combine_combine limit

2025-04-25 Thread Andres Freund
Fix bug allowing io_combine_limit > io_max_combine_combine limit 10f66468475 intended to limit the value of io_combine_limit to the minimum of io_combine_limit and io_max_combine_limit. To avoid issues with interdependent GUCs, it introduced io_combine_limit_guc and set io_combine_limit in assign

pgsql: Fix incorrect format placeholders

2025-04-25 Thread Peter Eisentraut
Fix incorrect format placeholders Before commit a0ed19e0a9e there was a cast around these, but the cast inadvertently changed the signedness, but that made the format placeholder correct. Commit a0ed19e0a9e removed the casts, so now the format placeholders had the wrong signedness. Branch --

pgsql: Fix terminology in comment and message

2025-04-25 Thread Peter Eisentraut
Fix terminology in comment and message Should be "bracket" not "brace" for []. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/385959bdeafb2e4c4b02adb55b78bde6eac616f7 Modified Files -- src/interfaces/ecpg/preproc/variable.c | 8 1 file changed,

pgsql: Small code consistency improvement

2025-04-25 Thread Peter Eisentraut
Small code consistency improvement Adjust the way the increment operators are placed to be consistent throughout the function. Fixup for commit commit c1da7281060. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/0787646e1dce966395f211fb9475dcab32daae70 Modified Fi

pgsql: Fix typo in test file name added in commit 4909b38af0.

2025-04-25 Thread Amit Kapila
Fix typo in test file name added in commit 4909b38af0. Author: Shlok Kyal Backpatch-through: 13 Discussion: https://postgr.es/m/canhcyexsobdjkjxenq10ajumdpa5j6aipzgth_w4kcwryhl...@mail.gmail.com Branch -- REL_17_STABLE Details --- https://git.postgresql.org/pg/commitdiff/d96206f259d679

pgsql: Fix typo in test file name added in commit 4909b38af0.

2025-04-25 Thread Amit Kapila
Fix typo in test file name added in commit 4909b38af0. Author: Shlok Kyal Backpatch-through: 13 Discussion: https://postgr.es/m/canhcyexsobdjkjxenq10ajumdpa5j6aipzgth_w4kcwryhl...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/50b8ad30f7541ff48f50a

pgsql: Fix typo in test file name added in commit 4909b38af0.

2025-04-25 Thread Amit Kapila
Fix typo in test file name added in commit 4909b38af0. Author: Shlok Kyal Backpatch-through: 13 Discussion: https://postgr.es/m/canhcyexsobdjkjxenq10ajumdpa5j6aipzgth_w4kcwryhl...@mail.gmail.com Branch -- REL_15_STABLE Details --- https://git.postgresql.org/pg/commitdiff/90bc4523fd47e5

pgsql: Fix typo in test file name added in commit 4909b38af0.

2025-04-25 Thread Amit Kapila
Fix typo in test file name added in commit 4909b38af0. Author: Shlok Kyal Backpatch-through: 13 Discussion: https://postgr.es/m/canhcyexsobdjkjxenq10ajumdpa5j6aipzgth_w4kcwryhl...@mail.gmail.com Branch -- REL_13_STABLE Details --- https://git.postgresql.org/pg/commitdiff/4164d6976316ef

pgsql: Fix typo in test file name added in commit 4909b38af0.

2025-04-25 Thread Amit Kapila
Fix typo in test file name added in commit 4909b38af0. Author: Shlok Kyal Backpatch-through: 13 Discussion: https://postgr.es/m/canhcyexsobdjkjxenq10ajumdpa5j6aipzgth_w4kcwryhl...@mail.gmail.com Branch -- REL_14_STABLE Details --- https://git.postgresql.org/pg/commitdiff/bb1bc9fa962ed7

pgsql: Fix typo in test file name added in commit 4909b38af0.

2025-04-25 Thread Amit Kapila
Fix typo in test file name added in commit 4909b38af0. Author: Shlok Kyal Backpatch-through: 13 Discussion: https://postgr.es/m/canhcyexsobdjkjxenq10ajumdpa5j6aipzgth_w4kcwryhl...@mail.gmail.com Branch -- REL_16_STABLE Details --- https://git.postgresql.org/pg/commitdiff/9987c94662c25f