Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

2025-04-26 Thread Peter Geoghegan
On Sat, Apr 26, 2025 at 10:39 PM Mark Dilger wrote: > Peter, Matthias, thanks kindly for the good work on skipscans! Thanks! > I found a test case which fails after commit > 21a152b37f36c9563d1b0b058fe1436baf578b4c. Please find a reproducible test > case, attached. The bug isn't actually in

Re: pgsql: Improve nbtree skip scan primitive scan scheduling.

2025-04-26 Thread Mark Dilger
Peter, Matthias, thanks kindly for the good work on skipscans! While admiring the recent performance improvements, I found a test case which fails after commit 21a152b37f36c9563d1b0b058fe1436baf578b4c. Please find a reproducible test case, attached. Thanks! On Fri, Apr 4, 2025 at 10:58 AM Pet

pgsql: Don't use double-quotes in #include's of system headers.

2025-04-26 Thread Tom Lane
Don't use double-quotes in #include's of system headers. While few if any C compilers will complain about this, it's inconsistent with our other #include's of the same headers. There are some other questionable usages in src/include/jit/SectionMemoryManager.h and src/pl/plperl/plperl_system.h, bu

pgsql: Eliminate divide in new fast-path locking code

2025-04-26 Thread David Rowley
Eliminate divide in new fast-path locking code c4d5cb71d2 adjusted the fast-path locking code to allow some configuration of the number of fast-path locking slots via the max_locks_per_transaction GUC. In that commit the FAST_PATH_REL_GROUP() macro used integer division to determine the fast-path

Re: clang-tidy complaints

2025-04-26 Thread John Naylor
On Sat, Apr 12, 2025 at 11:25 PM Peter Geoghegan wrote: > > I just pushed my annual commit that makes function parameter names > consistent between function declarations and their corresponding > definitions, to cover the Postgres 18 cycle. The new CRC function this touched was right in the heade

pgsql: Match parameter in new function to earlier equivalents

2025-04-26 Thread John Naylor
Match parameter in new function to earlier equivalents Oversight in commit 3c6e8c123. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/27757677ca4da566ff21f65c58a008818afb5b06 Modified Files -- src/include/port/pg_crc32c.h | 2 +- src/port/pg_crc32c_sse42

pgsql: doc: improve wording of vacuum_max_eager_freeze_failure_rate

2025-04-26 Thread Bruce Momjian
doc: improve wording of vacuum_max_eager_freeze_failure_rate Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/10e8176950b14ab7710a1ea65cad3179b52edbe3 Modified Files -- doc/src/sgml/config.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)