pgsql: Fix a couple of comment typos

2025-04-29 Thread David Rowley
Fix a couple of comment typos Author: Junwang Zhao Discussion: https://postgr.es/m/caeg8a3+mrwdkc4ysfkkpkq7y+vmufvc5u94wm5kzpb2cbgc...@mail.gmail.com Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/d8555e522eca00f1b4b6cd0b75269b7176fb7931 Modified Files -

pgsql: Give up on running with NetBSD/OpenBSD's default semaphore setti

2025-04-29 Thread Tom Lane
Give up on running with NetBSD/OpenBSD's default semaphore settings. This reverts commit 38da053463bef32adf563ddee5277d16d2b6c5af, which attempted to preserve our ability to start with only 60 semaphores. Subsequent changes (particularly 55b454d0e) have put that idea pretty much permanently out o

pgsql: oauth: Disallow OAuth connections via postgres_fdw/dblink

2025-04-29 Thread Jacob Champion
oauth: Disallow OAuth connections via postgres_fdw/dblink A subsequent commit will reclassify oauth_client_secret from dispchar="" to dispchar="*", so that UIs will treat it like a secret. For our FDWs, this change will move that option from SERVER to USER MAPPING, which we need to avoid. But upo

pgsql: Bump the minimum supported Python version to 3.6.8

2025-04-29 Thread Jacob Champion
Bump the minimum supported Python version to 3.6.8 Python 3.2 is no longer tested by the buildfarm, and there are only a handful of buildfarm animals running versions older than 3.6, which itself went end-of-life in 2021. Python 3.6.8 is the default version shipped in RHEL8, so that seems like a r

pgsql: oauth: Classify oauth_client_secret as a password

2025-04-29 Thread Jacob Champion
oauth: Classify oauth_client_secret as a password Tell UIs to hide the value of oauth_client_secret, like the other passwords. Due to the previous commit, this does not affect postgres_fdw and dblink, but add a comment to try to warn others of the hazard in the future. Reported-by: Noah Misch Re

pgsql: Fix whitespace typo in string

2025-04-29 Thread Peter Eisentraut
Fix whitespace typo in string Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/eec34099c3bfe0ed4b33e77f38cab3b221cd3b37 Modified Files -- src/bin/pg_resetwal/pg_resetwal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgsql: initdb: Do not report default autovacuum_worker_slots.

2025-04-29 Thread Nathan Bossart
initdb: Do not report default autovacuum_worker_slots. Commit 6d01541960 taught initdb to lower the default value of autovacuum_worker_slots for systems with very few semaphores. It also added a "fake" report for the chosen value, i.e., initdb prints a message about selecting the default, but the

pgsql: doc: adjust max_files_per_process again

2025-04-29 Thread Bruce Momjian
doc: adjust max_files_per_process again Reported-by: Andres Freund Discussion: https://postgr.es/m/5yqochswkulckuzzrwgv2nqdrfh4k4coc4uwq4lvgzkfwnbjbd@46igbiwjabn2 Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/faced8e6a40b469bf9603db868beb6604c95df32 Modified F

Re: pgsql: doc: clarify new behavior of max_files_per_process

2025-04-29 Thread Bruce Momjian
On Tue, Apr 29, 2025 at 10:26:50AM -0400, Bruce Momjian wrote: > On Tue, Apr 29, 2025 at 09:52:03AM -0400, Andres Freund wrote: > > Hi, > > > > On 2025-04-29 13:45:44 +, Bruce Momjian wrote: > > > doc: clarify new behavior of max_files_per_process > > > > I don't think this really is an impr

Re: pgsql: doc: clarify new behavior of max_files_per_process

2025-04-29 Thread Bruce Momjian
On Tue, Apr 29, 2025 at 09:52:03AM -0400, Andres Freund wrote: > Hi, > > On 2025-04-29 13:45:44 +, Bruce Momjian wrote: > > doc: clarify new behavior of max_files_per_process > > I don't think this really is an improvement - if postmaster is called with a > bunch of files already opened, the

Re: pgsql: doc: clarify new behavior of max_files_per_process

2025-04-29 Thread Andres Freund
Hi, On 2025-04-29 13:45:44 +, Bruce Momjian wrote: > doc: clarify new behavior of max_files_per_process I don't think this really is an improvement - if postmaster is called with a bunch of files already opened, they aren't opened by postmaster, but still are ignored... Greetings, Andres

pgsql: doc: clarify new behavior of max_files_per_process

2025-04-29 Thread Bruce Momjian
doc: clarify new behavior of max_files_per_process Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/9a9e60fed39268bb85b59dde3cdb0b0166c85cc5 Modified Files -- doc/src/sgml/config.sgml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgsql: doc: Small example improvement

2025-04-29 Thread Peter Eisentraut
doc: Small example improvement Add a comment character before a line annotation, so that the query can be used as presented. Reported-by: Yaroslav Saburov Author: Euler Taveira Reviewed-by: Robert Treat Discussion: https://www.postgresql.org/message-id/flat/174393459040.678.178101524104194447

pgsql: Fixes for ChangeVarNodes_walker()

2025-04-29 Thread Alexander Korotkov
Fixes for ChangeVarNodes_walker() This commit fixes two bug in ChangeVarNodes_walker() function. * When considering RestrictInfo, walk down to its clauses based on the presense of relid to be deleted not just in clause_relids but also in required_relids. * Incrementally adjust num_base_r

pgsql: pg_restore: Improve --help synopsis

2025-04-29 Thread Peter Eisentraut
pg_restore: Improve --help synopsis The --help synopsis should only be one line. This rephrases the first line a bit to reflect the new functionality of restoring multiple databases from pg_dumpall output. Additional explanations are better kept in the man page. Branch -- master Details --

pgsql: pg_restore: Put new option in consistent order in --help output

2025-04-29 Thread Peter Eisentraut
pg_restore: Put new option in consistent order in --help output Also make the description a bit more consistent with similar options. Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/dadc58f50ac9697907e04422615d79762533496c Modified Files -- src/bin/pg_d

pgsql: Fix assertion failure during decoding from synced slots.

2025-04-29 Thread Amit Kapila
Fix assertion failure during decoding from synced slots. The slot synchronization skips updating the confirmed_flush LSN of the local slot if the local slot has a newer catalog_xmin or restart_lsn, but still allows updating the two_phase and two_phase_at fields of the slot. This opens up a window

pgsql: pg_verifybackup: Message style improvements

2025-04-29 Thread Peter Eisentraut
pg_verifybackup: Message style improvements Branch -- master Details --- https://git.postgresql.org/pg/commitdiff/ef1811ac9a7b9c5accde1652c22fb041cb0f34b3 Modified Files -- src/bin/pg_verifybackup/astreamer_verify.c | 12 ++-- src/bin/pg_verifybackup/pg_verifybackup.c

pgsql: test_slru: Fix incorrect format placeholders

2025-04-29 Thread Peter Eisentraut
test_slru: Fix incorrect format placeholders Before commit a0ed19e0a9e there was a cast around these, but the cast inadvertently changed the signedness, but that made the format placeholder correct. Commit a0ed19e0a9e removed the casts, so now the format placeholders had the wrong signedness. Br