On Sun, Apr 27, 2025 at 4:25 AM Bertrand Drouvot
wrote:
> +1. Peter, do you think you could add "misc-header-include-cycle" in your
> annual check (see [1])? I'll also put a note on my side to do it at a regular
> basis.
I've added it to my personal clangd config (I mostly use clang-tidy
through
Hi,
On Sat, Apr 12, 2025 at 01:16:39PM -0400, Tom Lane wrote:
> Peter Geoghegan writes:
> > Looks like I'm done with this process, at least until this time next year.
>
> OK. Thanks for taking care of it.
+1. Peter, do you think you could add "misc-header-include-cycle" in your
annual check (s
On Sat, Apr 12, 2025 at 11:25 PM Peter Geoghegan wrote:
>
> I just pushed my annual commit that makes function parameter names
> consistent between function declarations and their corresponding
> definitions, to cover the Postgres 18 cycle.
The new CRC function this touched was right in the heade
Peter Geoghegan writes:
> Looks like I'm done with this process, at least until this time next year.
OK. Thanks for taking care of it.
regards, tom lane
echnically, this is a
> > distinct type of complaint to the clang-tidy complaints that I
> > ordinarily fix this time of year, though it's of the same general
> > nature.
>
> Isn't that obsolete in the wake of 55ef7abf8? I'd be inclined to
> leave it alone if no l
Peter Geoghegan writes:
> The first such complaint concerns a new mcxt.c function parameter that
> shadows a global variable in the same file -- attached patch fixes
> that by renaming the function parameter. Technically, this is a
> distinct type of complaint to the clang-tidy compl
nt to the clang-tidy complaints that I
ordinarily fix this time of year, though it's of the same general
nature.
The second such complaint is a standard "function parameter name is
inconsistent" complaint, though it's one that affects vendored code in
src/include/snowball/libste
