Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Robert Haas writes: > At the risk of being labeled a stickler for the details, this thread > is both on the wrong mailing list and discussing a topic quite > different from what the subject line would suggest. Fair complaint. Redirected to -hackers at https://postgr.es/m/[email protected]

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

On Tue, May 21, 2019 at 4:50 PM Andres Freund wrote: > Indeed. At the risk of being labeled a stickler for the details, this thread is both on the wrong mailing list and discussing a topic quite different from what the subject line would suggest. -- Robert Haas EnterpriseDB: http://www.enterpri

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-21 16:47:55 -0400, Tom Lane wrote: > Andres Freund writes: > > -check: test.sh all > > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > > +check: test.sh all temp-install > > + MAKE=$(MAKE) $(with_tem

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > -check: test.sh all > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > +check: test.sh all temp-install > + MAKE=$(MAKE) $(with_temp_install) > bindir=$(abs_top_builddir)/tmp_install/$(bind

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-20 17:47:17 -0700, Andres Freund wrote: > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: > > Andres Freund writes: > > > On 2019-05-20 14:09:40 -0400, Tom Lane wrote: > > > 3) The fact that src/bin/pg_upgrade/Makefile invokes test.sh with > > >MAKE=$(MAKE) triggers make, for rea

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > On 2019-05-21 10:20:57 -0400, Tom Lane wrote: >> The least invasive way to do that seems to be as attached, building a >> little knowledge into pg_regress's psql_command() function. Alternatively >> we could add a "bool quiet" parameter to that function so that callers >>

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-21 10:20:57 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: > >> The other thing I had to do below was to suppress "NOTICE: database > >> "regression" does not exist, skipping". The added createdb is a > >> mighty expensive and grot

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: >> The other thing I had to do below was to suppress "NOTICE: database >> "regression" does not exist, skipping". The added createdb is a >> mighty expensive and grotty way to do that, but I didn't immediately >> see a better o

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > On 2019-05-20 20:19:20 -0400, Tom Lane wrote: >> The other thing I had to do below was to suppress "NOTICE: database >> "regression" does not exist, skipping". The added createdb is a >> mighty expensive and grotty way to do that, but I didn't immediately >> see a better o

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-20 20:19:20 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-20 14:09:40 -0400, Tom Lane wrote: > >> What I'd like, for both prove and pg_regress, is to print something > >> about failing tests and otherwise be quiet. Simple redirection won't > >> do that. Plus it'd

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > On 2019-05-20 14:09:40 -0400, Tom Lane wrote: >> What I'd like, for both prove and pg_regress, is to print something >> about failing tests and otherwise be quiet. Simple redirection won't >> do that. Plus it'd be hard to fit that in with the case where you >> don't want

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-20 14:09:40 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-20 13:46:55 -0400, Tom Lane wrote: > >> If there were a way to get prove to be absolutely quiet (its --quiet is > >> a joke unfortunately), I'd lobby for a switch to make pg_regress quiet > >> too. The amoun

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > On 2019-05-20 13:46:55 -0400, Tom Lane wrote: >> If there were a way to get prove to be absolutely quiet (its --quiet is >> a joke unfortunately), I'd lobby for a switch to make pg_regress quiet >> too. The amount of useless noise this recipe generates is annoying, >> and

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-20 13:46:55 -0400, Tom Lane wrote: > Andres Freund writes: > > On 2019-05-21 01:43:35 +0900, Fujii Masao wrote: > >> Thanks for the commit! And sorry, make check-world took very long time > >> and has just finished right now in my env... I'd like to confirm that > >> make check-wor

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Andres Freund writes: > On 2019-05-21 01:43:35 +0900, Fujii Masao wrote: >> Thanks for the commit! And sorry, make check-world took very long time >> and has just finished right now in my env... I'd like to confirm that >> make check-world reports no error just in case. > make -j16 -s && make -Ot

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-21 01:43:35 +0900, Fujii Masao wrote: > On Tue, May 21, 2019 at 1:36 AM Andres Freund wrote: > > On 2019-05-21 01:03:06 +0900, Fujii Masao wrote: > > > On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > > > > > > > Fujii Masao writes: > > > > > Make VACUUM accept 1 and 0 as a b

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

On Tue, May 21, 2019 at 1:36 AM Andres Freund wrote: > > Hi, > > On 2019-05-21 01:03:06 +0900, Fujii Masao wrote: > > On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > > > > > Fujii Masao writes: > > > > Make VACUUM accept 1 and 0 as a boolean value. > > > > > > This was not a particularly gr

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Hi, On 2019-05-21 01:03:06 +0900, Fujii Masao wrote: > On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > > > Fujii Masao writes: > > > Make VACUUM accept 1 and 0 as a boolean value. > > > > This was not a particularly great thing to be pushing on a release > > wrap day, and pushing it without

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

On Tue, May 21, 2019 at 12:43 AM Tom Lane wrote: > > Fujii Masao writes: > > Make VACUUM accept 1 and 0 as a boolean value. > > This was not a particularly great thing to be pushing on a release > wrap day, and pushing it without having even run the core regression > tests was downright negligent

Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Fujii Masao writes: > Make VACUUM accept 1 and 0 as a boolean value. This was not a particularly great thing to be pushing on a release wrap day, and pushing it without having even run the core regression tests was downright negligent. Please fix or revert, NOW. regards,

pgsql: Make VACUUM accept 1 and 0 as a boolean value.

Make VACUUM accept 1 and 0 as a boolean value. Commit 41b54ba78e allowed existing VACUUM options to take a boolean argument. It's documented that valid boolean values that VACUUM can accept are true, false, on, off, 1, and 0. But previously the parser failed to accept 1 and 0 as a boolean value in