Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

2020-01-02 Thread Julien Rouhaud
On Thu, Jan 2, 2020 at 7:50 PM Tom Lane wrote: > > Julien Rouhaud writes: > > On Thu, Jan 2, 2020 at 6:41 PM Tom Lane wrote: > >> Hmm, the buildfarm seems to think this screwed up something affecting > >> collations. Looking ... > > > Is ORDER BY 1 COLLATE "C" an option here? > > Nah, that woul

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

2020-01-02 Thread Tom Lane
Julien Rouhaud writes: > On Thu, Jan 2, 2020 at 6:41 PM Tom Lane wrote: >> Hmm, the buildfarm seems to think this screwed up something affecting >> collations. Looking ... > Is ORDER BY 1 COLLATE "C" an option here? Nah, that would just mask the bug not fix it. See 4d02eb017.

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

2020-01-02 Thread Julien Rouhaud
On Thu, Jan 2, 2020 at 6:41 PM Tom Lane wrote: > > Tom Lane writes: > > Make parser rely more heavily on the ParseNamespaceItem data structure. > > Hmm, the buildfarm seems to think this screwed up something affecting > collations. Looking ... My animal is using fr_FR collation by default, and

Re: pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

2020-01-02 Thread Tom Lane
Tom Lane writes: > Make parser rely more heavily on the ParseNamespaceItem data structure. Hmm, the buildfarm seems to think this screwed up something affecting collations. Looking ... regards, tom lane

pgsql: Make parser rely more heavily on the ParseNamespaceItem data str

2020-01-02 Thread Tom Lane
Make parser rely more heavily on the ParseNamespaceItem data structure. When I added the ParseNamespaceItem data structure (in commit 5ebaaa494), it wasn't very tightly integrated into the parser's APIs. In the wake of adding p_rtindex to that struct (commit b541e9acc), there is a good reason to