[COMMITTERS] pgsql: Some code review for xml.c: Add some more xml_init() calls that

2007-11-05 Thread Tom Lane
Log Message: --- Some code review for xml.c: Add some more xml_init() calls that might not be necessary, but seem like a good idea to avoid possible problems like we saw in xmlelement(). Fix unsafe assumption that you can keep using the tupledesc of a relcache entry you don't have open. Add

[COMMITTERS] pgsql: Fix xmlelement() to initialize libxml correctly before using it,

2007-11-05 Thread Tom Lane
Log Message: --- Fix xmlelement() to initialize libxml correctly before using it, and to avoid assuming that evaluation of its input expressions won't change the state of libxml. This requires refactoring xml_init() to not call xmlInitParser(), since now not all of its callers want that.

[COMMITTERS] npgsql - Npgsql2: Added initial information about System.Transactions

2007-11-05 Thread User Fxjr
Log Message: --- Added initial information about System.Transactions support. Thanks Josh Cooley Modified Files: -- Npgsql2/docs: UserManual.html (r1.3 -> r1.4) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/npgsql/Npgsql2/docs/UserManual.html.diff?r1=1.3&r2

[COMMITTERS] pgsql: Fix deprecated-by-C-spec usage: storage class should come before

2007-11-05 Thread Tom Lane
Log Message: --- Fix deprecated-by-C-spec usage: storage class should come before const decoration. Zdenek Kotala Modified Files: -- pgsql/src/interfaces/ecpg/ecpglib: prepare.c (r1.22 -> r1.23) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfa

[COMMITTERS] pgsql: Improve conversion of legacy CREATE CONSTRAINT TRIGGER

2007-11-05 Thread Tom Lane
Log Message: --- Improve conversion of legacy CREATE CONSTRAINT TRIGGER representation of foreign keys, one more time. Insist on matching up all three triggers before we create a constraint; this will avoid creation of duplicate constraints in scenarios where a broken FK constraint was rep

[COMMITTERS] pgsql: Document that configure option only affects contrib:

2007-11-05 Thread Bruce Momjian
Log Message: --- Document that configure option only affects contrib: --with-ossp-uuiduse OSSP UUID library when building /contrib/uuid-ossp Modified Files: -- pgsql: configure (r1.568 -> r1.569) (http://developer.postgresql.org/cvsweb.cgi/pgsql/c

[COMMITTERS] pgsql: Document that syncronhous commit can be turned off in a single

2007-11-05 Thread Bruce Momjian
Log Message: --- Document that syncronhous commit can be turned off in a single multi-statement transaction. Modified Files: -- pgsql/doc/src/sgml: config.sgml (r1.152 -> r1.153) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/config.sgml?r1=

[COMMITTERS] pgsql: Minor editorial improvements to txid functions' documentation:

2007-11-05 Thread Tom Lane
Log Message: --- Minor editorial improvements to txid functions' documentation: put back some text that got dropped, improve markup, improve descriptions of snapshot components. Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.409 -> r1.410) (http://dev

[COMMITTERS] pgsql: Properly pass third argument to open() in fsync test program.

2007-11-05 Thread Bruce Momjian
Log Message: --- Properly pass third argument to open() in fsync test program. Hiroshi Saito Modified Files: -- pgsql/src/tools/fsync: test_fsync.c (r1.18 -> r1.19) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/tools/fsync/test_fsync.c?r1=1.18&r2=1

Re: [COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> I thought the stuff was adequately documented already, which is why I > >> suggest just reverting this. > > > OK, so how about removing just the "Query Function" column. I thought > > the field descriptions where

[COMMITTERS] pgsql: Remove of txid functions.

2007-11-05 Thread Bruce Momjian
Log Message: --- Remove of txid functions. Modified Files: -- pgsql/doc/src/sgml: func.sgml (r1.408 -> r1.409) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/func.sgml?r1=1.408&r2=1.409) ---(end of broadcast)---

[COMMITTERS] pgsql: Move txid snapshot field description table from datatype to

2007-11-05 Thread Bruce Momjian
Log Message: --- Move txid snapshot field description table from datatype to functions section. Modified Files: -- pgsql/doc/src/sgml: datatype.sgml (r1.213 -> r1.214) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/datatype.sgml?r1=1.213&r2=

Re: [COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> I thought the stuff was adequately documented already, which is why I >> suggest just reverting this. > OK, so how about removing just the "Query Function" column. I thought > the field descriptions where useful. What I'm objecting t

Re: [COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> [EMAIL PROTECTED] (Bruce Momjian) writes: > > Log Message: > > --- > > Document txid functions. > >> > >> Please revert this change. It makes these functions far more prominent > >> than is justified. >

Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before

2007-11-05 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Gregory Stark <[EMAIL PROTECTED]> writes: >> FWIW I found another issue with this variable when I was experimenting with >> small block sizes. If you set the target <= the tuple header the toaster >> breaks. This is because it's doing unsigned arithmetic (S

Re: [COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> [EMAIL PROTECTED] (Bruce Momjian) writes: > Log Message: > --- > Document txid functions. >> >> Please revert this change. It makes these functions far more prominent >> than is justified. > Have you looked at the output? Ye

Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before

2007-11-05 Thread Tom Lane
Gregory Stark <[EMAIL PROTECTED]> writes: > FWIW I found another issue with this variable when I was experimenting with > small block sizes. If you set the target <= the tuple header the toaster > breaks. This is because it's doing unsigned arithmetic (Size is unsigned). I > think the right solutio

Re: [COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Bruce Momjian
Tom Lane wrote: > [EMAIL PROTECTED] (Bruce Momjian) writes: > > Log Message: > > --- > > Document txid functions. > > Please revert this change. It makes these functions far more prominent > than is justified. Have you looked at the output? My commit message wasn't clear. What the patc

Re: [COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Tom Lane
[EMAIL PROTECTED] (Bruce Momjian) writes: > Log Message: > --- > Document txid functions. Please revert this change. It makes these functions far more prominent than is justified. regards, tom lane ---(end of broadcast)

[COMMITTERS] pgsql: Fix typos.

2007-11-05 Thread Magnus Hagander
Log Message: --- Fix typos. Guillaume Lelarge Modified Files: -- pgsql/doc/src/sgml: textsearch.sgml (r1.29 -> r1.30) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/textsearch.sgml?r1=1.29&r2=1.30) ---(end of broadc

[COMMITTERS] pgbouncer - pgbouncer: comment cleanup, use original macro names

2007-11-05 Thread User Mkz
Log Message: --- comment cleanup, use original macro names Modified Files: -- pgbouncer/src: hash.c (r1.2 -> r1.3) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgbouncer/pgbouncer/src/hash.c.diff?r1=1.2&r2=1.3) ---(end of broadcast)

[COMMITTERS] plproxy - plproxy: explicit type casting for result fields

2007-11-05 Thread User Mkz
Log Message: --- explicit type casting for result fields Modified Files: -- plproxy/src: query.c (r1.3 -> r1.4) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/plproxy/plproxy/src/query.c.diff?r1=1.3&r2=1.4) ---(end of broadcast)--

Re: [COMMITTERS] pgsql: Add a note about another issue that needs to be considered before

2007-11-05 Thread Gregory Stark
"Tom Lane" <[EMAIL PROTECTED]> writes: > Log Message: > --- > Add a note about another issue that needs to be considered before > changing the TOAST size thresholds. FWIW I found another issue with this variable when I was experimenting with small block sizes. If you set the target <= th

[COMMITTERS] pgsql: Document txid functions.

2007-11-05 Thread Bruce Momjian
Log Message: --- Document txid functions. Marko Kreen Modified Files: -- pgsql/doc/src/sgml: datatype.sgml (r1.212 -> r1.213) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/datatype.sgml?r1=1.212&r2=1.213) func.sgml (r1.406 -> r1.40

[COMMITTERS] pgloader - pgloader: Improve summary output

2007-11-05 Thread User Dim
Log Message: --- Improve summary output Modified Files: -- pgloader: pgloader.py (r1.3 -> r1.4) (http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/pgloader/pgloader/pgloader.py.diff?r1=1.3&r2=1.4) ---(end of broadcast)

[COMMITTERS] pgsql: Add a note about another issue that needs to be considered before

2007-11-05 Thread Tom Lane
Log Message: --- Add a note about another issue that needs to be considered before changing the TOAST size thresholds. Modified Files: -- pgsql/src/include/access: tuptoaster.h (r1.35 -> r1.36) (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/a

[COMMITTERS] pgsql: Remove deprecation notice and add comment about safely restoring

2007-11-05 Thread D'Arcy J.M. Cain
Log Message: --- Remove deprecation notice and add comment about safely restoring backups. As per discussion on hackers. Modified Files: -- pgsql/doc/src/sgml: datatype.sgml (r1.211 -> r1.212) (http://developer.postgresql.org/cvsweb.cgi/pgsql/doc/src/sgml/d

[COMMITTERS] pgsql: Use LOG instead of DEBUG2 for logging invalid cancel requests.

2007-11-05 Thread Neil Conway
Log Message: --- Use LOG instead of DEBUG2 for logging invalid cancel requests. (That is, cancel requests with an incorrect key, or with a non-existent PID). Per recent discussion on -hackers. Modified Files: -- pgsql/src/backend/postmaster: postmaster.c (r1.543 ->